Skip to contentSkip to conversation

ELF: make BAD_ADDR() unlikely

PATCH New Alexey Dobriyan 1 participant 1 message Dec 15, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ELF: make BAD_ADDR() unlikely

If some mapping goes past TASK_SIZE it will be rejected by kernel which means no such userspace binaries exist.

Mark every such check as unlikely.

---

 fs/binfmt_elf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/binfmt_elf.c +1 -1
@@ -97,7 +97,7 @@ static struct linux_binfmt elf_format = {
 	.min_coredump	= ELF_EXEC_PAGESIZE,
 };
 
-#define BAD_ADDR(x) ((unsigned long)(x) >= TASK_SIZE)
+#define BAD_ADDR(x) (unlikely((unsigned long)(x) >= TASK_SIZE))
 
 static int set_brk(unsigned long start, unsigned long end, int prot)
 {