Skip to contentSkip to conversation

lib: crc64: include <linux/crc64.h> for 'crc64_be'

PATCH In review Ben Dooks (Codethink) 3 participants 4 messages Dec 17, 2019 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: crc64: include <linux/crc64.h> for 'crc64_be'

The crc64_be() is declared in <linux/crc64.h> so include this where the symbol is defined to avoid the following warning:

lib/crc64.c:43:12: warning: symbol 'crc64_be' was not declared. Should it be static?

---
Cc: Coly Li <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: [email protected]

---
 lib/crc64.c | 1 +
 1 file changed, 1 insertion(+)
lib/crc64.c +1 -0
index 0ef8ae6ac047..f8928ce28280 100644
@@ -28,6 +28,7 @@
 
 #include <linux/module.h>
 #include <linux/types.h>
+#include <linux/crc64.h>
 #include "crc64table.h"
 
 MODULE_DESCRIPTION("CRC64 calculations");
Signature · 1 line
2.24.0
#1 lore raw
Quoted 7 lines · Ben Dooks (Codethink)

The crc64_be() is declared in <linux/crc64.h> so include this where the symbol is defined to avoid the following warning:

lib/crc64.c:43:12: warning: symbol 'crc64_be' was not declared. Should it be static?

It is good to me. Added to my for-test patches. Thanks.

Coly Li

Quoted 21 lines

---
Cc: Coly Li <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: [email protected]

---
 lib/crc64.c | 1 +
 1 file changed, 1 insertion(+)
lib/crc64.c +1 -0
index 0ef8ae6ac047..f8928ce28280 100644
@@ -28,6 +28,7 @@
 
 #include <linux/module.h>
 #include <linux/types.h>
+#include <linux/crc64.h>
 #include "crc64table.h"
 
 MODULE_DESCRIPTION("CRC64 calculations");
Reviewed-by on v1 1/1
#2 lore raw
In reply to Ben Dooks (Codethink)
Quoted 5 lines · Ben Dooks (Codethink)

The crc64_be() is declared in <linux/crc64.h> so include this where the symbol is defined to avoid the following warning:

lib/crc64.c:43:12: warning: symbol 'crc64_be' was not declared. Should it be static?

Thanks!

Quoted 25 lines

---
Cc: Coly Li <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: [email protected]

---
 lib/crc64.c | 1 +
 1 file changed, 1 insertion(+)
lib/crc64.c +1 -0
index 0ef8ae6ac047..f8928ce28280 100644
@@ -28,6 +28,7 @@
 
 #include <linux/module.h>
 #include <linux/types.h>
+#include <linux/crc64.h>
 #include "crc64table.h"
 
 MODULE_DESCRIPTION("CRC64 calculations");
Signature · 1 line
2.24.0
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 5 lines · Ben Dooks (Codethink)

The crc64_be() is declared in <linux/crc64.h> so include this where the symbol is defined to avoid the following warning:

lib/crc64.c:43:12: warning: symbol 'crc64_be' was not declared. Should it be static?

Thanks!

Sorry, one nit to be addressed...

Quoted 15 lines
Quoted 15 lines

---
Cc: Coly Li <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: [email protected]

---
 lib/crc64.c | 1 +
 1 file changed, 1 insertion(+)
lib/crc64.c +0 -0
index 0ef8ae6ac047..f8928ce28280 100644
@@ -28,6 +28,7 @@
 
Quoted 4 lines

lib/crc64.c

Quoted 4 lines
lib/crc64.c +1 -0
 #include <linux/module.h>
 #include <linux/types.h>
 
+#include <linux/crc64.h>

May we preserve ordering, i.e. it should be first header in the block.

Quoted 12 lines
Quoted 6 lines
lib/crc64.c +0 -0
 #include "crc64table.h"
 

MODULE_DESCRIPTION("CRC64 calculations");

Signature · 1 line
2.24.0
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Signature · 2 lines
With Best Regards,
Andy Shevchenko