Skip to contentSkip to conversation

scsi: csiostor: Adjust indentation in csio_device_reset

PATCH Applied Nathan Chancellor 2 participants 2 messages Dec 18, 2019 – Dec 19, 2019 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: csiostor: Adjust indentation in csio_device_reset

Clang warns:

../drivers/scsi/csiostor/csio_scsi.c:1386:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         csio_lnodes_exit(hw, 1);
         ^
../drivers/scsi/csiostor/csio_scsi.c:1382:2: note: previous statement is
here
        if (*buf != '1')
        ^

1 warning generated.

This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.

Fixes a3667aaed569 ("[SCSI] csiostor: Chelsio FCoE offload driver")
---
 drivers/scsi/csiostor/csio_scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/csiostor/csio_scsi.c +1 -1
index 469d0bc9f5fe..00cf33573136 100644
@@ -1383,7 +1383,7 @@ csio_device_reset(struct device *dev,
 		return -EINVAL;
 
 	/* Delete NPIV lnodes */
-	 csio_lnodes_exit(hw, 1);
+	csio_lnodes_exit(hw, 1);
 
 	/* Block upper IOs */
 	csio_lnodes_block_request(hw);
Signature · 1 line
2.24.1
#1 lore raw

Nathan,

Quoted 8 lines

Clang warns:

../drivers/scsi/csiostor/csio_scsi.c:1386:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         csio_lnodes_exit(hw, 1);
         ^

../drivers/scsi/csiostor/csio_scsi.c:1382:2: note: previous statement is

Applied to 5.6/scsi-queue, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering