Skip to contentSkip to conversation

scsi: qla4xxx: Adjust indentation in qla4xxx_mem_free

PATCH Applied Nathan Chancellor 4 participants 4 messages Dec 18, 2019 – Dec 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla4xxx: Adjust indentation in qla4xxx_mem_free

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^

1 warning generated.

This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.

Fixes 068237c87c64 ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
---
 drivers/scsi/qla4xxx/ql4_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla4xxx/ql4_os.c +1 -1
index 2323432a0edb..5504ab11decc 100644
@@ -4145,7 +4145,7 @@ static void qla4xxx_mem_free(struct scsi_qla_host *ha)
 		dma_free_coherent(&ha->pdev->dev, ha->queues_len, ha->queues,
 				  ha->queues_dma);
 
-	 if (ha->fw_dump)
+	if (ha->fw_dump)
 		vfree(ha->fw_dump);
 
 	ha->queues_len = 0;
Signature · 1 line
2.24.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 54 lines

-----Original Message-----
From: [email protected] <linux-scsi- [email protected]> On Behalf Of Nathan Chancellor
Sent: Wednesday, December 18, 2019 7:23 AM
To: [email protected]; James E.J. Bottomley <[email protected]>; Martin K. Petersen <[email protected]>
Cc: [email protected]; [email protected]; clang-built- [email protected]; Nathan Chancellor <[email protected]>
Subject: [PATCH] scsi: qla4xxx: Adjust indentation in qla4xxx_mem_free

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is here
        if (ha->queues)
        ^

1 warning generated.

This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.

Fixes 068237c87c64 ("[SCSI] qla4xxx: Capture minidump for ISP82XX on

firmware failure")

3A__github.com_ClangBuiltLinux_linux_issues_819&d=DwIDAg&c=nKjWec 2b6R0mOyPaz7xtfQ&r=At6ko6G2bmE5NMB- 6KMSliwRneAzZrOmmK21YHGCrqw&m=uRvAonUUcyFaz2S6vZ8po- QrrPYNB3gw84QZKl9wS78&s=t3EPVR3mOgGj_emNe0i_rdomyiK4K9noSBB WMFBt2Ag&e=

---
 drivers/scsi/qla4xxx/ql4_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla4xxx/ql4_os.c +1 -1
index 2323432a0edb..5504ab11decc 100644
@@ -4145,7 +4145,7 @@ static void qla4xxx_mem_free(struct
 scsi_qla_host *ha)
 		dma_free_coherent(&ha->pdev->dev, ha->queues_len, ha-
 >queues,
 				  ha->queues_dma);
 
-	 if (ha->fw_dump)
+	if (ha->fw_dump)
 		vfree(ha->fw_dump);
Quoted 2 lines

ha->queues_len = 0;
--

Thanks

Reviewed-by on v1 1/1
#2 lore raw
In reply to Nathan Chancellor
Quoted 14 lines · Nathan Chancellor

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^

1 warning generated.

Quoted 7 lines

This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.

Fixes 068237c87c64 ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")

Thanks for the patch!

Quoted 18 lines
---
 drivers/scsi/qla4xxx/ql4_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla4xxx/ql4_os.c +1 -2
index 2323432a0edb..5504ab11decc 100644
@@ -4145,7 +4145,7 @@ static void qla4xxx_mem_free(struct scsi_qla_host *ha)
                dma_free_coherent(&ha->pdev->dev, ha->queues_len, ha->queues,
                                  ha->queues_dma);
 
-        if (ha->fw_dump)
+       if (ha->fw_dump)
                vfree(ha->fw_dump);
 
        ha->queues_len = 0;
--
Signature · 2 lines
Thanks,
~Nick Desaulniers
#3 lore raw
In reply to Nathan Chancellor

Nathan,

Quoted 8 lines

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         if (ha->fw_dump)
         ^

../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is

Applied to 5.6/scsi-queue, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering