Skip to contentSkip to conversation

openl2tp: update systemd service file

PATCH Superseded [email protected] 2 participants 3 messages Dec 19, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openl2tp: update systemd service file

From: Kai Kang <[email protected]>

It shows an warning of openl2tp in systemd log:

| /lib/systemd/system/openl2tpd.service:8: PIDFile= references a path
| below legacy directory /var/run/, updating /var/run/openl2tpd.pid →
| /run/openl2tpd.pid; please update the unit file accordingly.

Update the systemd service file to fix the warning.

Update SRC_URI as well that the homepage openl2tp.org has been closed. Use archived file on sourceforge instead.

---
 .../recipes-protocols/openl2tp/openl2tp/openl2tpd.service       | 2 +-
 meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service +1 -1
index 7b3faf672..d02d0ff7e 100644
@@ -5,7 +5,7 @@ Requires=rpcbind.service
 
 [Service]
 Type=forking
-PIDFile=@STATEDIR@/run/openl2tpd.pid
+PIDFile=/run/openl2tpd.pid
 EnvironmentFile=@SYSCONFDIR@/default/openl2tpd
 ExecStartPre=@BASE_BINDIR@/sh -c "@BASE_SBINDIR@/modprobe -sq l2tp_ppp || @BASE_SBINDIR@/modprobe -sq pppol2tp"
 ExecStart=@SBINDIR@/openl2tpd $OPENL2TPDARGS
meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb +1 -1
index 90e8b111d..38d0554e1 100644
@@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=e9d9259cbbf00945adc25a470c1d3585 \
 
 DEPENDS = "popt flex readline rpcsvc-proto-native bison-native"
 
-SRC_URI = "ftp://ftp.openl2tp.org/releases/${BP}/${BP}.tar.gz \
+SRC_URI = "https://sourceforge.net/projects/openl2tp/files/openl2tp/${PV}/${BP}.tar.gz \
            file://Makefile-modify-CFLAGS-to-aviod-build-error.patch \
            file://openl2tp-simplify-gcc-warning-hack.patch \
            file://Makefile-obey-LDFLAGS.patch \
Signature · 1 line
2.17.1
#1 lore raw
Quoted 38 lines · On Wed, Dec 18, 2019 at 7:16 PM <[email protected]> wrote:

From: Kai Kang <[email protected]>

It shows an warning of openl2tp in systemd log:

| /lib/systemd/system/openl2tpd.service:8: PIDFile= references a path
| below legacy directory /var/run/, updating /var/run/openl2tpd.pid →
| /run/openl2tpd.pid; please update the unit file accordingly.

Update the systemd service file to fix the warning.

Update SRC_URI as well that the homepage openl2tp.org has been closed. Use archived file on sourceforge instead.

---
 .../recipes-protocols/openl2tp/openl2tp/openl2tpd.service       | 2 +-
 meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service +1 -1
index 7b3faf672..d02d0ff7e 100644
@@ -5,7 +5,7 @@ Requires=rpcbind.service
 
 [Service]
 Type=forking
-PIDFile=@STATEDIR@/run/openl2tpd.pid
+PIDFile=/run/openl2tpd.pid
 EnvironmentFile=@SYSCONFDIR@/default/openl2tpd
 ExecStartPre=@BASE_BINDIR@/sh -c "@BASE_SBINDIR@/modprobe -sq l2tp_ppp || @BASE_SBINDIR@/modprobe -sq pppol2tp"
 ExecStart=@SBINDIR@/openl2tpd $OPENL2TPDARGS
meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb +0 -0
index 90e8b111d..38d0554e1 100644

meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb LIC_FILES_CHKSUM = "file://COPYING;md5=e9d9259cbbf00945adc25a470c1d3585 \ · line 21

Quoted 5 lines
meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb +1 -1
@@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=e9d9259cbbf00945adc25a470c1d3585 \
 
 DEPENDS = "popt flex readline rpcsvc-proto-native bison-native"
 
-SRC_URI = "ftp://ftp.openl2tp.org/releases/${BP}/${BP}.tar.gz \
+SRC_URI = "https://sourceforge.net/projects/openl2tp/files/openl2tp/${PV}/${BP}.tar.gz \

Can we use SOURCEFORGE_MIRROR

Quoted 11 lines
meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb +0 -1
            file://Makefile-modify-CFLAGS-to-aviod-build-error.patch \
            file://openl2tp-simplify-gcc-warning-hack.patch \
            file://Makefile-obey-LDFLAGS.patch \
--

2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#2 lore raw
Quoted 39 lines · Khem Raj
Quoted 38 lines · On Wed, Dec 18, 2019 at 7:16 PM <[email protected]> wrote:

From: Kai Kang <[email protected]>

It shows an warning of openl2tp in systemd log:

| /lib/systemd/system/openl2tpd.service:8: PIDFile= references a path
| below legacy directory /var/run/, updating /var/run/openl2tpd.pid →
| /run/openl2tpd.pid; please update the unit file accordingly.

Update the systemd service file to fix the warning.

Update SRC_URI as well that the homepage openl2tp.org has been closed. Use archived file on sourceforge instead.

---
  .../recipes-protocols/openl2tp/openl2tp/openl2tpd.service       | 2 +-
  meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb      | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service +1 -1
index 7b3faf672..d02d0ff7e 100644
@@ -5,7 +5,7 @@ Requires=rpcbind.service
 
  [Service]
  Type=forking
-PIDFile=@STATEDIR@/run/openl2tpd.pid
+PIDFile=/run/openl2tpd.pid
  EnvironmentFile=@SYSCONFDIR@/default/openl2tpd
  ExecStartPre=@BASE_BINDIR@/sh -c "@BASE_SBINDIR@/modprobe -sq l2tp_ppp || @BASE_SBINDIR@/modprobe -sq pppol2tp"
  ExecStart=@SBINDIR@/openl2tpd $OPENL2TPDARGS
meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb +0 -0
index 90e8b111d..38d0554e1 100644
@@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=e9d9259cbbf00945adc25a470c1d3585 \
 
Quoted 5 lines

meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb LIC_FILES_CHKSUM = "file://COPYING;md5=e9d9259cbbf00945adc25a470c1d3585 \ · line 21

Quoted 4 lines
meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb +1 -1
  DEPENDS = "popt flex readline rpcsvc-proto-native bison-native"
 
-SRC_URI = "ftp://ftp.openl2tp.org/releases/${BP}/${BP}.tar.gz \
+SRC_URI = "https://sourceforge.net/projects/openl2tp/files/openl2tp/${PV}/${BP}.tar.gz \

Can we use SOURCEFORGE_MIRROR

I'll try it.

Regards,
Kai

Quoted 12 lines
Quoted 12 lines
meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb +0 -1
             file://Makefile-modify-CFLAGS-to-aviod-build-error.patch \
             file://openl2tp-simplify-gcc-warning-hack.patch \
             file://Makefile-obey-LDFLAGS.patch \
--

2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 1 line
Kai Kang