Skip to contentSkip to conversation

x86/save: reserve HVM save record numbers that have been consumed...

PATCH Superseded Paul Durrant 3 participants 7 messages Dec 19, 2019

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 x86/save: reserve HVM save record numbers that have been consumed...

...for patches not (yet) upstream.

This patch is simply adding a comment to reserve save record number space to avoid the risk of clashes between existent downstream changes made by Amazon and future upstream changes which may be incompatible.

---
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: "Roger Pau Monné" <[email protected]>

v2:
- Reduce patch to just a comment

---
 xen/include/public/arch-x86/hvm/save.h | 2 ++
 1 file changed, 2 insertions(+)
xen/include/public/arch-x86/hvm/save.h +2 -0
index b2ad3fcd74..b3d445acf7 100644
@@ -639,6 +639,8 @@ struct hvm_msr {
 
 #define CPU_MSR_CODE  20
 
+/* Range 22 - 40 reserved for Amazon */
+
 /*
  * Largest type-code in use
  */
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw
Quoted 24 lines · Paul Durrant

...for patches not (yet) upstream.

This patch is simply adding a comment to reserve save record number space to avoid the risk of clashes between existent downstream changes made by Amazon and future upstream changes which may be incompatible.

---
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: "Roger Pau Monné" <[email protected]>

v2:
- Reduce patch to just a comment

---
 xen/include/public/arch-x86/hvm/save.h | 2 ++
 1 file changed, 2 insertions(+)
xen/include/public/arch-x86/hvm/save.h +0 -0
index b2ad3fcd74..b3d445acf7 100644

xen/include/public/arch-x86/hvm/save.h struct hvm_msr { · line 642

Quoted 4 lines
xen/include/public/arch-x86/hvm/save.h +1 -0
@@ -639,6 +639,8 @@ struct hvm_msr {
 
 #define CPU_MSR_CODE  20
 
+/* Range 22 - 40 reserved for Amazon */

What about 21 and 22?  And where does the actual number stop, because based on v1, its not 40.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
Quoted 37 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 19 December 2019 12:16
To: Durrant, Paul <[email protected]>; [email protected]
Cc: Wei Liu <[email protected]>; Jan Beulich <[email protected]>; Roger Pau Monné <[email protected]>
Subject: Re: [PATCH v2] x86/save: reserve HVM save record numbers that have been consumed...

Quoted 3 lines · Paul Durrant

...for patches not (yet) upstream.

This patch is simply adding a comment to reserve save record number

space

Quoted 10 lines

to avoid the risk of clashes between existent downstream changes made by Amazon and future upstream changes which may be incompatible.

---
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: "Roger Pau Monné" <[email protected]>

Review

Quoted 7 lines

v2:
- Reduce patch to just a comment

---
 xen/include/public/arch-x86/hvm/save.h | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/xen/include/public/arch-x86/hvm/save.h

Quoted 5 lines

index b2ad3fcd74..b3d445acf7 100644

xen/include/public/arch-x86/hvm/save.h +0 -0
@@ -639,6 +639,8 @@ struct hvm_msr {
 
Quoted 7 lines

xen/include/public/arch-x86/hvm/save.h struct hvm_msr { · line 642

Quoted 3 lines
xen/include/public/arch-x86/hvm/save.h +1 -0
 #define CPU_MSR_CODE  20
 
+/* Range 22 - 40 reserved for Amazon */

What about 21 and 22?  And where does the actual number stop, because based on v1, its not 40.

The range is inclusive (maybe that's not obvious?). For some reason 21 was skipped but why do you say the top is not 40? That was what I set HVM_SAVE_CODE_MAX to in v1.

Paul
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
Quoted 37 lines · Paul
Quoted 37 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 19 December 2019 12:16
To: Durrant, Paul <[email protected]>; [email protected]
Cc: Wei Liu <[email protected]>; Jan Beulich <[email protected]>; Roger Pau Monné <[email protected]>
Subject: Re: [PATCH v2] x86/save: reserve HVM save record numbers that have been consumed...

Quoted 3 lines · Paul Durrant

...for patches not (yet) upstream.

This patch is simply adding a comment to reserve save record number

space

Quoted 10 lines

to avoid the risk of clashes between existent downstream changes made by Amazon and future upstream changes which may be incompatible.

---
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: "Roger Pau Monné" <[email protected]>

Review

Quoted 7 lines

v2:
- Reduce patch to just a comment

---
 xen/include/public/arch-x86/hvm/save.h | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/xen/include/public/arch-x86/hvm/save.h

Quoted 5 lines

index b2ad3fcd74..b3d445acf7 100644

xen/include/public/arch-x86/hvm/save.h +0 -0
@@ -639,6 +639,8 @@ struct hvm_msr {
 
Quoted 7 lines
Quoted 6 lines

xen/include/public/arch-x86/hvm/save.h struct hvm_msr { · line 642

Quoted 3 lines
xen/include/public/arch-x86/hvm/save.h +1 -0
 #define CPU_MSR_CODE  20
 
+/* Range 22 - 40 reserved for Amazon */

What about 21 and 22?  And where does the actual number stop, because based on v1, its not 40.

The range is inclusive (maybe that's not obvious?). For some reason 21 was skipped but why do you say the top is not 40? That was what I set HVM_SAVE_CODE_MAX to in v1.

You also said that included prospective headroom, which definitely isn't fair to reserve for ABI breakage reasons.

Which numbers have actually been allocated?

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
Quoted 55 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 19 December 2019 13:08
To: Durrant, Paul <[email protected]>; [email protected]
Cc: Wei Liu <[email protected]>; Jan Beulich <[email protected]>; Roger Pau Monné <[email protected]>
Subject: Re: [PATCH v2] x86/save: reserve HVM save record numbers that have been consumed...

Quoted 5 lines · Paul
Quoted 5 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 19 December 2019 12:16
To: Durrant, Paul <[email protected]>; [email protected]
Cc: Wei Liu <[email protected]>; Jan Beulich <[email protected]>; Roger Pau

Monné

Quoted 10 lines
Quoted 10 lines

<[email protected]>
Subject: Re: [PATCH v2] x86/save: reserve HVM save record numbers that have been consumed...

Quoted 3 lines · Paul Durrant

...for patches not (yet) upstream.

This patch is simply adding a comment to reserve save record number

space

Quoted 1 line

to avoid the risk of clashes between existent downstream changes made

by

Quoted 28 lines
Quoted 28 lines
Quoted 9 lines

Amazon and future upstream changes which may be incompatible.

---
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: "Roger Pau Monné" <[email protected]>

Review

Quoted 7 lines

v2:
- Reduce patch to just a comment

---
 xen/include/public/arch-x86/hvm/save.h | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/xen/include/public/arch-x86/hvm/save.h

xen/include/public/arch-x86/hvm/save.h struct hvm_msr { · line 642

Quoted 8 lines

index b2ad3fcd74..b3d445acf7 100644

xen/include/public/arch-x86/hvm/save.h +1 -0
@@ -639,6 +639,8 @@ struct hvm_msr {
 
 #define CPU_MSR_CODE  20
 
+/* Range 22 - 40 reserved for Amazon */

What about 21 and 22?  And where does the actual number stop, because based on v1, its not 40.

Quoted 9 lines
Quoted 1 line

The range is inclusive (maybe that's not obvious?). For some reason 21

was skipped but why do you say the top is not 40? That was what I set HVM_SAVE_CODE_MAX to in v1.

You also said that included prospective headroom, which definitely isn't fair to reserve for ABI breakage reasons.

Which numbers have actually been allocated?

The problem is that I don't yet know for sure. I have definitely seen patches using 22 thru 34. It is *probably* safe to restrict to that but does it really cost that much more to reserve some extra space just in case? I.e. if someone else adds 41 vs. 35 is it going to make much of a difference?

Paul
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw
Quoted 25 lines · Paul
Quoted 25 lines

From: Andrew Cooper <[email protected]>
Sent: 19 December 2019 13:08

Quoted 8 lines · Paul
Quoted 8 lines

From: Andrew Cooper <[email protected]>
Sent: 19 December 2019 12:16

Quoted 4 lines · Paul Durrant
xen/include/public/arch-x86/hvm/save.h +0 -0
@@ -639,6 +639,8 @@ struct hvm_msr {
 
Quoted 7 lines
Quoted 6 lines

xen/include/public/arch-x86/hvm/save.h struct hvm_msr { · line 642

Quoted 3 lines
xen/include/public/arch-x86/hvm/save.h +1 -0
 #define CPU_MSR_CODE  20
 
+/* Range 22 - 40 reserved for Amazon */

What about 21 and 22?  And where does the actual number stop, because based on v1, its not 40.

The range is inclusive (maybe that's not obvious?). For some reason 21

was skipped but why do you say the top is not 40? That was what I set HVM_SAVE_CODE_MAX to in v1.

You also said that included prospective headroom, which definitely isn't fair to reserve for ABI breakage reasons.

Quoted 8 lines
Quoted 2 lines

Which numbers have actually been allocated?

The problem is that I don't yet know for sure. I have definitely seen patches using 22 thru 34. It is *probably* safe to restrict to that but does it really cost that much more to reserve some extra space just in case? I.e. if someone else adds 41 vs. 35 is it going to make much of a difference?

Not _that much_, but still - it's a bodge, so let's try to limit it as much as we can.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw
Quoted 40 lines

-----Original Message-----
From: Jan Beulich <[email protected]>
Sent: 19 December 2019 13:25
To: Durrant, Paul <[email protected]>
Cc: Andrew Cooper <[email protected]>; xen- [email protected]; Wei Liu <[email protected]>; Roger Pau Monné <[email protected]>
Subject: Re: [PATCH v2] x86/save: reserve HVM save record numbers that have been consumed...

Quoted 18 lines · Paul
Quoted 18 lines

From: Andrew Cooper <[email protected]>
Sent: 19 December 2019 13:08

Quoted 14 lines · Paul
Quoted 14 lines

From: Andrew Cooper <[email protected]>
Sent: 19 December 2019 12:16

xen/include/public/arch-x86/hvm/save.h struct hvm_msr { · line 642

Quoted 7 lines · Paul Durrant
xen/include/public/arch-x86/hvm/save.h +1 -0
@@ -639,6 +639,8 @@ struct hvm_msr {
 
 #define CPU_MSR_CODE  20
 
+/* Range 22 - 40 reserved for Amazon */

What about 21 and 22?  And where does the actual number stop, because based on v1, its not 40.

Quoted 5 lines
Quoted 5 lines
Quoted 1 line

The range is inclusive (maybe that's not obvious?). For some reason 21

was skipped but why do you say the top is not 40? That was what I set HVM_SAVE_CODE_MAX to in v1.

You also said that included prospective headroom, which definitely

isn't

Quoted 5 lines
Quoted 4 lines

fair to reserve for ABI breakage reasons.

Which numbers have actually been allocated?

Quoted 9 lines
Quoted 5 lines

The problem is that I don't yet know for sure. I have definitely seen patches using 22 thru 34. It is *probably* safe to restrict to that but does it really cost that much more to reserve some extra space just in case? I.e. if someone else adds 41 vs. 35 is it going to make much of a difference?

Not _that much_, but still - it's a bodge, so let's try to limit it as much as we can.

OK, I'll send a v3 using 34 as the limit.

Paul

Quoted 1 line

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel