Skip to contentSkip to conversation

ts-xen-install: Drop gdb= parameter

PATCH In review Ian Jackson 2 participants 2 messages Dec 19, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ts-xen-install: Drop gdb= parameter

This has been there forever and I doubt anyone has ever used it.

Andrew Cooper tells me that it needs an L or H suffix so probably doesn't work. Recent changes to more conspicuously report command line parsing failures highlighted this issue.

---
 ts-xen-install | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ts-xen-install +1 -1
index 154f78c7..d8e9d7e6 100755
@@ -197,7 +197,7 @@ sub setupboot () {
 				: 'com1');
 
     if ( $cons eq "com1" ) {
-	$xenhopt .= " com1=$c{Baud},8n1 console=com1,vga gdb=com1";
+	$xenhopt .= " com1=$c{Baud},8n1 console=com1,vga";
     } elsif ( $cons eq "dtuart" ) {
 	$xenhopt .= " console=dtuart";
 	my $dtuart= get_host_property($ho, 'XenDTUARTPath', undef);
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Ian Jackson

This has been there forever and I doubt anyone has ever used it.

Andrew Cooper tells me that it needs an L or H suffix so probably doesn't work. Recent changes to more conspicuously report command line parsing failures highlighted this issue.

http://xenbits.xen.org/docs/unstable/misc/xen-command-line.html#gdb

It needs an L or H suffix to instruct Xen how to mux the console with the gdb remote protocol based on the high bit on 8-bit clean line.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel