Engicam icore fixes
Subsystems (2)
cover Engicam icore fixes
Fix ethernet in imx6dl-icore-1.5 mipi developent kit. Adjust ethernet reset in icore boards
Michael Trimarchi (3):
ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit
ARM: dts: imx6dl: Remove duplication in Engicam i.CoreM6 1.5 Quad/Dual
MIPI
arm: dts: imx6qdl: Move the phy reset at device level
arch/arm/boot/dts/imx6dl-icore-mipi.dts | 2 +- arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi | 2 -- arch/arm/boot/dts/imx6qdl-icore.dtsi | 15 ++++++++++++++- 3 files changed, 15 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/3 ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit
Fix the file to be included in dual mipi starter kit. This fix ethernet probing
--- arch/arm/boot/dts/imx6dl-icore-mipi.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6dl-icore-mipi.dts +1 -1
@@ -8,7 +8,7 @@ /dts-v1/; #include "imx6dl.dtsi" -#include "imx6qdl-icore.dtsi" +#include "imx6qdl-icore-1.5.dtsi" / { model = "Engicam i.CoreM6 DualLite/Solo MIPI Starter Kit";
Signature · 1 line
2.17.1
PATCH 2/3 ARM: dts: imx6dl: Remove duplication in Engicam i.CoreM6 1.5 Quad/Dual MIPI
In reply to Michael TrimarchiAvoid to re-define the reset gpio for ethernet multiple time. The imx6qdl-icore-1.5.dtsi include imx6qdl-icore.dtsi that already define the reset method
--- arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi +0 -2
@@ -25,10 +25,8 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>; clocks = <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET_REF>; - phy-mode = "rmii"; status = "okay"; };
Signature · 1 line
2.17.1
PATCH 3/3 arm: dts: imx6qdl: Move the phy reset at device level
In reply to Michael TrimarchiLAN8720 needs a reset of every clock enable. The reset needs to be done at device level, due the flag PHY_RST_AFTER_CLK_EN
--- arch/arm/boot/dts/imx6qdl-icore.dtsi | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-icore.dtsi +14 -1
@@ -150,10 +150,23 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>; clocks = <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET>, <&rmii_clk>; phy-mode = "rmii"; + phy-handle = <ð_phy>; status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + eth_phy: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>; + reset-assert-us = <4000>; + reset-deassert-us = <4000>; + }; + }; }; &gpmi {
Signature · 1 line
2.17.1
Fabio Estevam
reviewerRe: [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit
In reply to Michael TrimarchiHi Michael,
Quoted 14 lines · Michael Trimarchi
Fix the file to be included in dual mipi starter kit. This fix ethernet probing
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/boot/dts/imx6dl-icore-mipi.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/imx6dl-icore-mipi.dts +0
-0
arch/arm/boot/dts/imx6dl-icore-mipi.dts line 11
Quoted 5 lines
arch/arm/boot/dts/imx6dl-icore-mipi.dts +1
-1@@ -8,7 +8,7 @@ /dts-v1/; #include "imx6dl.dtsi" -#include "imx6qdl-icore.dtsi" +#include "imx6qdl-icore-1.5.dtsi"
Jagan submitted the same fix today:
http://lists.infradead.org/pipermail/linux-arm-kernel/2019-December/701895.html
Re: [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit
Hi
Quoted 21 lines · Fabio Estevam
Hi Michael,
Quoted 16 lines · Michael Trimarchi
Fix the file to be included in dual mipi starter kit. This fix ethernet probing
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/boot/dts/imx6dl-icore-mipi.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/imx6dl-icore-mipi.dts +0
-0@@ -8,7 +8,7 @@ /dts-v1/;
Quoted 6 lines
arch/arm/boot/dts/imx6dl-icore-mipi.dts line 11
Quoted 3 lines
arch/arm/boot/dts/imx6dl-icore-mipi.dts +1
-1#include "imx6dl.dtsi" -#include "imx6qdl-icore.dtsi" +#include "imx6qdl-icore-1.5.dtsi"Jagan submitted the same fix today:
http://lists.infradead.org/pipermail/linux-arm-kernel/2019-December/701895.html
Sorry, was not in copy. He said to me but I was not aware about one of my queue
Michael