Skip to contentSkip to conversation

dma-buf: free dmabuf->name in dma_buf_release()

PATCH In review Cong Wang 2 participants 3 messages Dec 27, 2019 – Feb 19, 2020

Subsystems (2)
lore
Share & tools
lore

Cong Wang

author
#0 lore raw

PATCH 1/1 dma-buf: free dmabuf->name in dma_buf_release()

dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set it never gets freed.

Free it in dma_buf_release().

Fixes bb2bb9030425 ("dma-buf: add DMA_BUF_SET_NAME ioctls")
Reported-by [email protected]
Cc Greg Hackmann <[email protected]>
Cc Chenbo Feng <[email protected]>
Cc Sumit Semwal <[email protected]>
---
 drivers/dma-buf/dma-buf.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma-buf/dma-buf.c +1 -0
index ce41cd9b758a..2427398ff22a 100644
@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)
 		dma_resv_fini(dmabuf->resv);
 
 	module_put(dmabuf->owner);
+	kfree(dmabuf->name);
 	kfree(dmabuf);
 	return 0;
 }
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 31 lines · Cong Wang

dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set it never gets freed.

Free it in dma_buf_release().

Fixes bb2bb9030425 ("dma-buf: add DMA_BUF_SET_NAME ioctls")
Reported-by [email protected]
Cc Greg Hackmann <[email protected]>
Cc Chenbo Feng <[email protected]>
Cc Sumit Semwal <[email protected]>
---
 drivers/dma-buf/dma-buf.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma-buf/dma-buf.c +1 -1
index ce41cd9b758a..2427398ff22a 100644
@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)
                dma_resv_fini(dmabuf->resv);
 
        module_put(dmabuf->owner);
+       kfree(dmabuf->name);
        kfree(dmabuf);
        return 0;
 }
--

2.21.0

Acked-by on v1 1/1
#2 lore raw
In reply to Cong Wang
Quoted 27 lines · Cong Wang

dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set it never gets freed.

Free it in dma_buf_release().

Fixes bb2bb9030425 ("dma-buf: add DMA_BUF_SET_NAME ioctls")
Reported-by [email protected]
Cc Greg Hackmann <[email protected]>
Cc Chenbo Feng <[email protected]>
Cc Sumit Semwal <[email protected]>
---
 drivers/dma-buf/dma-buf.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma-buf/dma-buf.c +1 -0
index ce41cd9b758a..2427398ff22a 100644
@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct
 file *file)
                dma_resv_fini(dmabuf->resv);
 
        module_put(dmabuf->owner);
+       kfree(dmabuf->name);
        kfree(dmabuf);
        return 0;
Quoted 5 lines

}
--
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel