Skip to contentSkip to conversation

i3c: dw: convert to devm_platform_ioremap_resource

PATCH In review Yangtao Li 2 participants 3 messages Dec 28, 2019 – Dec 30, 2019

Subsystems (3)
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/2 i3c: dw: convert to devm_platform_ioremap_resource

Use devm_platform_ioremap_resource() to simplify code.

---
 drivers/i3c/master/dw-i3c-master.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/i3c/master/dw-i3c-master.c +1 -3
index b0ff0e12d84c..7b941e93337f 100644
@@ -1100,15 +1100,13 @@ static const struct i3c_master_controller_ops dw_mipi_i3c_ops = {
 static int dw_i3c_probe(struct platform_device *pdev)
 {
 	struct dw_i3c_master *master;
-	struct resource *res;
 	int ret, irq;
 
 	master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL);
 	if (!master)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	master->regs = devm_ioremap_resource(&pdev->dev, res);
+	master->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(master->regs))
 		return PTR_ERR(master->regs);
 
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 2/2 i3c: master: cdns: convert to devm_platform_ioremap_resource

Use devm_platform_ioremap_resource() to simplify code.

---
 drivers/i3c/master/i3c-master-cdns.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/i3c/master/i3c-master-cdns.c +1 -3
index 10db0bf0655a..2fb7ed34f995 100644
@@ -1524,7 +1524,6 @@ static void cdns_i3c_master_hj(struct work_struct *work)
 static int cdns_i3c_master_probe(struct platform_device *pdev)
 {
 	struct cdns_i3c_master *master;
-	struct resource *res;
 	int ret, irq;
 	u32 val;
 
@@ -1532,8 +1531,7 @@ static int cdns_i3c_master_probe(struct platform_device *pdev)
 	if (!master)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	master->regs = devm_ioremap_resource(&pdev->dev, res);
+	master->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(master->regs))
 		return PTR_ERR(master->regs);
 
Signature · 1 line
2.17.1
Acked-by on v1 1/2
#2 lore raw
In reply to Yangtao Li

Hi Yangtao,

Thanks for your patch.

From: Yangtao Li <[email protected]>
Date: Sat, Dec 28, 2019 at 18:54:05

Quoted 30 lines

Use devm_platform_ioremap_resource() to simplify code.

---
 drivers/i3c/master/dw-i3c-master.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/i3c/master/dw-i3c-master.c +1 -3
index b0ff0e12d84c..7b941e93337f 100644
@@ -1100,15 +1100,13 @@ static const struct i3c_master_controller_ops dw_mipi_i3c_ops = {
 static int dw_i3c_probe(struct platform_device *pdev)
 {
 	struct dw_i3c_master *master;
-	struct resource *res;
 	int ret, irq;
 
 	master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL);
 	if (!master)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	master->regs = devm_ioremap_resource(&pdev->dev, res);
+	master->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(master->regs))
 		return PTR_ERR(master->regs);
 
Signature · 1 line
2.17.1

Best regards,
Vitor
Soares