drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ
Subsystems (2)
PATCH 1/1 drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ
[Why]
According to DP spec, it should shift left 4 digits for NO_STOP_BIT in REMOTE_I2C_READ message. Not 5 digits.
[How]
Correct the shifting value of NO_STOP_BIT for DP_REMOTE_I2C_READ case in drm_dp_encode_sideband_req().
--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_dp_mst_topology.c +1 -1
@@ -393,7 +393,7 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_read.transactions[i].bytes, req->u.i2c_read.transactions[i].num_bytes); idx += req->u.i2c_read.transactions[i].num_bytes; - buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<5 ; + buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<4 ; buf[idx] |= (req->u.i2c_read.transactions[i].i2c_transaction_delay &0xf ); idx++; }
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Wayne Lin
[Why]
According to DP spec, it should shift left 4 digits forNO_STOP_BITinREMOTE_I2C_READmessage. Not 5 digits.[How]
Correct the shifting value ofNO_STOP_BITforDP_REMOTE_I2C_READcase indrm_dp_encode_sideband_req().
Which commit introduced the issue? Fixes: tag. Does it need a stable backport? Does this fix a user visible bug?
BR,
Jani.
Quoted 18 lines
Signed-off-by Wayne Lin <[email protected]>--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_dp_mst_topology.c +1
-1@@ -393,7 +393,7 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_read.transactions[i].bytes, req->u.i2c_read.transactions[i].num_bytes); idx += req->u.i2c_read.transactions[i].num_bytes; - buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<5 ; + buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<4 ; buf[idx] |= (req->u.i2c_read.transactions[i].i2c_transaction_delay &0xf ); idx++; }
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 9 lines · Wayne Lin
[Why]
According to DP spec, it should shift left 4 digits forNO_STOP_BITinREMOTE_I2C_READmessage. Not 5 digits.[How]
Correct the shifting value ofNO_STOP_BITforDP_REMOTE_I2C_READcase indrm_dp_encode_sideband_req().Signed-off-by Wayne Lin <[email protected]>
Good catch. Looks like this has been there since the beginning of MST in the kernel. How did you find this? Did this cause bad EDID reads or some other problem? If so the commit message should probably mention it.
Harry
Quoted 10 lines
--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_dp_mst_topology.c +0
-0
drivers/gpu/drm/drm_dp_mst_topology.c drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req, · line 399
Quoted 8 lines
drivers/gpu/drm/drm_dp_mst_topology.c +1
-1@@ -393,7 +393,7 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_read.transactions[i].bytes, req->u.i2c_read.transactions[i].num_bytes); idx += req->u.i2c_read.transactions[i].num_bytes; - buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<5 ; + buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<4 ; buf[idx] |= (req->u.i2c_read.transactions[i].i2c_transaction_delay &0xf ); idx++; }
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Official Use Only - Internal Distribution Only]
Quoted 16 lines
________________________________________
From: Jani Nikula <[email protected]>
Sent: Monday, December 30, 2019 19:15
To: Lin, Wayne; [email protected]; [email protected]
Cc: Zuo, Jerry; Kazlauskas, Nicholas; Lin, Wayne
Subject: Re: [PATCH] drm/dp_mst: correct the shifting inDP_REMOTE_I2C_READQuoted 7 lines · Wayne Lin
[Why]
According to DP spec, it should shift left 4 digits forNO_STOP_BITinREMOTE_I2C_READmessage. Not 5 digits.[How]
Correct the shifting value ofNO_STOP_BITforDP_REMOTE_I2C_READcase indrm_dp_encode_sideband_req().
Quoted 6 lines
Which commit introduced the issue? Fixes: tag. Does it need a stable backport? Does this fix a user visible bug?
BR,
Jani.
Thanks for your time and reminder.
It seems like the issue has been there since very beginning.(commit: ad7f8a1). It doesn't introduce user visible bug under my test cases, but this affects the I2C signal between I2C master and I2C slave. Not pretty sure if there is any eeprom will reset the written offset once received I2C stop. If so, that might cause wrongly reading EDID. I will Cc to stable. Thanks.
Quoted 13 lines
Quoted 13 lines
Signed-off-by Wayne Lin <[email protected]>--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_dp_mst_topology.c +0
-0@@ -393,7 +393,7 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_read.transactions[i].bytes, req->u.i2c_read.transactions[i].num_bytes); idx += req->u.i2c_read.transactions[i].num_bytes;
Quoted 8 lines
drivers/gpu/drm/drm_dp_mst_topology.c drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req, · line 399
Quoted 5 lines
drivers/gpu/drm/drm_dp_mst_topology.c +1
-1- buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<5 ; + buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<4 ; buf[idx] |= (req->u.i2c_read.transactions[i].i2c_transaction_delay &0xf ); idx++; }--
Jani Nikula, Intel Open Source Graphics Center
--
Wayne Lin
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Official Use Only - Internal Distribution Only]
Quoted 16 lines
________________________________________
From: Wentland, Harry <[email protected]>
Sent: Monday, December 30, 2019 23:26
To: Lin, Wayne; [email protected]; [email protected]
Cc: [email protected]; Zuo, Jerry; Kazlauskas, Nicholas; Wentland, Harry
Subject: Re: [PATCH] drm/dp_mst: correct the shifting inDP_REMOTE_I2C_READQuoted 8 lines · Wayne Lin
[Why]
According to DP spec, it should shift left 4 digits forNO_STOP_BITinREMOTE_I2C_READmessage. Not 5 digits.[How]
Correct the shifting value ofNO_STOP_BITforDP_REMOTE_I2C_READcase indrm_dp_encode_sideband_req().
Quoted 7 lines
Quoted 1 line
Signed-off-by Wayne Lin <[email protected]>Good catch. Looks like this has been there since the beginning of MST in the kernel. How did you find this? Did this cause bad EDID reads or some other problem? If so the commit message should probably mention it.
Harry
Thanks for your time.
I found this while I was trying to debug MST issues by using AUX monitor. So far, I don't observe problems that relate to this under my test cases and environment. However, this bit might affect the I2C signal generated by I2C master, I will mention more in the commit message.
Thanks.
Quoted 13 lines
Quoted 13 lines
--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_dp_mst_topology.c +0
-0@@ -393,7 +393,7 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_read.transactions[i].bytes, req->u.i2c_read.transactions[i].num_bytes); idx += req->u.i2c_read.transactions[i].num_bytes;
Quoted 6 lines
drivers/gpu/drm/drm_dp_mst_topology.c drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req, · line 399
Quoted 6 lines
drivers/gpu/drm/drm_dp_mst_topology.c +1
-1- buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<5 ; + buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<4 ; buf[idx] |= (req->u.i2c_read.transactions[i].i2c_transaction_delay &0xf ); idx++; }
--
Wayne Lin
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Harry Wentland
Reviewed-byQuoted 2 lines · Wayne
[AMD Official Use Only - Internal Distribution Only]
Make sure to select the correct AIP designation for public emails. See my email on that from yesterday. :)
Quoted 22 lines
Quoted 22 lines
________________________________________
From: Wentland, Harry <[email protected]>
Sent: Monday, December 30, 2019 23:26
To: Lin, Wayne; [email protected]; [email protected]
Cc: [email protected]; Zuo, Jerry; Kazlauskas, Nicholas; Wentland, Harry
Subject: Re: [PATCH] drm/dp_mst: correct the shifting inDP_REMOTE_I2C_READQuoted 9 lines · Wayne Lin
[Why]
According to DP spec, it should shift left 4 digits forNO_STOP_BITinREMOTE_I2C_READmessage. Not 5 digits.[How]
Correct the shifting value ofNO_STOP_BITforDP_REMOTE_I2C_READcase indrm_dp_encode_sideband_req().Signed-off-by Wayne Lin <[email protected]>Good catch. Looks like this has been there since the beginning of MST in the kernel. How did you find this? Did this cause bad EDID reads or some other problem? If so the commit message should probably mention it.
Quoted 8 lines
Quoted 1 line
Harry
Thanks for your time.
I found this while I was trying to debug MST issues by using AUX monitor. So far, I don't observe problems that relate to this under my test cases and environment. However, this bit might affect the I2C signal generated by I2C master, I will mention more in the commit message.
Thanks. Was just curious if you saw any real issues. Good find nevertheless and good patch.
You can add my
Harry
Quoted 14 lines
Thanks.
Quoted 13 lines
Quoted 13 lines
--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_dp_mst_topology.c +0
-0@@ -393,7 +393,7 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_read.transactions[i].bytes, req->u.i2c_read.transactions[i].num_bytes); idx += req->u.i2c_read.transactions[i].num_bytes;
Quoted 9 lines
Quoted 6 lines
drivers/gpu/drm/drm_dp_mst_topology.c drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req, · line 399
Quoted 6 lines
drivers/gpu/drm/drm_dp_mst_topology.c +1
-1- buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<5 ; + buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<4 ; buf[idx] |= (req->u.i2c_read.transactions[i].i2c_transaction_delay &0xf ); idx++; }--
Wayne Lin
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 24 lines · Wayne
[AMD Official Use Only - Internal Distribution Only]
Quoted 16 lines
________________________________________
From: Jani Nikula <[email protected]>
Sent: Monday, December 30, 2019 19:15
To: Lin, Wayne; [email protected]; [email protected]
Cc: Zuo, Jerry; Kazlauskas, Nicholas; Lin, Wayne
Subject: Re: [PATCH] drm/dp_mst: correct the shifting inDP_REMOTE_I2C_READQuoted 7 lines · Wayne Lin
[Why]
According to DP spec, it should shift left 4 digits forNO_STOP_BITinREMOTE_I2C_READmessage. Not 5 digits.[How]
Correct the shifting value ofNO_STOP_BITforDP_REMOTE_I2C_READcase indrm_dp_encode_sideband_req().Quoted 6 lines
Which commit introduced the issue? Fixes: tag. Does it need a stable backport? Does this fix a user visible bug?
BR,
Jani.
Quoted 7 lines
Thanks for your time and reminder.
It seems like the issue has been there since very beginning.(commit: ad7f8a1). It doesn't introduce user visible bug under my test cases, but this affects the I2C signal between I2C master and I2C slave. Not pretty sure if there is any eeprom will reset the written offset once received I2C stop. If so, that might cause wrongly reading EDID. I will Cc to stable. Thanks.
The segment address should be reset on STOP. So large EDIDs should fail. IIRC we had a bug report of some sort about this which I tried to fix by confgiuring .no_stop_bit correctly, but apparently I failed to double check that the bit get stuffed onto the wire correctly.
Ah yes, https://bugs.freedesktop.org/show_bug.cgi?id=108081
So you may have just fixed that one, although we seem to have closed it already.
Quoted 27 lines
Quoted 13 lines
Quoted 13 lines
Signed-off-by Wayne Lin <[email protected]>--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_dp_mst_topology.c +0
-0@@ -393,7 +393,7 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_read.transactions[i].bytes, req->u.i2c_read.transactions[i].num_bytes); idx += req->u.i2c_read.transactions[i].num_bytes;Quoted 8 lines
drivers/gpu/drm/drm_dp_mst_topology.c drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req, · line 399
Quoted 5 lines
drivers/gpu/drm/drm_dp_mst_topology.c +1
-1- buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<5 ; + buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<4 ; buf[idx] |= (req->u.i2c_read.transactions[i].i2c_transaction_delay &0xf ); idx++; }--
Jani Nikula, Intel Open Source Graphics Center--
Wayne Lin
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Public Use]
Quoted 53 lines
-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, January 8, 2020 2:57 AM
To: Lin, Wayne <[email protected]>
Cc: Jani Nikula <[email protected]>; dri- [email protected]; [email protected]; Zuo, Jerry <[email protected]>; Kazlauskas, Nicholas <[email protected]>
Subject: Re: [PATCH] drm/dp_mst: correct the shifting inDP_REMOTE_I2C_READQuoted 23 lines · Wayne
[AMD Official Use Only - Internal Distribution Only]
Quoted 21 lines
________________________________________
From: Jani Nikula <[email protected]>
Sent: Monday, December 30, 2019 19:15
To: Lin, Wayne; [email protected]; [email protected]
Cc: Zuo, Jerry; Kazlauskas, Nicholas; Lin, Wayne
Subject: Re: [PATCH] drm/dp_mst: correct the shifting inDP_REMOTE_I2C_READQuoted 7 lines · Wayne Lin
[Why]
According to DP spec, it should shift left 4 digits forNO_STOP_BITinREMOTE_I2C_READmessage. Not 5 digits.[How]
Correct the shifting value ofNO_STOP_BITforDP_REMOTE_I2C_READcase indrm_dp_encode_sideband_req().Which commit introduced the issue? Fixes: tag. Does it need a stable backport? Does this fix a user visible bug?
Quoted 6 lines
Quoted 3 lines
BR,
Jani.Thanks for your time and reminder.
It seems like the issue has been there since very beginning.(commit:
ad7f8a1).
Quoted 3 lines
It doesn't introduce user visible bug under my test cases, but this affects the I2C signal between I2C master and I2C slave. Not pretty sure if there is any eeprom will reset the written offset once received I2C
stop. If so, that might cause wrongly reading EDID.
Quoted 1 line
I will Cc to stable. Thanks.
The segment address should be reset on STOP. So large EDIDs should fail. IIRC we had a bug report of some sort about this which I tried to fix by confgiuring .no_stop_bit correctly, but apparently I failed to double check that the bit get stuffed onto the wire correctly.
Quoted 4 lines
Ah yes,
https://bugs.freedesktop.org/show_bug.cgi?id=108081
So you may have just fixed that one, although we seem to have closed it already.
Thanks for your time and the explanation.
Quoted 41 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Signed-off-by Wayne Lin <[email protected]>--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/drm_dp_mst_topology.c drm_dp_encode_sideband_req(const struct
Quoted 6 lines
drivers/gpu/drm/drm_dp_mst_topology.c +0
-0@@ -393,7 +393,7 @@ drm_dp_encode_sideband_req(const struct
drm_dp_sideband_msg_req_body*req,Quoted 1 line
Quoted 1 line
drivers/gpu/drm/drm_dp_mst_topology.c drm_dp_encode_sideband_req(const struct · line 393
Quoted 1 line
drivers/gpu/drm/drm_dp_mst_topology.c +0
-0memcpy(&buf[idx], req->u.i2c_read.transactions[i].bytes,req->u.i2c_read.transactions[i].num_bytes);
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/drm_dp_mst_topology.c drm_dp_encode_sideband_req(const struct · line 397
Quoted 4 lines
drivers/gpu/drm/drm_dp_mst_topology.c +0
-1idx += req->u.i2c_read.transactions[i].num_bytes; - buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit &
0x1) << 5;Quoted 9 lines
Quoted 3 lines
drivers/gpu/drm/drm_dp_mst_topology.c drm_dp_encode_sideband_req(const struct · line 399
Quoted 3 lines
drivers/gpu/drm/drm_dp_mst_topology.c +2
-0+ buf[idx] = + (req->u.i2c_read.transactions[i].no_stop_bit &0x1 ) <<4 ; buf[idx] |= (req-u.i2c_read.transactions[i].i2c_transaction_delay &
0xf);Quoted 5 lines
Quoted 2 lines
idx++; }--
Jani Nikula, Intel Open Source Graphics CenterQuoted 7 lines
--
Wayne Lin
_______________________________________________
dri-devel mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
s.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7C
Quoted 1 line
Wayne.Lin%40amd.com%7C7a299e0e845242312acb08d793a36e63%7C3dd896 1fe4884
Quoted 1 line
Quoted 7 lines
e608e11a82d994e183d%7C0%7C0%7C637140202457938159&sdata=yK4I 7fgenrR
Quoted 1 line
f%2FXrs5jKXv%2BmOZdjV7dl%2BiNUJcsxnXG0%3D&reserved=0
--
Ville Syrjälä
Intel
--
Best regards,
Wayne Lin
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel