drm/nouveau: declare constants as unsigned long.
Subsystems (3)
PATCH 1/1 drm/nouveau: declare constants as unsigned long.
Explicitly declare constants are unsigned long to address the following sparse warnings:
warning: constant is so big it is long
Signed-off-by Wambui Karuga <[email protected]>
--- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf108.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm107.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm200.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgp100.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c +1 -1
@@ -655,7 +655,7 @@ gf100_ram_new_(const struct nvkm_ram_func *func,static const struct nvkm_ram_func gf100_ram = { - .upper =0x0200000000 , + .upper =0x0200000000UL , .probe_fbp = gf100_ram_probe_fbp, .probe_fbp_amount = gf100_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf108.c +1 -1
@@ -43,7 +43,7 @@ gf108_ram_probe_fbp_amount(const struct nvkm_ram_func *func, u32 fbpao,static const struct nvkm_ram_func gf108_ram = { - .upper =0x0200000000 , + .upper =0x0200000000UL , .probe_fbp = gf100_ram_probe_fbp, .probe_fbp_amount = gf108_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c +1 -1
@@ -1698,7 +1698,7 @@ gk104_ram_new_(const struct nvkm_ram_func *func, struct nvkm_fb *fb,static const struct nvkm_ram_func gk104_ram = { - .upper =0x0200000000 , + .upper =0x0200000000UL , .probe_fbp = gf100_ram_probe_fbp, .probe_fbp_amount = gf108_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm107.c +1 -1
@@ -33,7 +33,7 @@ gm107_ram_probe_fbp(const struct nvkm_ram_func *func,static const struct nvkm_ram_func gm107_ram = { - .upper =0x1000000000 , + .upper =0x1000000000UL , .probe_fbp = gm107_ram_probe_fbp, .probe_fbp_amount = gf108_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm200.c +1 -1
@@ -48,7 +48,7 @@ gm200_ram_probe_fbp_amount(const struct nvkm_ram_func *func, u32 fbpao,static const struct nvkm_ram_func gm200_ram = { - .upper =0x1000000000 , + .upper =0x1000000000UL , .probe_fbp = gm107_ram_probe_fbp, .probe_fbp_amount = gm200_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgp100.c +1 -1
@@ -79,7 +79,7 @@ gp100_ram_probe_fbpa(struct nvkm_device *device, int fbpa)static const struct nvkm_ram_func gp100_ram = { - .upper =0x1000000000 , + .upper =0x1000000000UL , .probe_fbp = gm107_ram_probe_fbp, .probe_fbp_amount = gm200_ram_probe_fbp_amount, .probe_fbpa_amount = gp100_ram_probe_fbpa,
Signature · 1 line
2.17.1
Probably want ULL for 32-bit arches to be correct here too.
Quoted 96 lines · Wambui Karuga
Explicitly declare constants are unsigned long to address the following sparse warnings:
warning: constant is so big it is longSigned-off-by Wambui Karuga <[email protected]>--- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf108.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm107.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm200.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgp100.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c +1
-1@@ -655,7 +655,7 @@ gf100_ram_new_(const struct nvkm_ram_func *func,static const struct nvkm_ram_func gf100_ram = { - .upper =0x0200000000 , + .upper =0x0200000000UL , .probe_fbp = gf100_ram_probe_fbp, .probe_fbp_amount = gf100_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf108.c +1
-1@@ -43,7 +43,7 @@ gf108_ram_probe_fbp_amount(const struct nvkm_ram_func *func, u32 fbpao,static const struct nvkm_ram_func gf108_ram = { - .upper =0x0200000000 , + .upper =0x0200000000UL , .probe_fbp = gf100_ram_probe_fbp, .probe_fbp_amount = gf108_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c +1
-1@@ -1698,7 +1698,7 @@ gk104_ram_new_(const struct nvkm_ram_func *func, struct nvkm_fb *fb,static const struct nvkm_ram_func gk104_ram = { - .upper =0x0200000000 , + .upper =0x0200000000UL , .probe_fbp = gf100_ram_probe_fbp, .probe_fbp_amount = gf108_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm107.c +1
-1@@ -33,7 +33,7 @@ gm107_ram_probe_fbp(const struct nvkm_ram_func *func,static const struct nvkm_ram_func gm107_ram = { - .upper =0x1000000000 , + .upper =0x1000000000UL , .probe_fbp = gm107_ram_probe_fbp, .probe_fbp_amount = gf108_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm200.c +1
-1@@ -48,7 +48,7 @@ gm200_ram_probe_fbp_amount(const struct nvkm_ram_func *func, u32 fbpao,static const struct nvkm_ram_func gm200_ram = { - .upper =0x1000000000 , + .upper =0x1000000000UL , .probe_fbp = gm107_ram_probe_fbp, .probe_fbp_amount = gm200_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgp100.c +1
-2@@ -79,7 +79,7 @@ gp100_ram_probe_fbpa(struct nvkm_device *device, int fbpa)static const struct nvkm_ram_func gp100_ram = { - .upper =0x1000000000 , + .upper =0x1000000000UL , .probe_fbp = gm107_ram_probe_fbp, .probe_fbp_amount = gm200_ram_probe_fbp_amount, .probe_fbpa_amount = gp100_ram_probe_fbpa, --2.17.1
Quoted 2 lines · Ilia Mirkin
Probably want ULL for 32-bit arches to be correct here too.
Okay, I can convert them to ULL and send a v2.
Thanks,
wambui.
Quoted 97 lines · Wambui Karuga
Quoted 96 lines
Explicitly declare constants are unsigned long to address the following sparse warnings:
warning: constant is so big it is longSigned-off-by Wambui Karuga <[email protected]>--- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf108.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm107.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm200.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgp100.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c +1
-1@@ -655,7 +655,7 @@ gf100_ram_new_(const struct nvkm_ram_func *func,static const struct nvkm_ram_func gf100_ram = { - .upper =0x0200000000 , + .upper =0x0200000000UL , .probe_fbp = gf100_ram_probe_fbp, .probe_fbp_amount = gf100_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf108.c +1
-1@@ -43,7 +43,7 @@ gf108_ram_probe_fbp_amount(const struct nvkm_ram_func *func, u32 fbpao,static const struct nvkm_ram_func gf108_ram = { - .upper =0x0200000000 , + .upper =0x0200000000UL , .probe_fbp = gf100_ram_probe_fbp, .probe_fbp_amount = gf108_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c +1
-1@@ -1698,7 +1698,7 @@ gk104_ram_new_(const struct nvkm_ram_func *func, struct nvkm_fb *fb,static const struct nvkm_ram_func gk104_ram = { - .upper =0x0200000000 , + .upper =0x0200000000UL , .probe_fbp = gf100_ram_probe_fbp, .probe_fbp_amount = gf108_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm107.c +1
-1@@ -33,7 +33,7 @@ gm107_ram_probe_fbp(const struct nvkm_ram_func *func,static const struct nvkm_ram_func gm107_ram = { - .upper =0x1000000000 , + .upper =0x1000000000UL , .probe_fbp = gm107_ram_probe_fbp, .probe_fbp_amount = gf108_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm200.c +1
-1@@ -48,7 +48,7 @@ gm200_ram_probe_fbp_amount(const struct nvkm_ram_func *func, u32 fbpao,static const struct nvkm_ram_func gm200_ram = { - .upper =0x1000000000 , + .upper =0x1000000000UL , .probe_fbp = gm107_ram_probe_fbp, .probe_fbp_amount = gm200_ram_probe_fbp_amount, .probe_fbpa_amount = gf100_ram_probe_fbpa_amount,drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgp100.c +1
-2@@ -79,7 +79,7 @@ gp100_ram_probe_fbpa(struct nvkm_device *device, int fbpa)static const struct nvkm_ram_func gp100_ram = { - .upper =0x1000000000 , + .upper =0x1000000000UL , .probe_fbp = gm107_ram_probe_fbp, .probe_fbp_amount = gm200_ram_probe_fbp_amount, .probe_fbpa_amount = gp100_ram_probe_fbpa, --2.17.1