gssd: Use setgroups32 syscall, if available. BUG:FIXED:340
Subsystems (2)
PATCH 1/1 gssd: Use setgroups32 syscall, if available. BUG:FIXED:340
This closes a bug on older 32-bit platforms, where the 16-bit setgroups syscall has been replaced by setgroups32 and is not available anymore.
(Personal note: Reporting a trivial bug and getting a fix upstream in nfs-utils is like running the gauntlet, for the uninitiated average user.)
BR
--- utils/gssd/gssd_proc.c | 4 ++++ 1 file changed, 4 insertions(+)
utils/gssd/gssd_proc.c +4 -0
@@ -437,7 +437,11 @@ change_identity(uid_t uid)int res;/* drop list of supplimentary groups first */ +#ifdef __NR_setgroups32 +if (syscall (SYS_setgroups32,0 ,0 ) !=0 ) { +#else if (syscall (SYS_setgroups,0 ,0 ) !=0 ) { +#endif printerr (0 ,"WARNING: unable to drop supplimentary groups!" );return errno; }
Signature · 1 line
2.24.1
Quoted 4 lines · Markus Schaaf
This closes a bug on older 32-bit platforms, where the 16-bit setgroups syscall has been replaced by setgroups32 and is not available anymore.
Signed-off-by Markus Schaaf <[email protected]>
Committed... (tag nfs-utils-2-4-3-rc4)
Quoted 3 lines
(Personal note: Reporting a trivial bug and getting a fix upstream in nfs-utils is like running the gauntlet, for the uninitiated average user.)
I'm sorry this was a "gauntlet"... but I simply can not take patches that are only posted in the bz... More eyes are better than my eyes! :-)
Please feel free to ping me privately if the process is becoming a pain... I'll more that willing to work with you to smooth things out.
steved.
Quoted 24 lines
BR
--- utils/gssd/gssd_proc.c | 4 ++++ 1 file changed, 4 insertions(+)utils/gssd/gssd_proc.c +4
-0@@ -437,7 +437,11 @@ change_identity(uid_t uid)int res;/* drop list of supplimentary groups first */ +#ifdef __NR_setgroups32 +if (syscall (SYS_setgroups32,0 ,0 ) !=0 ) { +#else if (syscall (SYS_setgroups,0 ,0 ) !=0 ) { +#endif printerr (0 ,"WARNING: unable to drop supplimentary groups!" );return errno; }