clk: Warn about critical clks that fail to enable
Stephen Boyd
maintainerPATCH v2 1/1 clk: Warn about critical clks that fail to enable
If we don't warn here users of the CLK_IS_CRITICAL flag may not know that their clk isn't actually enabled because it silently fails to enable. Let's print a warning in that case so developers find these problems faster.
---
Changes from v1:
* Switched to pr_warn and indicated clk name
drivers/clk/clk.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/clk/clk.c +6 -1
@@ -3427,13 +3427,18 @@ static int __clk_core_init(struct clk_core *core)unsigned long flags; ret =clk_core_prepare (core); -if (ret) +if (ret) { +pr_warn ("%s: critical clk '%s' failed to prepare\n" , + __func__, core->name); goto out; + } flags =clk_enable_lock (); ret =clk_core_enable (core);clk_enable_unlock (flags);if (ret) { +pr_warn ("%s: critical clk '%s' failed to enable\n" , + __func__, core->name);clk_core_unprepare (core); goto out; }
base-commit: 12ead77432f2ce32dea797742316d15c5800cb32
Signature · 1 line
Sent by a computer, using git, on the internet
Quoted 4 lines · Stephen Boyd
If we don't warn here users of the
CLK_IS_CRITICALflag may not know that their clk isn't actually enabled because it silently fails to enable. Let's print a warning in that case so developers find these problems faster.
Thanks Stephen !
Quoted 38 lines
Suggested-by Jerome Brunet <[email protected]>Cc Guenter Roeck <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Changes from v1:
* Switched topr_warnand indicated clk namedrivers/clk/clk.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/clk/clk.c +6
-1@@ -3427,13 +3427,18 @@ static int __clk_core_init(struct clk_core *core)unsigned long flags; ret =clk_core_prepare (core); -if (ret) +if (ret) { +pr_warn ("%s: critical clk '%s' failed to prepare\n" , + __func__, core->name); goto out; + } flags =clk_enable_lock (); ret =clk_core_enable (core);clk_enable_unlock (flags);if (ret) { +pr_warn ("%s: critical clk '%s' failed to enable\n" , + __func__, core->name);clk_core_unprepare (core); goto out; }base-commit:
12ead77432f2ce32dea797742316d15c5800cb32
Quoted 8 lines · Stephen Boyd
If we don't warn here users of the
CLK_IS_CRITICALflag may not know that their clk isn't actually enabled because it silently fails to enable. Let's print a warning in that case so developers find these problems faster.Suggested-by Jerome Brunet <[email protected]>Cc Guenter Roeck <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 35 lines
---
Changes from v1:
* Switched topr_warnand indicated clk namedrivers/clk/clk.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/clk/clk.c +6
-1@@ -3427,13 +3427,18 @@ static int __clk_core_init(struct clk_core *core)unsigned long flags; ret =clk_core_prepare (core); -if (ret) +if (ret) { +pr_warn ("%s: critical clk '%s' failed to prepare\n" , + __func__, core->name); goto out; + } flags =clk_enable_lock (); ret =clk_core_enable (core);clk_enable_unlock (flags);if (ret) { +pr_warn ("%s: critical clk '%s' failed to enable\n" , + __func__, core->name);clk_core_unprepare (core); goto out; }base-commit:
12ead77432f2ce32dea797742316d15c5800cb32
Quoting Stephen Boyd (2020-01-01 16:55:03)
Quoted 9 lines
If we don't warn here users of the
CLK_IS_CRITICALflag may not know that their clk isn't actually enabled because it silently fails to enable. Let's print a warning in that case so developers find these problems faster.Suggested-by Jerome Brunet <[email protected]>Cc Guenter Roeck <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next