kernel/power/snapshot.c: improve arithmetic divisions
Subsystems (2)
PATCH 1/1 kernel/power/snapshot.c: improve arithmetic divisions
do_div() does a 64-by-32 division. Use div64_u64() instead of do_div() if the divisor is u64, to avoid truncation to 32-bit. This change also cleans up code a tad.
Signed-off-by Wen Yang <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Len Brown <[email protected]>
Cc Pavel Machek <[email protected]>
--- kernel/power/snapshot.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
kernel/power/snapshot.c +1 -3
@@ -1566,9 +1566,7 @@ static unsigned long preallocate_image_highmem(unsigned long nr_pages)*/ static unsigned long __fraction (u64 x,u64 multiplier,u64 base) { - x *= multiplier; -do_div (x, base); -return (unsigned long )x; +return div64_u64 (x * multiplier, base); } static unsigned long preallocate_highmem_fraction(unsigned long nr_pages,
Signature · 1 line
1.8.3.1
Quoted 21 lines · Wen Yang
do_div()does a 64-by-32 division. Usediv64_u64()instead ofdo_div()if the divisor is u64, to avoid truncation to 32-bit. This change also cleans up code a tad.Signed-off-by Wen Yang <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Len Brown <[email protected]>Cc Pavel Machek <[email protected]>--- kernel/power/snapshot.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)kernel/power/snapshot.c +0
-0@@ -1566,9 +1566,7 @@ static unsigned long preallocate_image_highmem(unsigned long nr_pages)*/
kernel/power/snapshot.c static unsigned long preallocate_image_highmem(unsigned long nr_pages)
Quoted 10 lines
kernel/power/snapshot.c +1
-4static unsigned long __fraction (u64 x,u64 multiplier,u64 base) { - x *= multiplier; -do_div (x, base); -return (unsigned long )x; +return div64_u64 (x * multiplier, base); } static unsigned long preallocate_highmem_fraction(unsigned long nr_pages, --
Applied as 5.6 material under a new subject ("PM: hibernate: improve arithmetic division in preallocate_highmem_fraction()"), thanks!