Skip to contentSkip to conversation

perf report: Clarify in help that --children is default

PATCH Arnaldo Carvalho de Melo 1 participant 1 message Jan 6, 2020 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Em Fri, Jan 03, 2020 at 10:36:43AM -0800, Andi Kleen escreveu:

Quoted 4 lines

From: Andi Kleen <[email protected]>

Refer to --no-children, which is what most people probably want.

Thanks, applied.

- Arnaldo

Quoted 21 lines
---
 tools/perf/builtin-report.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/builtin-report.c +2 -1
index 387311c67264..059639f437e5 100644
@@ -1163,7 +1163,8 @@ int cmd_report(int argc, const char **argv)
 			     report_callchain_help, &report_parse_callchain_opt,
 			     callchain_default_opt),
 	OPT_BOOLEAN(0, "children", &symbol_conf.cumulate_callchain,
-		    "Accumulate callchains of children and show total overhead as well"),
+		    "Accumulate callchains of children and show total overhead as well. "
+		    "Enabled by default, use --no-children to disable."),
 	OPT_INTEGER(0, "max-stack", &report.max_stack,
 		    "Set the maximum stack depth when parsing the callchain, "
 		    "anything beyond the specified depth will be ignored. "
Signature · 1 line
2.23.0
Signature · 1 line
- Arnaldo