Skip to contentSkip to conversation

net: ethernet: 3c515: Fix cast from pointer to integer of different size

PATCH In review Krzysztof Kozlowski 2 participants 4 messages Jan 4, 2020 – Jan 7, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 net: ethernet: 3c515: Fix cast from pointer to integer of different size

Pointer passed as integer should be cast to unsigned long to avoid warning (compile testing on alpha architecture):

drivers/net/ethernet/3com/3c515.c: In function ‘corkscrew_start_xmit’:
drivers/net/ethernet/3com/3c515.c:1066:8: warning:
cast from pointer to integer of different size [-Wpointer-to-int-cast]

---

Only compile tested

---
 drivers/net/ethernet/3com/3c515.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/3com/3c515.c +1 -1
index 1e233e2f0a5a..f5b4cacef07a 100644
@@ -1063,7 +1063,7 @@ static netdev_tx_t corkscrew_start_xmit(struct sk_buff *skb,
 #ifdef VORTEX_BUS_MASTER
 	if (vp->bus_master) {
 		/* Set the bus-master controller to transfer the packet. */
-		outl((int) (skb->data), ioaddr + Wn7_MasterAddr);
+		outl((unsigned long)(skb->data), ioaddr + Wn7_MasterAddr);
 		outw((skb->len + 3) & ~3, ioaddr + Wn7_MasterLen);
 		vp->tx_skb = skb;
 		outw(StartDMADown, ioaddr + EL3_CMD);
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 net: ethernet: ni65: Fix cast from pointer to integer of different size

"buffer" array is unsigned long so casting of pointer to u32 causes warning (compile testing on alpha architecture):

drivers/net/ethernet/amd/ni65.c: In function ‘ni65_stop_start’:
drivers/net/ethernet/amd/ni65.c:751:16: warning:
cast from pointer to integer of different size [-Wpointer-to-int-cast]

---

Only compile tested

---
 drivers/net/ethernet/amd/ni65.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/amd/ni65.c +1 -1
index c38edf6f03a3..60c194680bdf 100644
@@ -748,7 +748,7 @@ static void ni65_stop_start(struct net_device *dev,struct priv *p)
 #ifdef XMT_VIA_SKB
 			skb_save[i] = p->tmd_skb[i];
 #endif
-			buffer[i] = (u32) isa_bus_to_virt(tmdp->u.buffer);
+			buffer[i] = (unsigned long)isa_bus_to_virt(tmdp->u.buffer);
 			blen[i] = tmdp->blen;
 			tmdp->u.s.status = 0x0;
 		}
Signature · 1 line
2.17.1
#2 lore raw
In reply to Krzysztof Kozlowski

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 4 Jan 2020 15:33:05 +0100

Quoted 7 lines

Pointer passed as integer should be cast to unsigned long to avoid warning (compile testing on alpha architecture):

drivers/net/ethernet/3com/3c515.c: In function ‘corkscrew_start_xmit’:
drivers/net/ethernet/3com/3c515.c:1066:8: warning:
cast from pointer to integer of different size [-Wpointer-to-int-cast]

Quoted 5 lines

---

Only compile tested

Sorry, I'm not applying these two.

It is clear that these drivers only work properly on 32-bit architectures where virtual address equals the DMA address.

Making this warning goes away creates a false sense that they are in fact 64-bit clean and capable, they are not.

#3 lore raw
Quoted 16 lines · David Miller

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 4 Jan 2020 15:33:05 +0100

Quoted 7 lines

Pointer passed as integer should be cast to unsigned long to avoid warning (compile testing on alpha architecture):

drivers/net/ethernet/3com/3c515.c: In function ‘corkscrew_start_xmit’:
drivers/net/ethernet/3com/3c515.c:1066:8: warning:
cast from pointer to integer of different size [-Wpointer-to-int-cast]

Quoted 5 lines

---

Only compile tested

Quoted 7 lines

Sorry, I'm not applying these two.

It is clear that these drivers only work properly on 32-bit architectures where virtual address equals the DMA address.

Making this warning goes away creates a false sense that they are in fact 64-bit clean and capable, they are not.

The existing casts are clearly wrong - the convention is that pointer should be cast to unsigned long, not int. In the second case it is even weirder - the buffer array is actually unsigned long so the cast is confusing.

However I understand your argument that these casts serve as a documentation purpose of only 32-bit support, so let it be.

Thanks!

Best regards,
Krzysztof