Skip to contentSkip to conversation

staging: rtl8192u: remove unused Makefile

PATCH New Masahiro Yamada 1 participant 3 messages Jan 4, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 staging: rtl8192u: remove unused Makefile

drivers/staging/rtl8192u/ieee80211/Makefile is not used at all. All the build rules are described in drivers/staging/rtl8192u/Makefile.

---

 drivers/staging/rtl8192u/ieee80211/Makefile | 27 ---------------------
 1 file changed, 27 deletions(-)
 delete mode 100644 drivers/staging/rtl8192u/ieee80211/Makefile
drivers/staging/rtl8192u/ieee80211/Makefile deleted +0 -27
deleted file mode 100644
index 0d4d6489f767..000000000000
@@ -1,27 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-NIC_SELECT = RTL8192U
-
-ccflags-y := -O2
-ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
-
-ieee80211-rsl-objs := ieee80211_rx.o \
-		      ieee80211_softmac.o \
-		      ieee80211_tx.o \
-		      ieee80211_wx.o \
-		      ieee80211_module.o \
-		      ieee80211_softmac_wx.o\
-		      rtl819x_HTProc.o\
-		      rtl819x_TSProc.o\
-		      rtl819x_BAProc.o\
-		      dot11d.o
-
-ieee80211_crypt-rsl-objs := ieee80211_crypt.o
-ieee80211_crypt_tkip-rsl-objs := ieee80211_crypt_tkip.o
-ieee80211_crypt_ccmp-rsl-objs := ieee80211_crypt_ccmp.o
-ieee80211_crypt_wep-rsl-objs := ieee80211_crypt_wep.o
-
-obj-m +=ieee80211-rsl.o
-obj-m +=ieee80211_crypt-rsl.o
-obj-m +=ieee80211_crypt_wep-rsl.o
-obj-m +=ieee80211_crypt_tkip-rsl.o
-obj-m +=ieee80211_crypt_ccmp-rsl.o
Signature · 1 line
2.17.1
#2 lore raw

PATCH 3/3 staging: rtl8192u: remove unneeded compiler flags

-std=gnu89 is specified by the top Makefile. Adding it in a driver Makefile is redundant.

A driver should avoid specifying the optimization flag. -O2, -O3, or -Os is passed by the top Makefile based on the CONFIG_CC_OPTIMIZE_FOR_* option.

---

 drivers/staging/rtl8192u/Makefile | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/rtl8192u/Makefile +0 -3
index a7e5d3d91d9c..0be7426b6ebc 100644
@@ -1,9 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 NIC_SELECT = RTL8192U
 
-ccflags-y := -std=gnu89
-ccflags-y += -O2
-
 ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y
 ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
 ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/3 staging: rtl8192u: remove header include path to ieee80211/

In reply to Masahiro Yamada

There is no need to add "ccflags-y += -I $(srctree)/$(src)/ieee80211" just for including "dot11d.h".

Use the correct relative path for the #include "..." directive.

---

 drivers/staging/rtl8192u/Makefile      | 1 -
 drivers/staging/rtl8192u/r8192U_core.c | 2 +-
 drivers/staging/rtl8192u/r8192U_wx.c   | 2 +-
 drivers/staging/rtl8192u/r819xU_phy.c  | 2 +-
 4 files changed, 3 insertions(+), 4 deletions(-)
drivers/staging/rtl8192u/Makefile +0 -1
index dcd51bf4aed3..a7e5d3d91d9c 100644
@@ -7,7 +7,6 @@ ccflags-y += -O2
 ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y
 ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
 ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
-ccflags-y += -I $(srctree)/$(src)/ieee80211
 
 r8192u_usb-y := r8192U_core.o r8180_93cx6.o r8192U_wx.o		\
 		  r8190_rtl8256.o r819xU_phy.o r819xU_firmware.o	\
drivers/staging/rtl8192u/r8192U_core.c +1 -1
index 7e2cabd16e88..00fdcbf64b0b 100644
@@ -60,7 +60,7 @@ double __extendsfdf2(float a)
 #include <linux/seq_file.h>
 /* FIXME: check if 2.6.7 is ok */
 
-#include "dot11d.h"
+#include "ieee80211/dot11d.h"
 /* set here to open your trace code. */
 u32 rt_global_debug_component = COMP_DOWN	|
 				COMP_SEC	|
drivers/staging/rtl8192u/r8192U_wx.c +1 -1
index 5822bb7984b9..0118edb0b9ab 100644
@@ -23,7 +23,7 @@
 #include "r8192U.h"
 #include "r8192U_hw.h"
 
-#include "dot11d.h"
+#include "ieee80211/dot11d.h"
 #include "r8192U_wx.h"
 
 #define RATE_COUNT 12
drivers/staging/rtl8192u/r819xU_phy.c +1 -1
index c04d8eca0cfb..555e52522be6 100644
@@ -7,7 +7,7 @@
 #include "r8192U_dm.h"
 #include "r819xU_firmware_img.h"
 
-#include "dot11d.h"
+#include "ieee80211/dot11d.h"
 #include <linux/bitops.h>
 
 static u32 RF_CHANNEL_TABLE_ZEBRA[] = {
Signature · 1 line
2.17.1