Skip to contentSkip to conversation

staging: vc04_service: remove unused header include path

PATCH In review Masahiro Yamada 2 participants 3 messages Jan 4, 2020 – Jan 10, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vc04_service: remove unused header include path

I can build drivers/staging/vc04_services without this.

---

 drivers/staging/vc04_services/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/Makefile +1 -1
index afe43fa5a6d7..54d9e2f31916 100644
@@ -13,5 +13,5 @@ vchiq-objs := \
 obj-$(CONFIG_SND_BCM2835)	+= bcm2835-audio/
 obj-$(CONFIG_VIDEO_BCM2835)	+= bcm2835-camera/
 
-ccflags-y += -Idrivers/staging/vc04_services -D__VCCOREVER__=0x04000000
+ccflags-y += -D__VCCOREVER__=0x04000000
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 14 lines · Masahiro Yamada

I can build drivers/staging/vc04_services without this.

---

 drivers/staging/vc04_services/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/Makefile +0 -0
index afe43fa5a6d7..54d9e2f31916 100644

drivers/staging/vc04_services/Makefile vchiq-objs := \ · line 17

Quoted 6 lines
drivers/staging/vc04_services/Makefile +1 -1
@@ -13,5 +13,5 @@ vchiq-objs := \
 obj-$(CONFIG_SND_BCM2835)	+= bcm2835-audio/
 obj-$(CONFIG_VIDEO_BCM2835)	+= bcm2835-camera/
 
-ccflags-y += -Idrivers/staging/vc04_services -D__VCCOREVER__=0x04000000
+ccflags-y += -D__VCCOREVER__=0x04000000
 

This patch breaks the build for me:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:6:10: fatal error: interface/vchi/vchi.h: No such file or directory
6 | #include "interface/vchi/vchi.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

So maybe you did't select all of the modules to build?

Sorry, I can't take this as-is :(

greg k-h

#2 lore raw
Quoted 29 lines · Greg Kroah-Hartman
Quoted 13 lines · Masahiro Yamada

I can build drivers/staging/vc04_services without this.

---

 drivers/staging/vc04_services/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/Makefile +0 -0
index afe43fa5a6d7..54d9e2f31916 100644

drivers/staging/vc04_services/Makefile vchiq-objs := \

Quoted 7 lines
drivers/staging/vc04_services/Makefile +1 -2
@@ -13,5 +13,5 @@ vchiq-objs := \
 obj-$(CONFIG_SND_BCM2835)    += bcm2835-audio/
 obj-$(CONFIG_VIDEO_BCM2835)  += bcm2835-camera/
 
-ccflags-y += -Idrivers/staging/vc04_services -D__VCCOREVER__=0x04000000
+ccflags-y += -D__VCCOREVER__=0x04000000
 
--

This patch breaks the build for me:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:6:10: fatal error: interface/vchi/vchi.h: No such file or directory
6 | #include "interface/vchi/vchi.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Quoted 5 lines

So maybe you did't select all of the modules to build?

Sorry, I can't take this as-is :(

greg k-h

Sorry, I compile-tested it with O= option.

I should have tested it with/without O=
for this kind of patch.

I will fix up some relative paths.

Signature · 2 lines
Best Regards
Masahiro Yamada