Skip to contentSkip to conversation

gpio: max77620: Add missing dependency on GPIOLIB_IRQCHIP

PATCH In review Dmitry Osipenko 2 participants 2 messages Jan 6, 2020

Subsystems (2)
GPIO Tegra architecture support
lore
Share & tools
lore

Dmitry Osipenko

author
#0 lore raw

PATCH 1/1 gpio: max77620: Add missing dependency on GPIOLIB_IRQCHIP

Driver fails to compile in a minimized kernel's configuration because of the missing dependency on GPIOLIB_IRQCHIP.

error: ‘struct gpio_chip’ has no member named ‘irq’
44 | virq = irq_find_mapping(gpio->gpio_chip.irq.domain, offset);

Signed-off-by Dmitry Osipenko <[email protected]>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/Kconfig +1 -0
index 29689c7384ee..9e99d09a64c6 100644
@@ -1146,6 +1146,7 @@ config GPIO_MADERA
 config GPIO_MAX77620
 	tristate "GPIO support for PMIC MAX77620 and MAX20024"
 	depends on MFD_MAX77620
+	select GPIOLIB_IRQCHIP
 	help
 	  GPIO driver for MAX77620 and MAX20024 PMIC from Maxim Semiconductor.
 	  MAX77620 PMIC has 8 pins that can be configured as GPIOs. The
Signature · 1 line
2.24.0
#1 lore raw
Quoted 7 lines · Dmitry Osipenko

Driver fails to compile in a minimized kernel's configuration because of the missing dependency on GPIOLIB_IRQCHIP.

error: ‘struct gpio_chip’ has no member named ‘irq’
44 | virq = irq_find_mapping(gpio->gpio_chip.irq.domain, offset);

Signed-off-by Dmitry Osipenko <[email protected]>

Patch applied for fixes, thanks!

Yours,
Linus Walleij