Skip to contentSkip to conversation

net: stmmac: dwmac-sun8i: Allow all RGMII modes

PATCH In review Chen-Yu Tsai 2 participants 2 messages Jan 6, 2020 – Jan 8, 2020

Subsystems (5)
lore
Share & tools
lore

Chen-Yu Tsai

author maintainer
#0 lore raw

PATCH 1/1 net: stmmac: dwmac-sun8i: Allow all RGMII modes

From: Chen-Yu Tsai <[email protected]>

Allow all the RGMII modes to be used. This would allow us to represent the hardware better in the device tree with RGMII_ID where in most cases the PHY's internal delay for both RX and TX are used.

Fixes 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")

---

Maybe CC stable so future device trees can be used with stable kernels?

---
 drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +3 -0
index 1c8d84ed8410..01b484cb177e 100644
@@ -957,6 +957,9 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv)
 		/* default */
 		break;
 	case PHY_INTERFACE_MODE_RGMII:
+	case PHY_INTERFACE_MODE_RGMII_ID:
+	case PHY_INTERFACE_MODE_RGMII_RXID:
+	case PHY_INTERFACE_MODE_RGMII_TXID:
 		reg |= SYSCON_EPIT | SYSCON_ETCS_INT_GMII;
 		break;
 	case PHY_INTERFACE_MODE_RMII:
Signature · 1 line
2.24.1
maintainer
#1 lore raw

From: Chen-Yu Tsai <[email protected]>
Date: Mon, 6 Jan 2020 11:09:45 +0800

Quoted 8 lines

From: Chen-Yu Tsai <[email protected]>

Allow all the RGMII modes to be used. This would allow us to represent the hardware better in the device tree with RGMII_ID where in most cases the PHY's internal delay for both RX and TX are used.

Fixes 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")

Applied and queued up for -stable.