fbdev: remove object duplication in Makefile
Subsystems (2)
PATCH 1/1 fbdev: remove object duplication in Makefile
The objects in $(fb-objs) $(fb-y) $(fb-m) are linked to fb.ko .
This line adds $(fb-y) to fb-objs, so the objects from $(fb-y) are listed twice as the dependency of the module.
It works because Kbuild trims the duplicated objects from linking, but there is no good reason to have this line.
---
drivers/video/fbdev/core/Makefile | 1 - 1 file changed, 1 deletion(-)
drivers/video/fbdev/core/Makefile +0 -1
@@ -16,7 +16,6 @@ fb-y += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \ fbcon_ccw.o endif endif -fb-objs := $(fb-y) obj-$(CONFIG_FB_CFB_FILLRECT) += cfbfillrect.o obj-$(CONFIG_FB_CFB_COPYAREA) += cfbcopyarea.o
Signature · 1 line
2.17.1
Quoted 9 lines · Masahiro Yamada
The objects in $(fb-objs) $(fb-y) $(fb-m) are linked to fb.ko .
This line adds $(fb-y) to fb-objs, so the objects from $(fb-y) are listed twice as the dependency of the module.
It works because
Kbuildtrims the duplicated objects from linking, but there is no good reason to have this line.Signed-off-by Masahiro Yamada <[email protected]>
Patch queued for v5.6, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Quoted 18 lines
---
drivers/video/fbdev/core/Makefile | 1 - 1 file changed, 1 deletion(-)drivers/video/fbdev/core/Makefile +0
-1@@ -16,7 +16,6 @@ fb-y += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \ fbcon_ccw.o endif endif -fb-objs := $(fb-y) obj-$(CONFIG_FB_CFB_FILLRECT) += cfbfillrect.o obj-$(CONFIG_FB_CFB_COPYAREA) += cfbcopyarea.o