ARM: dts: exynos: tiny4412: add fimd node
Subsystems (2)
PATCH 1/2 ARM: dts: exynos: tiny4412: add fimd node
The patch adds fimd node for tiny4412 device.
--- arch/arm/boot/dts/exynos4412-tiny4412.dts | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm/boot/dts/exynos4412-tiny4412.dts +8 -0
@@ -68,6 +68,14 @@ }; }; +&fimd { + pinctrl-0 = <&lcd_clk>, <&lcd_data24>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; +}; + &rtc { status = "okay"; };
Signature · 1 line
2.17.1
PATCH 2/2 ARM: dts: exynos: tiny4412: add proper panel node
This patch add at070tn92 panel for tiny4412 board.
--- arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
arch/arm/boot/dts/exynos4412-tiny4412.dts +16 -0
@@ -66,6 +66,16 @@ clock-frequency = <24000000>; }; }; + + panel { + compatible = "innolux,at070tn92"; + + port { + panel_input: endpoint { + remote-endpoint = <&lcdc_output>; + }; + }; + }; }; &fimd {
@@ -74,6 +84,12 @@ #address-cells = <1>; #size-cells = <0>; status = "okay"; + port@3 { + reg = <3>; + lcdc_output: endpoint { + remote-endpoint = <&panel_input>; + }; + }; }; &rtc {
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerQuoted 1 line · Yangtao Li
The patch adds fimd node for tiny4412 device.
Hi,
Thanks for the patch.
Do not use "This patch ..." sentences but simple, imperative mode:
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151
Here you do not add FIMD node, because the FIMD is already there (defined in exynos4.dtsi). You however enable it.
Enabling it without panel does not really make sense - does it work? I guess not, so this should be squashed with second patch.
Best regards,
Krzysztof
Quoted 28 lines
Signed-off-by Yangtao Li <[email protected]>--- arch/arm/boot/dts/exynos4412-tiny4412.dts | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/boot/dts/exynos4412-tiny4412.dts +8
-0@@ -68,6 +68,14 @@ }; }; +&fimd { + pinctrl-0 = <&lcd_clk>, <&lcd_data24>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; +}; + &rtc { status = "okay"; };Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerQuoted 8 lines · Krzysztof Kozlowski
Quoted 1 line · Yangtao Li
The patch adds fimd node for tiny4412 device.
Hi,
Thanks for the patch.
Quoted 8 lines
Do not use "This patch ..." sentences but simple, imperative mode:
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151Here you do not add FIMD node, because the FIMD is already there (defined in
exynos4.dtsi). You however enable it.Enabling it without panel does not really make sense - does it work? I guess not, so this should be squashed with second patch.
... unless it really works without panel, then it makes sense to keep it separate. However in such case, the #cells properties belong to second patch.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerRe: [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node
In reply to Yangtao LiQuoted 1 line · Yangtao Li
This patch add at070tn92 panel for tiny4412 board.
Please fix description as in patch 1.
Quoted 28 lines
Signed-off-by Yangtao Li <[email protected]>--- arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)arch/arm/boot/dts/exynos4412-tiny4412.dts +10
-0@@ -66,6 +66,16 @@ clock-frequency = <24000000>; }; }; + + panel { + compatible = "innolux,at070tn92"; + + port { + panel_input: endpoint { + remote-endpoint = <&lcdc_output>; + }; + }; + }; }; &fimd {
arch/arm/boot/dts/exynos4412-tiny4412.dts line 86
Quoted 3 lines
arch/arm/boot/dts/exynos4412-tiny4412.dts +0
-0@@ -74,6 +84,12 @@ #address-cells = <1>; #size-cells = <0>; status = "okay";
One empty space here.
arch/arm/boot/dts/exynos4412-tiny4412.dts line 88
Quoted 2 lines
arch/arm/boot/dts/exynos4412-tiny4412.dts +2
-0+ port@3 { + reg = <3>;
Why starting from "3"? Why this is port@3, not just "port"?
Best regards,
Krzysztof
Re: [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node
Quoted 40 lines · Krzysztof Kozlowski
Quoted 1 line · Yangtao Li
This patch add at070tn92 panel for tiny4412 board.
Please fix description as in patch 1.
Quoted 28 lines
Signed-off-by Yangtao Li <[email protected]>--- arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)arch/arm/boot/dts/exynos4412-tiny4412.dts +10
-0@@ -66,6 +66,16 @@ clock-frequency = <24000000>; }; }; + + panel { + compatible = "innolux,at070tn92"; + + port { + panel_input: endpoint { + remote-endpoint = <&lcdc_output>; + }; + }; + }; }; &fimd {arch/arm/boot/dts/exynos4412-tiny4412.dts line 86
Quoted 3 lines
arch/arm/boot/dts/exynos4412-tiny4412.dts +0
-0@@ -74,6 +84,12 @@ #address-cells = <1>; #size-cells = <0>; status = "okay";One empty space here.
Quoted 4 lines
arch/arm/boot/dts/exynos4412-tiny4412.dts line 88
Quoted 2 lines
arch/arm/boot/dts/exynos4412-tiny4412.dts +2
-0+ port@3 { + reg = <3>;Why starting from "3"? Why this is port@3, not just "port"?
From samsung-fimd.txt:
---
The device node can contain 'port' child nodes according to the bindings defined in [2]. The following are properties specific to those nodes:
- reg: (required) port index, can be:
0 - for CAMIF0 input,
1 - for CAMIF1 input,
2 - for CAMIF2 input,
3 - for parallel output,
4 - for write-back interface
---
I guess it is influenced here.
https://elixir.bootlin.com/linux/v5.5-rc5/source/drivers/gpu/drm/exynos/exynos_drm_dpi.c#L170
Without it, lcd is completely black.
Your,
Yangtao
Quoted 4 lines
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerRe: [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node
Quoted 58 lines · Frank Lee
Quoted 40 lines · Krzysztof Kozlowski
Quoted 1 line · Yangtao Li
This patch add at070tn92 panel for tiny4412 board.
Please fix description as in patch 1.
Quoted 28 lines
Signed-off-by Yangtao Li <[email protected]>--- arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)arch/arm/boot/dts/exynos4412-tiny4412.dts +10
-0@@ -66,6 +66,16 @@ clock-frequency = <24000000>; }; }; + + panel { + compatible = "innolux,at070tn92"; + + port { + panel_input: endpoint { + remote-endpoint = <&lcdc_output>; + }; + }; + }; }; &fimd {arch/arm/boot/dts/exynos4412-tiny4412.dts line 86
Quoted 3 lines
arch/arm/boot/dts/exynos4412-tiny4412.dts +0
-0@@ -74,6 +84,12 @@ #address-cells = <1>; #size-cells = <0>; status = "okay";One empty space here.
Quoted 4 lines
arch/arm/boot/dts/exynos4412-tiny4412.dts line 88
Quoted 2 lines
arch/arm/boot/dts/exynos4412-tiny4412.dts +2
-0+ port@3 { + reg = <3>;Why starting from "3"? Why this is port@3, not just "port"?
From samsung-fimd.txt:
---
The device node can contain 'port' child nodes according to the bindings defined in [2]. The following are properties specific to those nodes:
- reg: (required) port index, can be:
0 - for CAMIF0 input,
1 - for CAMIF1 input,
2 - for CAMIF2 input,
3 - for parallel output,
4 - for write-back interface
---
Quoted 3 lines
I guess it is influenced here.
https://elixir.bootlin.com/linux/v5.5-rc5/source/drivers/gpu/drm/exynos/exynos_drm_dpi.c#L170
Without it, lcd is completely black.
Thanks for explanation.
Best regards,
Krzysztof