Skip to contentSkip to conversation

perf report: Fix no libunwind compiled warning break s390 issue

PATCH Applied Jin Yao 3 participants 5 messages Jan 8, 2020 – Jan 20, 2020 perf events

lore
Share & tools
lore

Jin Yao

author
#0 lore raw

PATCH 1/1 perf report: Fix no libunwind compiled warning break s390 issue

Commit 800d3f561659 ("perf report: Add warning when libunwind not compiled in") breaks the s390 platform. S390 uses libdw-dwarf-unwind for call chain unwinding and had no support for libunwind.

So the warning "Please install libunwind development packages during the perf build." caused the confusion even if the call-graph is displayed correctly.

This patch adds checking for HAVE_DWARF_SUPPORT, which is set when libdw-dwarf-unwind is compiled in.

Fixes 800d3f561659 ("perf report: Add warning when libunwind not compiled in")
---
 tools/perf/builtin-report.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-report.c +3 -3
index de988589d99b..66cd97cc8b92 100644
@@ -412,10 +412,10 @@ static int report__setup_sample_type(struct report *rep)
 				PERF_SAMPLE_BRANCH_ANY))
 		rep->nonany_branch_mode = true;
 
-#ifndef HAVE_LIBUNWIND_SUPPORT
+#if !defined(HAVE_LIBUNWIND_SUPPORT) && !defined(HAVE_DWARF_SUPPORT)
 	if (dwarf_callchain_users) {
-		ui__warning("Please install libunwind development packages "
-			    "during the perf build.\n");
+		ui__warning("Please install libunwind or libdw "
+			    "development packages during the perf build.\n");
 	}
 #endif
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jin Yao

Commit 800d3f561659 ("perf report: Add warning when libunwind not compiled in") breaks the s390 platform. S390 uses libdw-dwarf-unwind for call chain unwinding and had no support for libunwind.

So the warning "Please install libunwind development packages during the perf build." caused the confusion even if the call-graph is displayed correctly.

Quoted 8 lines

This patch adds checking for HAVE_DWARF_SUPPORT, which is set when libdw-dwarf-unwind is compiled in.

Fixes 800d3f561659 ("perf report: Add warning when libunwind not compiled in")

perfect, I have the same change prepared for sending, but it's together with making libdw default dwarf unwinder, which I'm still not sure we want to do, so it all got posponed ;-)

would you guys be ok with that? with having libdw picked up as default dwarf unwinder..

for the patch:

thanks,
jirka

Quoted 25 lines
---
 tools/perf/builtin-report.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-report.c +3 -3
index de988589d99b..66cd97cc8b92 100644
@@ -412,10 +412,10 @@ static int report__setup_sample_type(struct report *rep)
 				PERF_SAMPLE_BRANCH_ANY))
 		rep->nonany_branch_mode = true;
 
-#ifndef HAVE_LIBUNWIND_SUPPORT
+#if !defined(HAVE_LIBUNWIND_SUPPORT) && !defined(HAVE_DWARF_SUPPORT)
 	if (dwarf_callchain_users) {
-		ui__warning("Please install libunwind development packages "
-			    "during the perf build.\n");
+		ui__warning("Please install libunwind or libdw "
+			    "development packages during the perf build.\n");
 	}
 #endif
 
Signature · 1 line
2.17.1
author
#2 lore raw
Quoted 13 lines · Jiri Olsa
Quoted 12 lines · Jin Yao

Commit 800d3f561659 ("perf report: Add warning when libunwind not compiled in") breaks the s390 platform. S390 uses libdw-dwarf-unwind for call chain unwinding and had no support for libunwind.

So the warning "Please install libunwind development packages during the perf build." caused the confusion even if the call-graph is displayed correctly.

This patch adds checking for HAVE_DWARF_SUPPORT, which is set when libdw-dwarf-unwind is compiled in.

Fixes 800d3f561659 ("perf report: Add warning when libunwind not compiled in")
Quoted 8 lines
Quoted 3 lines

perfect, I have the same change prepared for sending, but it's together with making libdw default dwarf unwinder, which I'm still not sure we want to do, so it all got posponed ;-)

Quoted 1 line

would you guys be ok with that? with having libdw picked up as

default dwarf unwinder..

Quoted 1 line

I've roughly compared the performance between libunwind-dev and libdw-dev. While in my test (on KBL desktop), for the same perf report command-line, it looks the perf built with libunwind-dev is much faster than the perf built with libdw-dev.

The command line is as following:

perf record --call-graph dwarf ./div
perf report -g graph --stdio

Maybe you give it a try. :)

Quoted 4 lines

for the patch:

Thanks for reviewing the patch.

Thanks
Jin Yao

Quoted 29 lines

thanks,
jirka

Quoted 25 lines
---
  tools/perf/builtin-report.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-report.c +3 -3
index de988589d99b..66cd97cc8b92 100644
@@ -412,10 +412,10 @@ static int report__setup_sample_type(struct report *rep)
  				PERF_SAMPLE_BRANCH_ANY))
  		rep->nonany_branch_mode = true;
 
-#ifndef HAVE_LIBUNWIND_SUPPORT
+#if !defined(HAVE_LIBUNWIND_SUPPORT) && !defined(HAVE_DWARF_SUPPORT)
  	if (dwarf_callchain_users) {
-		ui__warning("Please install libunwind development packages "
-			    "during the perf build.\n");
+		ui__warning("Please install libunwind or libdw "
+			    "development packages during the perf build.\n");
  	}
  #endif
 
Signature · 1 line
2.17.1
#3 lore raw
Quoted 24 lines · Yao
Quoted 13 lines · Jiri Olsa
Quoted 12 lines · Jin Yao

Commit 800d3f561659 ("perf report: Add warning when libunwind not compiled in") breaks the s390 platform. S390 uses libdw-dwarf-unwind for call chain unwinding and had no support for libunwind.

So the warning "Please install libunwind development packages during the perf build." caused the confusion even if the call-graph is displayed correctly.

This patch adds checking for HAVE_DWARF_SUPPORT, which is set when libdw-dwarf-unwind is compiled in.

Fixes 800d3f561659 ("perf report: Add warning when libunwind not compiled in")
Quoted 8 lines
Quoted 3 lines

perfect, I have the same change prepared for sending, but it's together with making libdw default dwarf unwinder, which I'm still not sure we want to do, so it all got posponed ;-)

Quoted 1 line

would you guys be ok with that? with having libdw picked up as

Quoted 7 lines

default dwarf unwinder..

Quoted 1 line

I've roughly compared the performance between libunwind-dev and libdw-dev. While in my test (on KBL desktop), for the same perf report command-line, it looks the perf built with libunwind-dev is much faster than the perf built with libdw-dev.

ok, that's valid point.. the reason we start discussing it, was that libunwind does not seem to support compressed ELF debug sections, which works via libdw unwind

Quoted 5 lines

The command line is as following:

perf record --call-graph dwarf ./div
perf report -g graph --stdio

I'll try to do some profiling and check with outr contact in libdw to comment/check on that

thanks,
jirka

merge bot Applied
#4 lore raw
In reply to Jin Yao
The following commit has been merged into the perf/core branch of tip:

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     c3314a74f86dc00827e0945c8e5039fc3aebaa3c
Gitweb:        https://git.kernel.org/tip/c3314a74f86dc00827e0945c8e5039fc3aebaa3c
Author:        Jin Yao <[email protected]>
AuthorDate:    Wed, 08 Jan 2020 03:17:45 +08:00
Committer:     Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Tue, 14 Jan 2020 12:02:19 -03:00

perf report: Fix no libunwind compiled warning break s390 issue

Commit 800d3f561659 ("perf report: Add warning when libunwind not compiled in") breaks the s390 platform. S390 uses libdw-dwarf-unwind for call chain unwinding and had no support for libunwind.

So the warning "Please install libunwind development packages during the perf build." caused the confusion even if the call-graph is displayed correctly.

This patch adds checking for HAVE_DWARF_SUPPORT, which is set when libdw-dwarf-unwind is compiled in.

Fixes 800d3f561659 ("perf report: Add warning when libunwind not compiled in")
Cc Alexander Shishkin <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Jin Yao <[email protected]>
Cc Kan Liang <[email protected]>
Cc Peter Zijlstra <[email protected]>
---
 tools/perf/builtin-report.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-report.c +3 -3
index 627bb65..9483b3f 100644
@@ -412,10 +412,10 @@ static int report__setup_sample_type(struct report *rep)
 				PERF_SAMPLE_BRANCH_ANY))
 		rep->nonany_branch_mode = true;
 
-#ifndef HAVE_LIBUNWIND_SUPPORT
+#if !defined(HAVE_LIBUNWIND_SUPPORT) && !defined(HAVE_DWARF_SUPPORT)
 	if (dwarf_callchain_users) {
-		ui__warning("Please install libunwind development packages "
-			    "during the perf build.\n");
+		ui__warning("Please install libunwind or libdw "
+			    "development packages during the perf build.\n");
 	}
 #endif