enetc: enetc_pci_mdio: Fix inconsistent IS_ERR and PTR_ERR
Subsystems (3)
PATCH 1/1 enetc: enetc_pci_mdio: Fix inconsistent IS_ERR and PTR_ERR
Fix inconsistent IS_ERR and PTR_ERR in enetc_pci_mdio_probe().
The proper pointer to be passed as argument is hw.
This bug was detected with the help of Coccinelle.
Fixes 6517798dd343 ("enetc: Make MDIO accessors more generic and export to include/linux/fsl")
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c +1 -1
@@ -27,7 +27,7 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev, } hw =enetc_hw_alloc (dev, port_regs); -if (IS_ERR (enetc_hw_alloc)) { +if (IS_ERR (hw)) { err =PTR_ERR (hw); goto err_hw_alloc; }
Signature · 1 line
2.23.0
Hi Gustavo,
Quoted 10 lines · Gustavo A. R. Silva
Fix inconsistent
IS_ERRandPTR_ERRinenetc_pci_mdio_probe().The proper pointer to be passed as argument is hw.
This bug was detected with the help of Coccinelle.
Fixes 6517798dd343 ("enetc: Make MDIO accessors more generic and export to include/linux/fsl")Signed-off-by Gustavo A. R. Silva <[email protected]>---
This was fixed yesterday:
Quoted 17 lines
drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c +1
-2@@ -27,7 +27,7 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev, } hw =enetc_hw_alloc (dev, port_regs); -if (IS_ERR (enetc_hw_alloc)) { +if (IS_ERR (hw)) { err =PTR_ERR (hw); goto err_hw_alloc; } --
Quoted 2 lines
2.23.0
Thanks,
-Vladimir