Skip to contentSkip to conversation

btrfs/202: fix golden output

PATCH In review Johannes Thumshirn 2 participants 2 messages Jan 8, 2020 – Jan 9, 2020 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs/202: fix golden output

From: Johannes Thumshirn <[email protected]>

The golden output of btrfs/202 contains the sequence number 201 instead of 202, fix this.

---
 tests/btrfs/202.out | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/btrfs/202.out +1 -1
index 938870cf..7f33d49f 100644
@@ -1,4 +1,4 @@
-QA output created by 201
+QA output created by 202
 Create subvolume 'SCRATCH_MNT/a'
 Create subvolume 'SCRATCH_MNT/a/b'
 Create a snapshot of 'SCRATCH_MNT/a' in 'SCRATCH_MNT/c'
Signature · 1 line
2.16.4
#1 lore raw
Quoted 15 lines · Johannes Thumshirn

From: Johannes Thumshirn <[email protected]>

The golden output of btrfs/202 contains the sequence number 201 instead of 202, fix this.

---
 tests/btrfs/202.out | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/btrfs/202.out +0 -0
index 938870cf..7f33d49f 100644

tests/btrfs/202.out line 1

Quoted 2 lines
tests/btrfs/202.out +1 -1
@@ -1,4 +1,4 @@
-QA output created by 201
+QA output created by 202

This really makes people laughing.

But this also makes me wonder, do we really need the test number in golden output?

If the diff is from check, we have context showing which test case we're. If the diff is from manually diffing golden and result, then we have the test number in the path.

The test number in golden output looks duplicated to me.

Eryu, can we just remove it?

Thanks,
Qu

Quoted 4 lines
tests/btrfs/202.out +0 -0
 Create subvolume 'SCRATCH_MNT/a'
 Create subvolume 'SCRATCH_MNT/a/b'
 Create a snapshot of 'SCRATCH_MNT/a' in 'SCRATCH_MNT/c'