Skip to contentSkip to conversation

drm/panfrost: Remove core stack power management

PATCH In review Steven Price 3 participants 3 messages Jan 9, 2020 – Jan 10, 2020

Subsystems (3)
lore
Share & tools
lore

Steven Price

author maintainer
#0 lore raw

PATCH 1/1 drm/panfrost: Remove core stack power management

Explict management of the GPU's core stacks is only necessary in the case of a broken integration with the PDC. Since there are no known platforms which have such a broken integration let's remove the explict control from the driver since this apparently causes problems on other platforms and will have a small performance penality.

The out of tree mali_kbase driver contains this text regarding controlling the core stack (CONFIGMALI_CORESTACK):

Enabling this feature on supported GPUs will let the driver powering on/off the GPU core stack independently without involving the Power Domain Controller. This should only be enabled on platforms which integration of the PDC to the Mali GPU is known to be problematic. This feature is currently only supported on t-Six and t-HEx GPUs.

If unsure, say N.

---
 drivers/gpu/drm/panfrost/panfrost_gpu.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/panfrost/panfrost_gpu.c +0 -5
index 8822ec13a0d6..460fc190de6e 100644
@@ -309,10 +309,6 @@ void panfrost_gpu_power_on(struct panfrost_device *pfdev)
 	ret = readl_relaxed_poll_timeout(pfdev->iomem + L2_READY_LO,
 		val, val == pfdev->features.l2_present, 100, 1000);
 
-	gpu_write(pfdev, STACK_PWRON_LO, pfdev->features.stack_present);
-	ret |= readl_relaxed_poll_timeout(pfdev->iomem + STACK_READY_LO,
-		val, val == pfdev->features.stack_present, 100, 1000);
-
 	gpu_write(pfdev, SHADER_PWRON_LO, pfdev->features.shader_present);
 	ret |= readl_relaxed_poll_timeout(pfdev->iomem + SHADER_READY_LO,
 		val, val == pfdev->features.shader_present, 100, 1000);
@@ -329,7 +325,6 @@ void panfrost_gpu_power_off(struct panfrost_device *pfdev)
 {
 	gpu_write(pfdev, TILER_PWROFF_LO, 0);
 	gpu_write(pfdev, SHADER_PWROFF_LO, 0);
-	gpu_write(pfdev, STACK_PWROFF_LO, 0);
 	gpu_write(pfdev, L2_PWROFF_LO, 0);
 }
 
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

A-b

Quoted 48 lines · Steven Price

Explict management of the GPU's core stacks is only necessary in the case of a broken integration with the PDC. Since there are no known platforms which have such a broken integration let's remove the explict control from the driver since this apparently causes problems on other platforms and will have a small performance penality.

The out of tree mali_kbase driver contains this text regarding controlling the core stack (CONFIGMALI_CORESTACK):

Enabling this feature on supported GPUs will let the driver powering on/off the GPU core stack independently without involving the Power Domain Controller. This should only be enabled on platforms which integration of the PDC to the Mali GPU is known to be problematic. This feature is currently only supported on t-Six and t-HEx GPUs.

If unsure, say N.

---
 drivers/gpu/drm/panfrost/panfrost_gpu.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/panfrost/panfrost_gpu.c +0 -5
index 8822ec13a0d6..460fc190de6e 100644
@@ -309,10 +309,6 @@ void panfrost_gpu_power_on(struct panfrost_device *pfdev)
 	ret = readl_relaxed_poll_timeout(pfdev->iomem + L2_READY_LO,
 		val, val == pfdev->features.l2_present, 100, 1000);
 
-	gpu_write(pfdev, STACK_PWRON_LO, pfdev->features.stack_present);
-	ret |= readl_relaxed_poll_timeout(pfdev->iomem + STACK_READY_LO,
-		val, val == pfdev->features.stack_present, 100, 1000);
-
 	gpu_write(pfdev, SHADER_PWRON_LO, pfdev->features.shader_present);
 	ret |= readl_relaxed_poll_timeout(pfdev->iomem + SHADER_READY_LO,
 		val, val == pfdev->features.shader_present, 100, 1000);
@@ -329,7 +325,6 @@ void panfrost_gpu_power_off(struct panfrost_device *pfdev)
 {
 	gpu_write(pfdev, TILER_PWROFF_LO, 0);
 	gpu_write(pfdev, SHADER_PWROFF_LO, 0);
-	gpu_write(pfdev, STACK_PWROFF_LO, 0);
 	gpu_write(pfdev, L2_PWROFF_LO, 0);
 }
 
Signature · 1 line
2.20.1
Reviewed-by Tested-by
#2 lore raw
Quoted 21 lines · Alyssa Rosenzweig

A-b

Quoted 17 lines · Steven Price

Explict management of the GPU's core stacks is only necessary in the case of a broken integration with the PDC. Since there are no known platforms which have such a broken integration let's remove the explict control from the driver since this apparently causes problems on other platforms and will have a small performance penality.

The out of tree mali_kbase driver contains this text regarding controlling the core stack (CONFIGMALI_CORESTACK):

Enabling this feature on supported GPUs will let the driver powering on/off the GPU core stack independently without involving the Power Domain Controller. This should only be enabled on platforms which integration of the PDC to the Mali GPU is known to be problematic. This feature is currently only supported on t-Six and t-HEx GPUs.

If unsure, say N.

Work on my G-72 Bifrost, no more errors on power on!

Quoted 28 lines
Quoted 28 lines
---
 drivers/gpu/drm/panfrost/panfrost_gpu.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/panfrost/panfrost_gpu.c +0 -5
index 8822ec13a0d6..460fc190de6e 100644
@@ -309,10 +309,6 @@ void panfrost_gpu_power_on(struct panfrost_device *pfdev)
      ret = readl_relaxed_poll_timeout(pfdev->iomem + L2_READY_LO,
              val, val == pfdev->features.l2_present, 100, 1000);
 
-     gpu_write(pfdev, STACK_PWRON_LO, pfdev->features.stack_present);
-     ret |= readl_relaxed_poll_timeout(pfdev->iomem + STACK_READY_LO,
-             val, val == pfdev->features.stack_present, 100, 1000);
-
      gpu_write(pfdev, SHADER_PWRON_LO, pfdev->features.shader_present);
      ret |= readl_relaxed_poll_timeout(pfdev->iomem + SHADER_READY_LO,
              val, val == pfdev->features.shader_present, 100, 1000);
@@ -329,7 +325,6 @@ void panfrost_gpu_power_off(struct panfrost_device *pfdev)
 {
      gpu_write(pfdev, TILER_PWROFF_LO, 0);
      gpu_write(pfdev, SHADER_PWROFF_LO, 0);
-     gpu_write(pfdev, STACK_PWROFF_LO, 0);
      gpu_write(pfdev, L2_PWROFF_LO, 0);
 }
 
Quoted 3 lines
Quoted 3 lines

--
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel