Skip to contentSkip to conversation

kconfig: ignore temporary generated files

PATCH In review Bartosz Golaszewski 3 participants 4 messages Jan 9, 2020 – Jan 11, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kconfig: ignore temporary generated files

From: Bartosz Golaszewski <[email protected]>

If building gconfig fails, a temporary gtk config file is left in the kconfig directory and is not ignored by git. Add an appropriate pattern to .gitignore.

---
 scripts/kconfig/.gitignore | 1 +
 1 file changed, 1 insertion(+)
scripts/kconfig/.gitignore +1 -0
index b5bf92f66d11..d22e6753397d 100644
@@ -3,6 +3,7 @@
 #
 *.moc
 *conf-cfg
+*conf-cfg.tmp
 
 #
 # configuration programs
Signature · 1 line
2.23.0
#1 lore raw
Quoted 17 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

If building gconfig fails, a temporary gtk config file is left in the kconfig directory and is not ignored by git. Add an appropriate pattern to .gitignore.

---
 scripts/kconfig/.gitignore | 1 +
 1 file changed, 1 insertion(+)
scripts/kconfig/.gitignore +0 -0
index b5bf92f66d11..d22e6753397d 100644

scripts/kconfig/.gitignore line 6

Quoted 4 lines
scripts/kconfig/.gitignore +1 -0
@@ -3,6 +3,7 @@
 #
 *.moc
 *conf-cfg
+*conf-cfg.tmp

I have no idea in which situation this pattern is left.

Could you tell me the way to reproduce it?

Quoted 6 lines
scripts/kconfig/.gitignore +0 -1
 #
 # configuration programs
--

2.23.0

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw

czw., 9 sty 2020 o 17:36 Masahiro Yamada <[email protected]> napisał(a):

Quoted 26 lines · Bartosz Golaszewski
Quoted 17 lines

From: Bartosz Golaszewski <[email protected]>

If building gconfig fails, a temporary gtk config file is left in the kconfig directory and is not ignored by git. Add an appropriate pattern to .gitignore.

---
 scripts/kconfig/.gitignore | 1 +
 1 file changed, 1 insertion(+)
scripts/kconfig/.gitignore +0 -0
index b5bf92f66d11..d22e6753397d 100644

scripts/kconfig/.gitignore line 6

Quoted 4 lines
scripts/kconfig/.gitignore +1 -0
@@ -3,6 +3,7 @@
 #
 *.moc
 *conf-cfg
+*conf-cfg.tmp

I have no idea in which situation this pattern is left.

Quoted 1 line

Could you tell me the way to reproduce it?

Sure:

1. Don't have gtk+ development files installed.
2. Run make gconfig.
3. Watch it fail with the following error message:

---

$ make gconfig
*
* Unable to find the GTK+ installation. Please make sure that
* the GTK+ 2.0 development package is correctly installed.
* You need gtk+-2.0 gmodule-2.0 libglade-2.0
*
make[1]: *** [scripts/kconfig/Makefile:212: scripts/kconfig/gconf-cfg] Error 1
make: *** [Makefile:568: gconfig] Error 2
---

4. See the file gconf-cfg.tmp under scripts/kconfig.

Bart

#3 lore raw
Quoted 47 lines · Bartosz Golaszewski

czw., 9 sty 2020 o 17:36 Masahiro Yamada <[email protected]> napisał(a):

Quoted 26 lines · Bartosz Golaszewski
Quoted 17 lines

From: Bartosz Golaszewski <[email protected]>

If building gconfig fails, a temporary gtk config file is left in the kconfig directory and is not ignored by git. Add an appropriate pattern to .gitignore.

---
 scripts/kconfig/.gitignore | 1 +
 1 file changed, 1 insertion(+)
scripts/kconfig/.gitignore +0 -0
index b5bf92f66d11..d22e6753397d 100644

scripts/kconfig/.gitignore line 6

Quoted 4 lines
scripts/kconfig/.gitignore +1 -0
@@ -3,6 +3,7 @@
 #
 *.moc
 *conf-cfg
+*conf-cfg.tmp

I have no idea in which situation this pattern is left.

Quoted 1 line

Could you tell me the way to reproduce it?

Sure:

1. Don't have gtk+ development files installed.
2. Run make gconfig.
3. Watch it fail with the following error message:

---

$ make gconfig
*
* Unable to find the GTK+ installation. Please make sure that
* the GTK+ 2.0 development package is correctly installed.
* You need gtk+-2.0 gmodule-2.0 libglade-2.0
*
make[1]: *** [scripts/kconfig/Makefile:212: scripts/kconfig/gconf-cfg] Error 1
make: *** [Makefile:568: gconfig] Error 2
---
Quoted 3 lines

4. See the file gconf-cfg.tmp under scripts/kconfig.

Bart

Thanks for this info.

This seems a kbuild bug, so I fixed the root cause instead of hiding the garbage files.

https://patchwork.kernel.org/patch/11326631/

Signature · 2 lines
Best Regards
Masahiro Yamada