ARM: at91: Enable SPL_SEPARATE_BSS by default
Subsystems (2)
PATCH 1/2 ARM: at91: Enable SPL_SEPARATE_BSS by default
According to the linker script for both armv7 and arm926ejs based SoC, BSS section was all the time separated for SPL but this symbol was only enabled on some boards. However, it is necessary to have it enabled for OF_SEPARATE configuration where DTB is appended to u-boot with DTB.
--- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/Kconfig +1 -0
@@ -492,6 +492,7 @@ choice config ARCH_AT91 bool "Atmel AT91" select SPL_BOARD_INIT if SPL && !TARGET_SMARTWEB + select SPL_SEPARATE_BSS if SPL config TARGET_EDB93XX bool "Support edb93xx"
Signature · 1 line
2.24.1
PATCH 2/2 configs: atmel: cleanup CONFIG_SPL_SEPARATE_BSS
Now that CONFIG_SPL_SEPARATE_BSS is selected for all the AT91 based boards, cleanups the defconfigs by removing it.
--- configs/gardena-smart-gateway-at91sam_defconfig | 1 - configs/sama5d27_som1_ek_mmc1_defconfig | 1 - configs/sama5d27_som1_ek_mmc_defconfig | 1 - configs/sama5d27_som1_ek_qspiflash_defconfig | 1 - configs/sama5d27_wlsom1_ek_mmc_defconfig | 1 - configs/sama5d27_wlsom1_ek_qspiflash_defconfig | 1 - configs/sama5d2_icp_mmc_defconfig | 1 - configs/sama5d2_xplained_emmc_defconfig | 1 - configs/sama5d2_xplained_mmc_defconfig | 1 - configs/sama5d2_xplained_qspiflash_defconfig | 1 - configs/sama5d3_xplained_mmc_defconfig | 1 - configs/sama5d3xek_mmc_defconfig | 1 - configs/sama5d4_xplained_mmc_defconfig | 1 - configs/sama5d4ek_mmc_defconfig | 1 - 14 files changed, 14 deletions(-)
configs/gardena-smart-gateway-at91sam_defconfig +0 -1
@@ -25,7 +25,6 @@ CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk mtdparts=atmel_nand:256k(boots CONFIG_SYS_CONSOLE_IS_IN_ENV=y CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_SPL_SYS_MALLOC_SIMPLE=y -CONFIG_SPL_SEPARATE_BSS=y # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set CONFIG_SPL_NAND_SUPPORT=y CONFIG_HUSH_PARSER=y
configs/sama5d27_som1_ek_mmc1_defconfig +0 -1
@@ -28,7 +28,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk1p2 rw rootwait" CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_FLASH is not set
configs/sama5d27_som1_ek_mmc_defconfig +0 -1
@@ -29,7 +29,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rw rootwait" CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_FLASH is not set
configs/sama5d27_som1_ek_qspiflash_defconfig +0 -1
@@ -29,7 +29,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rw rootwait" CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_FLASH is not set
configs/sama5d27_wlsom1_ek_mmc_defconfig +0 -1
@@ -27,7 +27,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y -CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_DISPLAY_PRINT=y # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set CONFIG_SPL_AT91_MCK_BYPASS=y
configs/sama5d27_wlsom1_ek_qspiflash_defconfig +0 -1
@@ -27,7 +27,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y -CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_DISPLAY_PRINT=y # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set CONFIG_SPL_SPI_LOAD=y
configs/sama5d2_icp_mmc_defconfig +0 -1
@@ -25,7 +25,6 @@ CONFIG_SD_BOOT=y CONFIG_BOOTDELAY=3 CONFIG_USE_BOOTARGS=y # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_DISPLAY_PRINT=y # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set CONFIG_SPL_RAM_SUPPORT=y
configs/sama5d2_xplained_emmc_defconfig +0 -1
@@ -27,7 +27,6 @@ CONFIG_BOOTDELAY=3 CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rw rootwait" # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_FLASH is not set
configs/sama5d2_xplained_mmc_defconfig +0 -1
@@ -29,7 +29,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk1p2 rw rootwait" CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_FLASH is not set
configs/sama5d2_xplained_qspiflash_defconfig +0 -1
@@ -29,7 +29,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p1 rw rootwait" CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_FLASH is not set
configs/sama5d3_xplained_mmc_defconfig +0 -1
@@ -27,7 +27,6 @@ CONFIG_BOOTDELAY=3 CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rw rootwait" # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_FLASH is not set
configs/sama5d3xek_mmc_defconfig +0 -1
@@ -29,7 +29,6 @@ CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rw rootwai # CONFIG_CONSOLE_MUX is not set CONFIG_SYS_CONSOLE_IS_IN_ENV=y # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_IMI is not set
configs/sama5d4_xplained_mmc_defconfig +0 -1
@@ -28,7 +28,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rw rootwait" CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_FLASH is not set
configs/sama5d4ek_mmc_defconfig +0 -1
@@ -29,7 +29,6 @@ CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rw rootwai # CONFIG_CONSOLE_MUX is not set CONFIG_SYS_CONSOLE_IS_IN_ENV=y # CONFIG_DISPLAY_BOARDINFO is not set -CONFIG_SPL_SEPARATE_BSS=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y # CONFIG_CMD_IMI is not set
Signature · 1 line
2.24.1
PATCH 2/2 configs: atmel: cleanup CONFIG_SPL_SEPARATE_BSS
Quoted 4 lines · Gregory CLEMENT
Now that
CONFIG_SPL_SEPARATE_BSSis selected for all the AT91 based boards, cleanups the defconfigs by removing it.Signed-off-by Gregory CLEMENT <[email protected]>
Quoted 16 lines
--- configs/gardena-smart-gateway-at91sam_defconfig | 1 - configs/sama5d27_som1_ek_mmc1_defconfig | 1 - configs/sama5d27_som1_ek_mmc_defconfig | 1 - configs/sama5d27_som1_ek_qspiflash_defconfig | 1 - configs/sama5d27_wlsom1_ek_mmc_defconfig | 1 - configs/sama5d27_wlsom1_ek_qspiflash_defconfig | 1 - configs/sama5d2_icp_mmc_defconfig | 1 - configs/sama5d2_xplained_emmc_defconfig | 1 - configs/sama5d2_xplained_mmc_defconfig | 1 - configs/sama5d2_xplained_qspiflash_defconfig | 1 - configs/sama5d3_xplained_mmc_defconfig | 1 - configs/sama5d3xek_mmc_defconfig | 1 - configs/sama5d4_xplained_mmc_defconfig | 1 - configs/sama5d4ek_mmc_defconfig | 1 - 14 files changed, 14 deletions(-)
Thanks,
Stefan
PATCH 1/2 ARM: at91: Enable SPL_SEPARATE_BSS by default
In reply to Gregory CLEMENTQuoted 17 lines · Gregory CLEMENT
According to the linker script for both armv7 and arm926ejs based SoC, BSS section was all the time separated for SPL but this symbol was only enabled on some boards. However, it is necessary to have it enabled for
OF_SEPARATEconfiguration where DTB is appended to u-boot with DTB.Signed-off-by Gregory CLEMENT <[email protected]>--- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)arch/arm/Kconfig +0
-0
arch/arm/Kconfig choice · line 498
Quoted 7 lines
arch/arm/Kconfig +1
-0@@ -492,6 +492,7 @@ choice config ARCH_AT91 bool "Atmel AT91" select SPL_BOARD_INIT if SPL && !TARGET_SMARTWEB + select SPL_SEPARATE_BSS if SPL config TARGET_EDB93XX bool "Support edb93xx"
Thanks,
Stefan
PATCH 1/2 ARM: at91: Enable SPL_SEPARATE_BSS by default
Quoted 22 lines · Stefan Roese
Quoted 21 lines · Gregory CLEMENT
According to the linker script for both armv7 and arm926ejs based SoC, BSS section was all the time separated for SPL but this symbol was only enabled on some boards. However, it is necessary to have it enabled for
OF_SEPARATEconfiguration where DTB is appended to u-boot with DTB.Signed-off-by Gregory CLEMENT <[email protected]>---
arch/arm/Kconfig| 1 +1 file changed, 1 insertion(+)arch/arm/Kconfig +0
-0@@ -492,6 +492,7 @@ choiceconfig
ARCH_AT91
bool "Atmel AT91"
selectSPL_BOARD_INITif SPL && !TARGET_SMARTWEB + selectSPL_SEPARATE_BSSif SPL
Quoted 9 lines
Quoted 3 lines
config
TARGET_EDB93XX
bool "Support edb93xx"Reviewed-by Stefan Roese <[email protected]>Thanks,
Stefan
Hi,
With these changes, for all the A5 boards , SEPARATE_BSS was already enabled, but for the rest of the platforms, it was not.
As I see from the linker script, the BSS area is configured into DRAM area. Is there any chance that we have accesses to this section before the DRAM is initialized on these platforms ? Could cause the boards to hang.
Eugen
PATCH 1/2 ARM: at91: Enable SPL_SEPARATE_BSS by default
Hi Eugen,
Quoted 34 lines · Stefan Roese
Quoted 23 lines · Gregory CLEMENT
Quoted 21 lines
According to the linker script for both armv7 and arm926ejs based SoC, BSS section was all the time separated for SPL but this symbol was only enabled on some boards. However, it is necessary to have it enabled for
OF_SEPARATEconfiguration where DTB is appended to u-boot with DTB.Signed-off-by Gregory CLEMENT <[email protected]>---
?arch/arm/Kconfig| 1 +
? 1 file changed, 1 insertion(+)arch/arm/Kconfig +0
-0@@ -492,6 +492,7 @@ choice? config
ARCH_AT91
????? bool "Atmel AT91"
????? selectSPL_BOARD_INITif SPL && !TARGET_SMARTWEB +???? selectSPL_SEPARATE_BSSif SPLQuoted 9 lines
Quoted 3 lines
? config
TARGET_EDB93XX
????? bool "Support edb93xx"Reviewed-by Stefan Roese <[email protected]>Thanks,
Stefan
Quoted 8 lines
Hi,
With these changes, for all the A5 boards ,
SEPARATE_BSSwas already enabled, but for the rest of the platforms, it was not.
As I see from the linker script, the BSS area is configured into DRAM area. Is there any chance that we have accesses to this section before the DRAM is initialized on these platforms ? Could cause the boards to hang.
It is explicitly stated that it BSS is not available before setting up the DRAM: it is forbidden to use global/static variables. So it should be OK.
Gregory
Quoted 2 lines
Eugen
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
PATCH 1/2 ARM: at91: Enable SPL_SEPARATE_BSS by default
Quoted 45 lines · Gregory CLEMENT
Hi Eugen,
Quoted 34 lines · Stefan Roese
Quoted 23 lines · Gregory CLEMENT
Quoted 21 lines
According to the linker script for both armv7 and arm926ejs based SoC, BSS section was all the time separated for SPL but this symbol was only enabled on some boards. However, it is necessary to have it enabled for
OF_SEPARATEconfiguration where DTB is appended to u-boot with DTB.Signed-off-by Gregory CLEMENT <[email protected]>--- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)arch/arm/Kconfig +1
-0@@ -492,6 +492,7 @@ choice config ARCH_AT91 bool "Atmel AT91" select SPL_BOARD_INIT if SPL && !TARGET_SMARTWEB + select SPL_SEPARATE_BSS if SPLQuoted 9 lines
arch/arm/Kconfig choice · line 498
Quoted 3 lines
arch/arm/Kconfig +0
-0config TARGET_EDB93XX bool "Support edb93xx"Reviewed-by Stefan Roese <[email protected]>Thanks,
StefanQuoted 8 lines
Hi,
With these changes, for all the A5 boards ,
SEPARATE_BSSwas already enabled, but for the rest of the platforms, it was not.
As I see from the linker script, the BSS area is configured into DRAM area. Is there any chance that we have accesses to this section before the DRAM is initialized on these platforms ? Could cause the boards to hang.
Quoted 4 lines
It is explicitly stated that it BSS is not available before setting up the DRAM: it is forbidden to use global/static variables. So it should be OK.
Thanks for the clarification. Will queue the patches for next merge window.
Eugen
Quoted 10 lines
Gregory
Quoted 2 lines
Eugen
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
PATCH 1/2 ARM: at91: Enable SPL_SEPARATE_BSS by default
Hi Eugen,
Quoted 46 lines · Gregory CLEMENT
Quoted 45 lines
Hi Eugen,
Quoted 42 lines · Stefan Roese
Quoted 23 lines · Gregory CLEMENT
Quoted 21 lines
According to the linker script for both armv7 and arm926ejs based SoC, BSS section was all the time separated for SPL but this symbol was only enabled on some boards. However, it is necessary to have it enabled for
OF_SEPARATEconfiguration where DTB is appended to u-boot with DTB.Signed-off-by Gregory CLEMENT <[email protected]>--- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)arch/arm/Kconfig +1
-0@@ -492,6 +492,7 @@ choice config ARCH_AT91 bool "Atmel AT91" select SPL_BOARD_INIT if SPL && !TARGET_SMARTWEB + select SPL_SEPARATE_BSS if SPLQuoted 9 lines
arch/arm/Kconfig choice · line 498
Quoted 3 lines
arch/arm/Kconfig +0
-0config TARGET_EDB93XX bool "Support edb93xx"Reviewed-by Stefan Roese <[email protected]>Thanks,
StefanHi,
With these changes, for all the A5 boards ,
SEPARATE_BSSwas already enabled, but for the rest of the platforms, it was not.
As I see from the linker script, the BSS area is configured into DRAM area. Is there any chance that we have accesses to this section before the DRAM is initialized on these platforms ? Could cause the boards to hang.
Quoted 7 lines
Quoted 4 lines
It is explicitly stated that it BSS is not available before setting up the DRAM: it is forbidden to use global/static variables. So it should be OK.
Thanks for the clarification. Will queue the patches for next merge window.
Thanks, actually I've just sent a v2 because in the meantime an other defconfig needed to be updated.
Gregory
Quoted 14 lines
Eugen
Quoted 10 lines
Gregory
Quoted 2 lines
Eugen
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com