nvmem: fix a 'makes pointer from integer without a cast' build warning
PATCH 1/1 nvmem: fix a 'makes pointer from integer without a cast' build warning
From: Bartosz Golaszewski <[email protected]>
nvmem_register() returns a pointer, not a long int. Use ERR_CAST() to cast the struct gpio_desc pointer to struct nvmem_device.
--- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvmem/core.c +1 -1
@@ -351,7 +351,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) nvmem->wp_gpio =gpiod_get_optional (config->dev,"wp" ,GPIOD_OUT_HIGH );if (IS_ERR (nvmem->wp_gpio)) -return PTR_ERR (nvmem->wp_gpio); +return ERR_CAST (nvmem->wp_gpio);kref_init (&nvmem->refcnt);
Signature · 1 line
2.23.0
pt., 10 sty 2020 o 09:24 Bartosz Golaszewski <[email protected]> napisał(a):
Quoted 27 lines
From: Bartosz Golaszewski <[email protected]>
nvmem_register()returns a pointer, not a long int. UseERR_CAST()to cast the structgpio_descpointer to structnvmem_device.Reported-by kbuild test robot <[email protected]>Fixes 2a127da461a9 ("nvmem: add support for the write-protect pin")Signed-off-by Bartosz Golaszewski <[email protected]>--- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvmem/core.c +1
-2@@ -351,7 +351,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) nvmem->wp_gpio =gpiod_get_optional (config->dev,"wp" ,GPIOD_OUT_HIGH );if (IS_ERR (nvmem->wp_gpio)) -return PTR_ERR (nvmem->wp_gpio); +return ERR_CAST (nvmem->wp_gpio);kref_init (&nvmem->refcnt); --
Quoted 2 lines
2.23.0
Srinivas: this fixes a bug introduced in a patch I took through the at24 tree. With your ack I'll apply it as a follow-up.
Bart
Thanks for the patch.
Quoted 9 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
nvmem_register()returns a pointer, not a long int. UseERR_CAST()to cast the structgpio_descpointer to structnvmem_device.Reported-by kbuild test robot <[email protected]>Fixes 2a127da461a9 ("nvmem: add support for the write-protect pin")Signed-off-by Bartosz Golaszewski <[email protected]>---
Quoted 17 lines
drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvmem/core.c +1
-1@@ -351,7 +351,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) nvmem->wp_gpio =gpiod_get_optional (config->dev,"wp" ,GPIOD_OUT_HIGH );if (IS_ERR (nvmem->wp_gpio)) -return PTR_ERR (nvmem->wp_gpio); +return ERR_CAST (nvmem->wp_gpio);kref_init (&nvmem->refcnt);
pt., 10 sty 2020 o 11:16 Srinivas Kandagatla
<[email protected]> napisał(a):
Quoted 9 lines
Thanks for the patch.
Quoted 5 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
nvmem_register()returns a pointer, not a long int. UseERR_CAST()to cast the structgpio_descpointer to structnvmem_device.
Quoted 7 lines
Quoted 4 lines
Reported-by kbuild test robot <[email protected]>Fixes 2a127da461a9 ("nvmem: add support for the write-protect pin")Signed-off-by Bartosz Golaszewski <[email protected]>---
Thanks. This is rather uncontroversial, so applied right away.
Bart