Skip to contentSkip to conversation

media: davinci: remove self assignment in vpfe

PATCH In review Cengiz Can 2 participants 3 messages Jan 13, 2020 – Jan 16, 2020 Media (V4L/DVB)

lore
Share & tools
lore

Cengiz Can

author
#0 lore raw

PATCH 1/1 media: davinci: remove self assignment in vpfe

There's a self assignment which has no effect.

Removed self assignment.

---
 drivers/media/platform/davinci/vpfe_capture.c | 1 -
 1 file changed, 1 deletion(-)
drivers/media/platform/davinci/vpfe_capture.c +0 -1
index 916ed743d716..089648665cdf 100644
@@ -879,7 +879,6 @@ static int vpfe_enum_fmt_vid_cap(struct file *file, void  *priv,
 	/* Fill in the information about format */
 	pix_fmt = vpfe_lookup_pix_format(pix);
 	if (pix_fmt) {
-		fmt->pixelformat = fmt->pixelformat;
 		return 0;
 	}
 	return -EINVAL;

--
2.24.1

#1 lore raw

Hi Cengiz,

Thank you for the patch.

Quoted 15 lines · Cengiz Can

There's a self assignment which has no effect.

Removed self assignment.

---
 drivers/media/platform/davinci/vpfe_capture.c | 1 -
 1 file changed, 1 deletion(-)
drivers/media/platform/davinci/vpfe_capture.c +0 -0
index 916ed743d716..089648665cdf 100644

drivers/media/platform/davinci/vpfe_capture.c static int vpfe_enum_fmt_vid_cap(struct file *file, void *priv, · line 882

Quoted 4 lines
drivers/media/platform/davinci/vpfe_capture.c +0 -1
@@ -879,7 +879,6 @@ static int vpfe_enum_fmt_vid_cap(struct file *file, void  *priv,
        /* Fill in the information about format */
        pix_fmt = vpfe_lookup_pix_format(pix);
        if (pix_fmt) {
-               fmt->pixelformat = fmt->pixelformat;

good catch, but the correct fix is to assign pix_fmt->pixelformat to fmt->pixelformat.

Cheers,
--Prabhakar Lad

Quoted 6 lines
drivers/media/platform/davinci/vpfe_capture.c +0 -1
                return 0;
        }
        return -EINVAL;
--

2.24.1

author
#2 lore raw

PATCH v2 1/1 media: davinci: fix incorrect pix_fmt assignment

There's a mistakenly written self assignment in
static int vpfe_enum_fmt_vid_cap(..).

Fixed it according to Prabhakar Lad's feedback.

---
 drivers/media/platform/davinci/vpfe_capture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/davinci/vpfe_capture.c +1 -1
index 916ed743d716..357f7ade5218 100644
@@ -879,7 +879,7 @@ static int vpfe_enum_fmt_vid_cap(struct file *file, void  *priv,
 	/* Fill in the information about format */
 	pix_fmt = vpfe_lookup_pix_format(pix);
 	if (pix_fmt) {
-		fmt->pixelformat = fmt->pixelformat;
+		fmt->pixelformat = pix_fmt->pixelformat;
 		return 0;
 	}
 	return -EINVAL;

--
2.25.0