Skip to contentSkip to conversation

mfd: bd70528: Fix hour register mask

PATCH In review Matti Vaittinen 3 participants 6 messages Jan 15, 2020 – Jan 17, 2020 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: bd70528: Fix hour register mask

When RTC is used in 24H mode (and it is by this driver) the maximum hour value is 24 in BCD. This occupies bits [5:0] - which means correct mask for HOUR register is 0x3f not 0x1f. Fix the mask

Fixes 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")

---

I just noticed this was never applied. I'd like to get this in as we currently have bd70528 RTC not working in few exiting releases. (Or it works as long as time is not set at the evening :/)

I think this once was in RTC tree but was dropped as Lee mentioned this belongs to MFD. Thus I dared to add the Alexandre's acked-by - please let me know if this is not Ok.

Lee, can you please pull this in so that we get the fix in-tree? I guess the fixes tag helps this to be included in some existing branches.

 include/linux/mfd/rohm-bd70528.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mfd/rohm-bd70528.h +1 -1
index 1013e60c5b25..b0109ee6dae2 100644
@@ -317,7 +317,7 @@ enum {
 #define BD70528_MASK_RTC_MINUTE		0x7f
 #define BD70528_MASK_RTC_HOUR_24H	0x80
 #define BD70528_MASK_RTC_HOUR_PM	0x20
-#define BD70528_MASK_RTC_HOUR		0x1f
+#define BD70528_MASK_RTC_HOUR		0x3f
 #define BD70528_MASK_RTC_DAY		0x3f
 #define BD70528_MASK_RTC_WEEK		0x07
 #define BD70528_MASK_RTC_MONTH		0x1f
Signature · 14 lines
2.21.0


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 
#1 lore raw

Hello Lee, Alexandre, Greg & Sasha

Quoted 14 lines · Matti Vaittinen

When RTC is used in 24H mode (and it is by this driver) the maximum hour value is 24 in BCD. This occupies bits [5:0] - which means correct mask for HOUR register is 0x3f not 0x1f. Fix the mask

Fixes 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528

RTC")

---

I just noticed this was never applied. I'd like to get this in as we currently have bd70528 RTC not working in few exiting releases. (Or it works as long as time is not set at the evening :/)

Quoted 8 lines

I think this once was in RTC tree but was dropped as Lee mentioned this
belongs to MFD. Thus I dared to add the Alexandre's acked-by - please let me know if this is not Ok.

Lee, can you please pull this in so that we get the fix in-tree? I guess the fixes tag helps this to be included in some existing branches.

Actually - I don't know if applying this in MFD is good idea. The BD71828 support series

(
https://lore.kernel.org/lkml/[email protected]/
)

will fix this when applied (and conflict with this if both are applied). I would like to get this fix in 5.4 though - but I don't think the BD71828 series should be in 5.4.

Is it possible to get this in 5.4 stable - while leaving this out of current MFD tree and applying the BD71828 series to MFD?

Quoted 22 lines
 include/linux/mfd/rohm-bd70528.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mfd/rohm-bd70528.h +1 -1
index 1013e60c5b25..b0109ee6dae2 100644
@@ -317,7 +317,7 @@ enum {
 #define BD70528_MASK_RTC_MINUTE		0x7f
 #define BD70528_MASK_RTC_HOUR_24H	0x80
 #define BD70528_MASK_RTC_HOUR_PM	0x20
-#define BD70528_MASK_RTC_HOUR		0x1f
+#define BD70528_MASK_RTC_HOUR		0x3f
 #define BD70528_MASK_RTC_DAY		0x3f
 #define BD70528_MASK_RTC_WEEK		0x07
 #define BD70528_MASK_RTC_MONTH		0x1f
Signature · 1 line
2.21.0
#2 lore raw
Quoted 33 lines · Matti

Hello Lee, Alexandre, Greg & Sasha

Quoted 14 lines · Matti Vaittinen

When RTC is used in 24H mode (and it is by this driver) the maximum hour value is 24 in BCD. This occupies bits [5:0] - which means correct mask for HOUR register is 0x3f not 0x1f. Fix the mask

Fixes 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528

RTC")

---

I just noticed this was never applied. I'd like to get this in as we currently have bd70528 RTC not working in few exiting releases. (Or it works as long as time is not set at the evening :/)

Quoted 8 lines

I think this once was in RTC tree but was dropped as Lee mentioned this
belongs to MFD. Thus I dared to add the Alexandre's acked-by - please let me know if this is not Ok.

Lee, can you please pull this in so that we get the fix in-tree? I guess the fixes tag helps this to be included in some existing branches.

Actually - I don't know if applying this in MFD is good idea. The BD71828 support series

(
https://lore.kernel.org/lkml/[email protected]/
)

Quoted 6 lines

will fix this when applied (and conflict with this if both are applied). I would like to get this fix in 5.4 though - but I don't think the BD71828 series should be in 5.4.

Is it possible to get this in 5.4 stable - while leaving this out of current MFD tree and applying the BD71828 series to MFD?

We only take patches that are in Linus's tree for the stable tree, unless there are very big reasons not to do so (i.e. it is totally rewritten in a different way there.)

Once the change/fix is in Linus's tree, then you can backport it to stable in a different way if you want, but you need to give lots of reasons why it is done that way.

thanks,

greg k-h

#3 lore raw
Quoted 6 lines · On Fri, 2020-01-17 at 08:57 +0100, [email protected] wrote:
Quoted 4 lines · Matti

Is it possible to get this in 5.4 stable - while leaving this out of
current MFD tree and applying the BD71828 series to MFD?

Quoted 7 lines

We only take patches that are in Linus's tree for the stable tree, unless there are very big reasons not to do so (i.e. it is totally rewritten in a different way there.)

Once the change/fix is in Linus's tree, then you can backport it to stable in a different way if you want, but you need to give lots of reasons why it is done that way.

Right. Thanks for the explanation Greg. I have no _strong_ reasons - which means I'll split the RTC support patch in BD71828 series into two
- first of the patches being this fix, second being the BD71828 support. Then this fix can be taken in 5.4 after it has been merged to Linus' tree - the BD71828 support can be omitted from 5.4

I hope the BD71828 series could still make it to next release - but if it wont, then it might be in next after that :]

Lee, please skip this one, I'll do v10 of the BD71828 series where this fix is included as separate fix-patch.

Regards
Matti

#4 lore raw
Quoted 22 lines · Matti
Quoted 6 lines · On Fri, 2020-01-17 at 08:57 +0100, [email protected] wrote:
Quoted 4 lines · Matti

Is it possible to get this in 5.4 stable - while leaving this out of
current MFD tree and applying the BD71828 series to MFD?

Quoted 7 lines

We only take patches that are in Linus's tree for the stable tree, unless there are very big reasons not to do so (i.e. it is totally rewritten in a different way there.)

Once the change/fix is in Linus's tree, then you can backport it to stable in a different way if you want, but you need to give lots of reasons why it is done that way.

Right. Thanks for the explanation Greg. I have no _strong_ reasons - which means I'll split the RTC support patch in BD71828 series into two
- first of the patches being this fix, second being the BD71828 support. Then this fix can be taken in 5.4 after it has been merged to Linus' tree - the BD71828 support can be omitted from 5.4

Quoted 5 lines

I hope the BD71828 series could still make it to next release - but if it wont, then it might be in next after that :]

Lee, please skip this one, I'll do v10 of the BD71828 series where this fix is included as separate fix-patch.

Will look out for it.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#5 lore raw
Quoted 35 lines · Lee Jones
Quoted 33 lines · Matti
Quoted 12 lines · On Fri, 2020-01-17 at 08:57 +0100, [email protected] wrote:
Quoted 4 lines · Matti

Is it possible to get this in 5.4 stable - while leaving this out
of
current MFD tree and applying the BD71828 series to MFD?

We only take patches that are in Linus's tree for the stable tree,
unless there are very big reasons not to do so (i.e. it is totally
rewritten in a different way there.)

Quoted 5 lines

Once the change/fix is in Linus's tree, then you can backport it to
stable in a different way if you want, but you need to give lots of
reasons why it is done that way.

Right. Thanks for the explanation Greg. I have no _strong_ reasons -
which means I'll split the RTC support patch in BD71828 series into two
- first of the patches being this fix, second being the BD71828 support. Then this fix can be taken in 5.4 after it has been merged to
Linus' tree - the BD71828 support can be omitted from 5.4

I hope the BD71828 series could still make it to next release - but if
it wont, then it might be in next after that :]

Quoted 6 lines
Quoted 3 lines

Lee, please skip this one, I'll do v10 of the BD71828 series where this
fix is included as separate fix-patch.

Will look out for it.

Thanks! It should be on it's way through the mail servers :]

Br,
Matti Vaittinen