Skip to contentSkip to conversation

imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info()

PATCH New Alifer Moraes 3 participants 3 messages Jan 16, 2020 – Jan 20, 2020 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info()

detail_board_ddr_info() is not used anywhere, so simply remove it.

This function is only used by Layerscape, not by i.MX.

This was detected by the following sparse warning:

board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no previous prototype for ‘detail_board_ddr_info’ [-Wmissing-prototypes]

---
 board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c | 5 -----
 1 file changed, 5 deletions(-)
board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c +0 -5
index 2f97d5ce96..8bcbcc0e3f 100644
@@ -107,11 +107,6 @@ int board_init(void)
 	return 0;
 }
 
-void detail_board_ddr_info(void)
-{
-	puts("\nDDR    ");
-}
-
 /*
  * Board specific reset that is system reset.
  */
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/5 imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info()

Quoted 10 lines · Alifer Moraes

detail_board_ddr_info() is not used anywhere, so simply remove it.

This function is only used by Layerscape, not by i.MX.

This was detected by the following sparse warning:

board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no previous prototype for ‘detail_board_ddr_info’ [-Wmissing-prototypes]

#2 lore raw

PATCH 1/5 imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info()

In reply to Alifer Moraes
Quoted 7 lines

detail_board_ddr_info() is not used anywhere, so simply remove it. This function is only used by Layerscape, not by i.MX.
This was detected by the following sparse warning:
board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no previous prototype for ‘detail_board_ddr_info’ [-Wmissing-prototypes]

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================