Skip to contentSkip to conversation

generic: require fibmap for testcases using filefrag

PATCH In review Murphy Zhou 3 participants 7 messages Jan 17, 2020 – Jan 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic: require fibmap for testcases using filefrag

To mute false alarm on NFS, which is reporting FIBMAP unsupported.

---
 tests/generic/516 | 1 +
 tests/generic/540 | 1 +
 tests/generic/541 | 1 +
 tests/generic/542 | 1 +
 tests/generic/543 | 1 +
 tests/generic/578 | 1 +
 6 files changed, 6 insertions(+)
tests/generic/516 +1 -0
index ceaa4151..906e38ec 100755
@@ -31,6 +31,7 @@ _cleanup()
 # real QA test starts here
 _supported_os Linux
 _require_test_dedupe
+_require_fibmap
 
 rm -f $seqres.full
 
tests/generic/540 +1 -0
index dc4d9485..242ab805 100755
@@ -40,6 +40,7 @@ _cleanup()
 _supported_os Linux
 _supported_fs generic
 _require_scratch_reflink
+_require_fibmap
 _require_xfs_io_command "falloc"
 
 rm -f $seqres.full
tests/generic/541 +1 -0
index fcb5d567..ec7ed52a 100755
@@ -40,6 +40,7 @@ _cleanup()
 _supported_os Linux
 _supported_fs generic
 _require_scratch_reflink
+_require_fibmap
 _require_xfs_io_command "falloc"
 
 rm -f $seqres.full
tests/generic/542 +1 -0
index 62b32cb5..62fc55ea 100755
@@ -40,6 +40,7 @@ _cleanup()
 _supported_os Linux
 _supported_fs generic
 _require_scratch_reflink
+_require_fibmap
 _require_xfs_io_command "falloc"
 
 rm -f $seqres.full
tests/generic/543 +1 -0
index cc7ee532..75c2f7ef 100755
@@ -40,6 +40,7 @@ _cleanup()
 _supported_os Linux
 _supported_fs generic
 _require_scratch_reflink
+_require_fibmap
 _require_xfs_io_command "falloc"
 
 rm -f $seqres.full
tests/generic/578 +1 -0
index 798cccf0..6e160142 100755
@@ -29,6 +29,7 @@ _cleanup()
 # real QA test starts here
 _supported_os Linux
 _supported_fs generic
+_require_fibmap
 _require_test_program "mmap-write-concurrent"
 _require_command "$FILEFRAG_PROG" filefrag
 _require_test_reflink
Signature · 1 line
2.20.1
#1 lore raw
Quoted 1 line · Murphy Zhou

To mute false alarm on NFS, which is reporting FIBMAP unsupported.

How do these tests end up using FIBMAP? We really should not use FIBMAP in any tests except those exercising FIBMAP itself.

#2 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 1 line · Murphy Zhou

To mute false alarm on NFS, which is reporting FIBMAP unsupported.

How do these tests end up using FIBMAP? We really should not use FIBMAP in any tests except those exercising FIBMAP itself.

Through filefrag(8)?

#3 lore raw
Quoted 8 lines · Murphy Zhou
Quoted 6 lines · Christoph Hellwig
Quoted 1 line · Murphy Zhou

To mute false alarm on NFS, which is reporting FIBMAP unsupported.

How do these tests end up using FIBMAP? We really should not use FIBMAP in any tests except those exercising FIBMAP itself.

Through filefrag(8)?

But do those tests require filefrag -B??

--D

#4 lore raw
Quoted 11 lines · Darrick J. Wong
Quoted 8 lines · Murphy Zhou
Quoted 6 lines · Christoph Hellwig
Quoted 1 line · Murphy Zhou

To mute false alarm on NFS, which is reporting FIBMAP unsupported.

How do these tests end up using FIBMAP? We really should not use FIBMAP in any tests except those exercising FIBMAP itself.

Through filefrag(8)?

But do those tests require filefrag -B??

Not really. But filefrag will fall back to use fibmap.

Quoted 2 lines

--D

#5 lore raw
Quoted 3 lines · Murphy Zhou
Quoted 1 line

But do those tests require filefrag -B??

Not really. But filefrag will fall back to use fibmap.

But that means it requires either FIEMAP or FIBMAP, and your patch will cause regressions for file systems only implementing FIEMAP. So the fix isn't to ask for FIBMAP, but to implement FIEMAP in any file system missing that support.

#6 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 3 lines · Murphy Zhou
Quoted 1 line

But do those tests require filefrag -B??

Not really. But filefrag will fall back to use fibmap.

But that means it requires either FIEMAP or FIBMAP, and your patch will cause regressions for file systems only implementing FIEMAP. So the fix isn't to ask for FIBMAP, but to implement FIEMAP in any file system missing that support.

Hmm, you are right :-)