Skip to contentSkip to conversation

sh: sh4a: Bring back tmu3_device early device

PATCH Superseded Krzysztof Kozlowski 2 participants 2 messages Jan 18, 2020 SuperH

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 sh: sh4a: Bring back tmu3_device early device

Commit 1399c195ef50 ("sh: Switch to new style TMU device") converted tmu3_device platform device to new style of platform data but removed it from sh7786_early_devices array effectively removing last three timers and causing a warning:

arch/sh/kernel/cpu/sh4a/setup-sh7786.c:243:31:
warning: ‘tmu3_device’ defined but not used [-Wunused-variable]

Fixes 1399c195ef50 ("sh: Switch to new style TMU device")

---

Changes since v1:
1. Add tmu3_device to early device list, as suggested by Geert.
2. Add Fixes tag.

---
 arch/sh/kernel/cpu/sh4a/setup-sh7786.c | 1 +
 1 file changed, 1 insertion(+)
arch/sh/kernel/cpu/sh4a/setup-sh7786.c +1 -0
index 4b0db8259e3d..74620f30b19b 100644
@@ -391,6 +391,7 @@ static struct platform_device *sh7786_early_devices[] __initdata = {
 	&tmu0_device,
 	&tmu1_device,
 	&tmu2_device,
+	&tmu3_device,
 };
 
 static struct platform_device *sh7786_devices[] __initdata = {
Signature · 1 line
2.17.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · Krzysztof Kozlowski

Commit 1399c195ef50 ("sh: Switch to new style TMU device") converted tmu3_device platform device to new style of platform data but removed it from sh7786_early_devices array effectively removing last three timers and causing a warning:

arch/sh/kernel/cpu/sh4a/setup-sh7786.c:243:31:
warning: ‘tmu3_device’ defined but not used [-Wunused-variable]

Fixes 1399c195ef50 ("sh: Switch to new style TMU device")

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds