rseq fixes
Subsystems (2)
Linus,
Please pull the latest core-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-urgent-for-linus
# HEAD: 463f550fb47bede3a5d7d5177f363a6c3b45d50b rseq: Unregister rseq for clone CLONE_VM
This tree contains two rseq bugfixes:
- CLONE_VM !CLONE_THREAD didn't work properly, the kernel would end up corrupting the TLS of the parent. Technically a change in the ABI but the previous behavior couldn't resonably have been relied on by applications so this looks like a valid exception to the ABI rule.
- Make the RSEQ_FLAG_UNREGISTER ABI behavior consistent with the handling of other flags. This is not thought to impact any applications either.
( Of course both are only one contrary regression report away from being
reverted. )
Thanks,
Ingo
------------------>
Mathieu Desnoyers (2):
rseq: Reject unknown flags on rseq unregister
rseq: Unregister rseq for clone CLONE_VM
include/linux/sched.h | 4 ++-- kernel/rseq.c | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-)
include/linux/sched.h +2 -2
@@ -1929,11 +1929,11 @@ static inline void rseq_migrate(struct task_struct *t)/* * If parent process has a registered restartable sequences area, the -* child inherits. Only applies when forking a process, not a thread. +* child inherits. Unregister rseq for a clone with CLONE_VM set. */ static inline void rseq_fork (struct task_struct *t,unsigned long clone_flags) { -if (clone_flags &CLONE_THREAD ) { +if (clone_flags &CLONE_VM ) { t->rseq =NULL ; t->rseq_sig =0 ; t->rseq_event_mask =0 ;
kernel/rseq.c +2 -0
@@ -310,6 +310,8 @@ SYSCALL_DEFINE4(rseq, struct rseq __user *, rseq, u32, rseq_len,int ret;if (flags &RSEQ_FLAG_UNREGISTER ) { +if (flags & ~RSEQ_FLAG_UNREGISTER ) +return -EINVAL ;/* Unregister rseq for current thread. */ if (current->rseq != rseq || !current->rseq)return -EINVAL ;
The pull request you sent on Sat, 18 Jan 2020 18:11:16 +0100:
The pull request you sent on Sat, 18 Jan 2020 18:11:16 +0100:
Quoted 1 line
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.gitcore-urgent-for-linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/ba0f47220384ff160c9df93dedbbef26d7b67f7b
Thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker