Skip to contentSkip to conversation

Staging: comedi: usbdux: cleanup long line and align it

PATCH In review Simon Fong 3 participants 4 messages Jan 19, 2020 Staging

lore
Share & tools
lore

Simon Fong

author
#0 lore raw

PATCH 3/3 Staging: comedi: usbdux: cleanup long line and align it

Clean up long line and align it

---
 drivers/staging/comedi/drivers/usbdux.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/usbdux.c +2 -1
index 0350f303d557..b9c0b1a1d86e 100644
@@ -204,7 +204,8 @@ struct usbdux_private {
 	struct mutex mut;
 };
 
-static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)
+static void usbdux_unlink_urbs(struct urb **urbs,
+			       int num_urbs)
 {
 	int i;
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · Simon Fong

Clean up long line and align it

[]

drivers/staging/comedi/drivers/usbdux.c

Quoted 1 line
drivers/staging/comedi/drivers/usbdux.c +0 -0

[]

drivers/staging/comedi/drivers/usbdux.c struct usbdux_private { · line 207

Quoted 5 lines
drivers/staging/comedi/drivers/usbdux.c +0 -1
@@ -204,7 +204,8 @@ struct usbdux_private {
 	struct mutex mut;
 };
 
-static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)

Why do you believe this to be a long line?
It's only 63 characters.

1 2 3 4 5 6 7
1234567890123456789012345678901234567890123456789012345678901234567890

static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)

Quoted 5 lines
drivers/staging/comedi/drivers/usbdux.c +2 -0
+static void usbdux_unlink_urbs(struct urb **urbs,
+			       int num_urbs)
 {
 	int i;
 
maintainer
#2 lore raw
In reply to Simon Fong
Quoted 12 lines · Simon Fong

Clean up long line and align it

---
 drivers/staging/comedi/drivers/usbdux.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/usbdux.c +0 -0
index 0350f303d557..b9c0b1a1d86e 100644

drivers/staging/comedi/drivers/usbdux.c struct usbdux_private { · line 208

Quoted 6 lines
drivers/staging/comedi/drivers/usbdux.c +2 -1
@@ -204,7 +204,8 @@ struct usbdux_private {
 	struct mutex mut;
 };
 
-static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)
+static void usbdux_unlink_urbs(struct urb **urbs,
+			       int num_urbs)

As Joe said, there is no reason to change this line that I can see, why do you want to do that?

greg k-h

maintainer
#3 lore raw
Quoted 16 lines · Greg KH
Quoted 15 lines · Simon Fong

Clean up long line and align it

---
 drivers/staging/comedi/drivers/usbdux.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/usbdux.c +0 -0
index 0350f303d557..b9c0b1a1d86e 100644
@@ -204,7 +204,8 @@ struct usbdux_private {
 	struct mutex mut;
 };
 
Quoted 6 lines

drivers/staging/comedi/drivers/usbdux.c struct usbdux_private { · line 208

Quoted 3 lines
drivers/staging/comedi/drivers/usbdux.c +2 -1
-static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)
+static void usbdux_unlink_urbs(struct urb **urbs,
+			       int num_urbs)

As Joe said, there is no reason to change this line that I can see, why do you want to do that?

Also, where are patches 1 and 2 of this 3 patch series?

thanks,

greg k-h