Skip to contentSkip to conversation

python-beautifulsoup4: fix target RDEPENDS

PATCH In review Tim Orling 2 participants 3 messages Jan 19, 2020 – Jan 20, 2020

lore
Share & tools
lore

Tim Orling

author
#0 lore raw

PATCH 1/1 python-beautifulsoup4: fix target RDEPENDS

* target has run-time dependencies on:
- python-html
- python-logging

Unexpectedly, class-target += override is wiping out RDEPENDS_${PN}, so explicitly add the rest of the run-time dependencies (python-html5lib, python-lxml, python-soupsieve).

---
 recipes-devtools/python/python-beautifulsoup4_4.8.1.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)
recipes-devtools/python/python-beautifulsoup4_4.8.1.bb +10 -0
index 86482714..8ac9c8c5 100644
@@ -19,4 +19,14 @@ RDEPENDS_${PN} = "\
     ${PYTHON_PN}-soupsieve \
 "
 
+# class override, which is not
+# inheriting from above (FIXME?)
+RDEPENDS_${PN}_class-target += "\
+    ${PYTHON_PN}-html \
+    ${PYTHON_PN}-html5lib \
+    ${PYTHON_PN}-logging \
+    ${PYTHON_PN}-lxml \
+    ${PYTHON_PN}-soupsieve \
+"
+
 BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.25.0
#1 lore raw
Quoted 3 lines · Tim Orling

* target has run-time dependencies on:
- python-html
- python-logging

Any reason -native doesn't depend on those?

Quoted 4 lines

Unexpectedly, class-target += override is wiping out RDEPENDS_${PN}, so explicitly add the rest of the run-time dependencies (python-html5lib, python-lxml, python-soupsieve).

This is expected, you should instead do:

RDEPENDS_${PN}_append_class-target = "\
    ${PYTHON_PN}-html \
    ${PYTHON_PN}-logging"

So as to avoid duplication and having to maintain two distinct lists.

Cheers,
Andre'

Quoted 28 lines
---
 recipes-devtools/python/python-beautifulsoup4_4.8.1.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)
recipes-devtools/python/python- renamed from recipes-devtools/python/python-beautifulsoup4_4.8.1.bb +0 -0

beautifulsoup4_4.8.1.bb
index 86482714..8ac9c8c5 100644

recipes-devtools/python/python-beautifulsoup4_4.8.1.bb +10 -0
@@ -19,4 +19,14 @@ RDEPENDS_${PN} = "\
     ${PYTHON_PN}-soupsieve \
 
+# class override, which is not
+# inheriting from above (FIXME?)
+RDEPENDS_${PN}_class-target += "\
+    ${PYTHON_PN}-html \
+    ${PYTHON_PN}-html5lib \
+    ${PYTHON_PN}-logging \
+    ${PYTHON_PN}-lxml \
+    ${PYTHON_PN}-soupsieve \
+"
+
 BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.25.0
author
#2 lore raw
Quoted 6 lines · André Draszik
Quoted 3 lines · Tim Orling

* target has run-time dependencies on:
- python-html
- python-logging

Any reason -native doesn't depend on those?

These are part of the package splitting OE does for python. They are normally part of a full python installation in distros that don’t care about space. For python-native environment, there is no package splitting and these would not exist as -native variants.

Quoted 7 lines
Quoted 6 lines

Unexpectedly, class-target += override is wiping out RDEPENDS_${PN}, so explicitly add the rest of the run-time dependencies (python-html5lib, python-lxml, python-soupsieve).

Quoted 6 lines

This is expected, you should instead do:

RDEPENDS_${PN}_append_class-target = "\
    ${PYTHON_PN}-html \
    ${PYTHON_PN}-logging"

Facepalm. I had tried it with append after class-target, which clearly doesn’t work and my brain was getting tired. I’ll clean it up today. Thank you for the catch.

So as to avoid duplication and having to maintain two distinct lists.

Quoted 36 lines

Cheers,
Andre'

Review

Quoted 7 lines
---
 recipes-devtools/python/python-beautifulsoup4_4.8.1.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)
(quoted diff) +0 -0

b/recipes-devtools/python/python-

Quoted 21 lines

beautifulsoup4_4.8.1.bb
index 86482714..8ac9c8c5 100644

recipes-devtools/python/python-beautifulsoup4_4.8.1.bb +10 -1
@@ -19,4 +19,14 @@ RDEPENDS_${PN} = "\
     ${PYTHON_PN}-soupsieve \
 
+# class override, which is not
+# inheriting from above (FIXME?)
+RDEPENDS_${PN}_class-target += "\
+    ${PYTHON_PN}-html \
+    ${PYTHON_PN}-html5lib \
+    ${PYTHON_PN}-logging \
+    ${PYTHON_PN}-lxml \
+    ${PYTHON_PN}-soupsieve \
+"
+
 BBCLASSEXTEND = "native nativesdk"
--

2.25.0