Skip to contentSkip to conversation

mmc: sdhci-of-esdhc: fix serious issue clock is always disabled

PATCH In review Yangbo Lu 2 participants 2 messages Jan 20, 2020

Subsystems (2)
lore
Share & tools
lore

Yangbo Lu

author
#0 lore raw

PATCH 1/1 mmc: sdhci-of-esdhc: fix serious issue clock is always disabled

This patch is to fix a serious issue that clock is always disabled in esdhc_of_set_clock().

Fixes 1b21a701aed9 ("mmc: sdhci-of-esdhc: fix clock setting for different controller versions")
---
 drivers/mmc/host/sdhci-of-esdhc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-of-esdhc.c +1 -1
index 8c06017..2950ae2 100644
@@ -745,7 +745,7 @@ static void esdhc_of_set_clock(struct sdhci_host *host, unsigned int clock)
 		esdhc_clock_enable(host, false);
 		esdhc_flush_async_fifo(host);
 	}
-	esdhc_clock_enable(host, false);
+	esdhc_clock_enable(host, true);
 }
 
 static void esdhc_pltfm_set_bus_width(struct sdhci_host *host, int width)
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · Yangbo Lu

This patch is to fix a serious issue that clock is always disabled in esdhc_of_set_clock().

Fixes 1b21a701aed9 ("mmc: sdhci-of-esdhc: fix clock setting for different controller versions")

Applied for next, thanks!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/sdhci-of-esdhc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-of-esdhc.c +1 -2
index 8c06017..2950ae2 100644
@@ -745,7 +745,7 @@ static void esdhc_of_set_clock(struct sdhci_host *host, unsigned int clock)
                esdhc_clock_enable(host, false);
                esdhc_flush_async_fifo(host);
        }
-       esdhc_clock_enable(host, false);
+       esdhc_clock_enable(host, true);
 }
 
 static void esdhc_pltfm_set_bus_width(struct sdhci_host *host, int width)
--

2.7.4