block, bfq: improve arithmetic division in bfq_delta()
Subsystems (2)
PATCH 1/1 block, bfq: improve arithmetic division in bfq_delta()
do_div() does a 64-by-32 division. Use div64_ul() instead of it if the divisor is unsigned long, to avoid truncation to 32-bit. And as a nice side effect also cleans up the function a bit.
Signed-off-by Wen Yang <[email protected]>
Cc Paolo Valente <[email protected]>
Cc Jens Axboe <[email protected]>
--- block/bfq-wf2q.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
block/bfq-wf2q.c +1 -4
@@ -277,10 +277,7 @@ struct bfq_queue *bfq_entity_to_bfqq(struct bfq_entity *entity)*/ static u64 bfq_delta (unsigned long service,unsigned long weight) { -u64 d = (u64 )service <<WFQ_SERVICE_SHIFT ; - -do_div (d, weight); -return d; +return div64_ul ((u64 )service <<WFQ_SERVICE_SHIFT , weight); }/**
Signature · 1 line
2.23.0
Jens Axboe
AppliedQuoted 3 lines · Wen Yang
do_div()does a 64-by-32 division. Usediv64_ul()instead of it if the divisor is unsigned long, to avoid truncation to 32-bit. And as a nice side effect also cleans up the function a bit.
Applied, thanks.
Signature · 1 line
Jens Axboe