Skip to contentSkip to conversation

python-beautifulsoup4: fix target RDEPENDS syntax

PATCH New Tim Orling 1 participant 2 messages Jan 20, 2020

lore
Share & tools
lore

Tim Orling

author
#0 lore raw

PATCH 1/2 python-beautifulsoup4: fix target RDEPENDS syntax

Thanks to review by André Draszik, the syntax that was eluding me in prior patch is now corrected.

NOTE: -native,-nativesdk recipes have the full build of python2 at their disposal, including all modules. For target builds, we need to include the packages-split modules that are produced by the OE python manifest.

Fixes 417762c0 python-beautifulsoup4: fix target RDEPENDS
---
 recipes-devtools/python/python-beautifulsoup4_4.8.2.bb | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
recipes-devtools/python/python-beautifulsoup4_4.8.2.bb +1 -6
index 821e5c2c..9f9065e2 100644
@@ -19,14 +19,9 @@ RDEPENDS_${PN} = "\
     ${PYTHON_PN}-soupsieve \
 "
 
-# class override, which is not
-# inheriting from above (FIXME?)
-RDEPENDS_${PN}_class-target += "\
+RDEPENDS_${PN}_append_class-target = "\
     ${PYTHON_PN}-html \
-    ${PYTHON_PN}-html5lib \
     ${PYTHON_PN}-logging \
-    ${PYTHON_PN}-lxml \
-    ${PYTHON_PN}-soupsieve \
 "
 
 BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.25.0
author
#1 lore raw

PATCH 2/2 python-parse: fix target RDEPENDS

Missing run-time dependency on:
- python-numbers (decimal)

Move RDEPENDS to _append_class-target in case -native,-nativesdk is desired in the future.

---
 recipes-devtools/python/python-parse_1.14.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
recipes-devtools/python/python-parse_1.14.0.bb +2 -1
index 6e03d4b8..1fd51163 100644
@@ -8,7 +8,8 @@ SRC_URI[sha256sum] = "95a4f4469e37c57b5e924629ac99926f28bee7da59515dc5b8078c4c3e
 
 inherit pypi setuptools
 
-RDEPENDS_${PN} += "\
+RDEPENDS_${PN}_append_class-target = "\
     ${PYTHON_PN}-datetime \
     ${PYTHON_PN}-logging \
+    ${PYTHON_PN}-numbers \
     "
Signature · 1 line
2.25.0