bpf: btf: Always output invariant hit in pahole DWARF to BTF transform
Subsystems (4)
PATCH v2 1/1 bpf: btf: Always output invariant hit in pahole DWARF to BTF transform
When trying to compile with CONFIG_DEBUG_INFO_BTF enabled, I got this error:
% make -s
Failed to generate BTF for vmlinux
Try to disable CONFIG_DEBUG_INFO_BTF
make[3]: *** [vmlinux] Error 1
Compiling again without -s shows the true error (that pahole is missing), but since this is fatal, we should show the error unconditionally on stderr as well, not silence it using the info function. With this patch:
% make -s
BTF: .tmp_vmlinux.btf: pahole (pahole) is not available Failed to generate BTF for vmlinux
Try to disable CONFIG_DEBUG_INFO_BTF
make[3]: *** [vmlinux] Error 1
--- scripts/link-vmlinux.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/link-vmlinux.sh +2 -2
@@ -108,13 +108,13 @@ gen_btf() local bin_arch if ! [ -x "$(command -v ${PAHOLE})" ]; then - info "BTF" "${1}: pahole (${PAHOLE}) is not available" + echo >&2 "BTF: ${1}: pahole (${PAHOLE}) is not available" return 1 fi pahole_ver=$(${PAHOLE} --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') if [ "${pahole_ver}" -lt "113" ]; then - info "BTF" "${1}: pahole version $(${PAHOLE} --version) is too old, need at least v1.13" + echo >&2 "BTF: ${1}: pahole version $(${PAHOLE} --version) is too old, need at least v1.13" return 1 fi
Signature · 1 line
2.25.0
Quoted 28 lines · Chris Down
When trying to compile with
CONFIG_DEBUG_INFO_BTFenabled, I got this error:% make -s
Failed to generate BTF for vmlinux
Try to disableCONFIG_DEBUG_INFO_BTF
make[3]: *** [vmlinux] Error 1Compiling again without -s shows the true error (that pahole is missing), but since this is fatal, we should show the error unconditionally on stderr as well, not silence it using the
infofunction. With this patch:% make -s
BTF: .tmp_vmlinux.btf: pahole (pahole) is not available Failed to generate BTF for vmlinux
Try to disableCONFIG_DEBUG_INFO_BTF
make[3]: *** [vmlinux] Error 1Signed-off-by Chris Down <[email protected]>Cc Stanislav Fomichev <[email protected]>Cc Andrii Nakryiko <[email protected]>Cc John Fastabend <[email protected]>
Quoted 4 lines
--- scripts/link-vmlinux.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Looks great, thanks!
Quoted 23 lines
scripts/link-vmlinux.sh +2
-3@@ -108,13 +108,13 @@ gen_btf() local bin_arch if ! [ -x "$(command -v ${PAHOLE})" ]; then - info "BTF" "${1}: pahole (${PAHOLE}) is not available" + echo >&2 "BTF: ${1}: pahole (${PAHOLE}) is not available" return 1 fi pahole_ver=$(${PAHOLE} --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') if [ "${pahole_ver}" -lt "113" ]; then - info "BTF" "${1}: pahole version $(${PAHOLE} --version) is too old, need at least v1.13" + echo >&2 "BTF: ${1}: pahole version $(${PAHOLE} --version) is too old, need at least v1.13" return 1 fi --2.25.0
Quoted 19 lines · Chris Down
When trying to compile with
CONFIG_DEBUG_INFO_BTFenabled, I got this error:% make -s
Failed to generate BTF for vmlinux
Try to disableCONFIG_DEBUG_INFO_BTF
make[3]: *** [vmlinux] Error 1Compiling again without -s shows the true error (that pahole is missing), but since this is fatal, we should show the error unconditionally on stderr as well, not silence it using the
infofunction. With this patch:% make -s
BTF: .tmp_vmlinux.btf: pahole (pahole) is not available Failed to generate BTF for vmlinux
Try to disableCONFIG_DEBUG_INFO_BTF
make[3]: *** [vmlinux] Error 1
Quoted 8 lines
Signed-off-by Chris Down <[email protected]>Cc Stanislav Fomichev <[email protected]>Cc Andrii Nakryiko <[email protected]>Cc John Fastabend <[email protected]>
Applied, thanks!