Skip to contentSkip to conversation

package/erlang-p1-xmpp: fix host build

PATCH New Johan Oudinet 2 participants 3 messages Jan 22, 2020 – Feb 10, 2020

lore
Share & tools
lore

Johan Oudinet

author
#0 lore raw

PATCH 1/1 package/erlang-p1-xmpp: fix host build

Fixes:
http://autobuild.buildroot.net/results/3e594350131994df53b20d5113fefbba2e747836

Signed-off-by Johan Oudinet <[email protected]>
---
 package/erlang-p1-xmpp/erlang-p1-xmpp.mk | 1 +
 1 file changed, 1 insertion(+)
package/erlang-p1-xmpp/erlang-p1-xmpp.mk +1 -0
index ced058731b..2f74c60df2 100644
@@ -11,6 +11,7 @@ ERLANG_P1_XMPP_LICENSE_FILES = LICENSE.txt
 ERLANG_P1_XMPP_INSTALL_STAGING = YES
 ERLANG_P1_XMPP_DEPENDENCIES = erlang-p1-xml erlang-p1-stringprep \
 	erlang-p1-tls erlang-p1-utils erlang-p1-zlib host-erlang-p1-xml
+HOST_ERLANG_P1_XMPP_DEPENDENCIES = host-erlang-p1-xml
 
 $(eval $(rebar-package))
 $(eval $(host-rebar-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/erlang-p1-xmpp: fix host build

Quoted 3 lines · On Wed, 22 Jan 2020 11:34:01 +0100 Johan Oudinet <[email protected]>…

Fixes:
http://autobuild.buildroot.net/results/3e594350131994df53b20d5113fefbba2e747836

Signed-off-by Johan Oudinet <[email protected]>

Thanks, I've applied, but I have a question below.

package/erlang-p1-xmpp/erlang-p1-xmpp.mk ERLANG_P1_XMPP_LICENSE_FILES = LICENSE.txt · line 14

Quoted 3 lines

ERLANG_P1_XMPP_DEPENDENCIES = erlang-p1-xml erlang-p1-stringprep \

package/erlang-p1-xmpp/erlang-p1-xmpp.mk +1 -0
 	erlang-p1-tls erlang-p1-utils erlang-p1-zlib host-erlang-p1-xml
+HOST_ERLANG_P1_XMPP_DEPENDENCIES = host-erlang-p1-xml

It is weird that there is no symmetry between the target dependencies and host dependencies. Why don't we have the same set of packages ?

Also, it is really normal/correct for the target variant to depend on host-erlang-p1-xml ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 package/erlang-p1-xmpp: fix host build

Quoted 10 lines · Thomas Petazzoni
Quoted 3 lines · On Wed, 22 Jan 2020 11:34:01 +0100 Johan Oudinet <[email protected]>…

ERLANG_P1_XMPP_DEPENDENCIES = erlang-p1-xml erlang-p1-stringprep \
erlang-p1-tls erlang-p1-utils erlang-p1-zlib host-erlang-p1-xml
+HOST_ERLANG_P1_XMPP_DEPENDENCIES = host-erlang-p1-xml

It is weird that there is no symmetry between the target dependencies and host dependencies. Why don't we have the same set of packages ?

I honestly don't know. I use this package only as a dependency of ejabberd. So I just check it compiles and ejabberd works correctly afterwards. This is far from perfect to test if the list of dependencies is correct.

Quoted 2 lines

Also, it is really normal/correct for the target variant to depend on host-erlang-p1-xml ?

I remember I had to add this host dependency to make the target variant compiles. I also think this is weird. I haven't tested recently to remove such dependency but I'll try to simplify the dependencies next time I bump the version of this package.

Signature · 1 line
Johan