clock_imx8mq: Delete not used init_usb_clk()
Subsystems (3)
PATCH v2 1/4 clock_imx8mq: Delete not used init_usb_clk()
Function init_usb_clk() is not used anywhere, so it can simply be deleted. This was detected by the following sparse warning:
arch/arm/mach-imx/imx8m/clock_imx8mq.c:377:6: warning: no previous prototype
for ‘init_usb_clk’ [-Wmissing-prototypes]
void init_usb_clk(void)
^~~~~~~~~~~~
---
Chages since v1:
- Fixed patch corruption
arch/arm/mach-imx/imx8m/clock_imx8mq.c | 22 ---------------------- 1 file changed, 22 deletions(-)
arch/arm/mach-imx/imx8m/clock_imx8mq.c +0 -22
@@ -374,28 +374,6 @@ void init_wdog_clk(void)clock_enable (CCGR_WDOG3 ,1 ); } -void init_usb_clk (void ) -{ -if (!is_usb_boot ()) { -clock_enable (CCGR_USB_CTRL1 ,0 ); -clock_enable (CCGR_USB_CTRL2 ,0 ); -clock_enable (CCGR_USB_PHY1 ,0 ); -clock_enable (CCGR_USB_PHY2 ,0 ); -/* 500MHz */ -clock_set_target_val (USB_BUS_CLK_ROOT ,CLK_ROOT_ON | -CLK_ROOT_SOURCE_SEL (1 )); -/* 100MHz */ -clock_set_target_val (USB_CORE_REF_CLK_ROOT ,CLK_ROOT_ON | -CLK_ROOT_SOURCE_SEL (1 )); -/* 100MHz */ -clock_set_target_val (USB_PHY_REF_CLK_ROOT ,CLK_ROOT_ON | -CLK_ROOT_SOURCE_SEL (1 )); -clock_enable (CCGR_USB_CTRL1 ,1 ); -clock_enable (CCGR_USB_CTRL2 ,1 ); -clock_enable (CCGR_USB_PHY1 ,1 ); -clock_enable (CCGR_USB_PHY2 ,1 ); - } -}void init_nand_clk (void ) {
Signature · 1 line
2.17.1
PATCH v2 1/4 clock_imx8mq: Delete not used init_usb_clk()
Quoted 6 lines · On Thu, 23 Jan 2020 10:20:14 -0300 Pedro Jardim jardim.c.pedro at gmail.com…
Function
init_usb_clk()is not used anywhere, so it can simply be deleted. This was detected by the following sparse warning:
arch/arm/mach-imx/imx8m/clock_imx8mq.c:377:6: warning: no previous prototype
for ‘init_usb_clk’ [-Wmissing-prototypes]
voidinit_usb_clk(void)
Cc'ing Peng. Maybe this was in preparation for adding USB support ?
--
Anatolij
Fabio Estevam
reviewerPATCH v2 1/4 clock_imx8mq: Delete not used init_usb_clk()
Hi Anatolij,
Quoted 4 lines · Anatolij Gustschin
On Thu, 23 Jan 2020 10:20:14 -0300
Pedro Jardim jardim.c.pedro at gmail.com wrote:
Quoted 8 lines
Quoted 6 lines
Function
init_usb_clk()is not used anywhere, so it can simply be deleted. This was detected by the following sparse warning:
arch/arm/mach-imx/imx8m/clock_imx8mq.c:377:6: warning: no previous prototype
for ‘init_usb_clk’ [-Wmissing-prototypes]
voidinit_usb_clk(void)Cc'ing Peng. Maybe this was in preparation for adding USB support ?
Unfortunately i.MX8M USB support has been pending for a long time.
I prefer if we could get rid of this unused code and then bring this back when USB support comes in.
PATCH v2 1/4 clock_imx8mq: Delete not used init_usb_clk()
Quoted 16 lines
Subject: Re: [PATCH v2 1/4]
clock_imx8mq: Delete not usedinit_usb_clk()Hi Anatolij,
Quoted 11 lines · Anatolij Gustschin
Quoted 6 lines · On Thu, 23 Jan 2020 10:20:14 -0300 Pedro Jardim jardim.c.pedro at gmail.com…
Function
init_usb_clk()is not used anywhere, so it can simply be deleted. This was detected by the following sparse warning:
arch/arm/mach-imx/imx8m/clock_imx8mq.c:377:6: warning: no previous prototype for ‘init_usb_clk’ [-Wmissing-prototypes] voidinit_usb_clk(void)
Quoted 6 lines
Quoted 1 line
Cc'ing Peng. Maybe this was in preparation for adding USB support ?
Unfortunately i.MX8M USB support has been pending for a long time.
I prefer if we could get rid of this unused code and then bring this back when USB support comes in.
Not sure whether TI guys have done the cadence USB support.
Previously Sherry did some usb work, but TI guys take over that.
After the usb IP support ready, I or someone could start support usb for i.MX8MQ.
For now, the function could be dropped.
Thanks,
Peng.
PATCH v2 1/4 clock_imx8mq: Delete not used init_usb_clk()
Quoted 26 lines · Peng Fan
Quoted 17 lines
Subject: Re: [PATCH v2 1/4]
clock_imx8mq: Delete not usedinit_usb_clk()Hi Anatolij,
Quoted 11 lines · Anatolij Gustschin
Quoted 6 lines · On Thu, 23 Jan 2020 10:20:14 -0300 Pedro Jardim jardim.c.pedro at gmail.com…
Function
init_usb_clk()is not used anywhere, so it can simply be deleted. This was detected by the following sparse warning:
arch/arm/mach-imx/imx8m/clock_imx8mq.c:377:6: warning: no previous prototype for ‘init_usb_clk’ [-Wmissing-prototypes] voidinit_usb_clk(void)Quoted 6 lines
Quoted 1 line
Cc'ing Peng. Maybe this was in preparation for adding USB support ?
Unfortunately i.MX8M USB support has been pending for a long time.
I prefer if we could get rid of this unused code and then bring this back when USB support comes in.
Not sure whether TI guys have done the cadence USB support.
Quoted 8 lines
Previously Sherry did some usb work, but TI guys take over that.
After the usb IP support ready, I or someone could start support usb for i.MX8MQ.
For now, the function could be dropped.
Thanks,
Peng.
I have a working port of the Linux usb phy driver for the iMX8MQ already. I think the only piece that is missing to use dwc3-generic for iMX8MQ is the common clk driver. Has anyone started work on this?
-Jon
Fabio Estevam
reviewerPATCH v2 1/4 clock_imx8mq: Delete not used init_usb_clk()
Quoted 3 lines · Jon Nettleton
I have a working port of the Linux usb phy driver for the iMX8MQ already. I think the only piece that is missing to use dwc3-generic for iMX8MQ is the common clk driver. Has anyone started work on this?
Not that I am aware of.
Peng, do you know?
PATCH v2 1/4 clock_imx8mq: Delete not used init_usb_clk()
Quoted 11 lines
Subject: Re: [PATCH v2 1/4]
clock_imx8mq: Delete not usedinit_usb_clk()Quoted 3 lines · Jon Nettleton
I have a working port of the Linux usb phy driver for the iMX8MQ already. I think the only piece that is missing to use dwc3-generic for iMX8MQ is the common clk driver. Has anyone started work on this?
Not that I am aware of.
Peng, do you know?
I have not start to do that.
Jon, great to know that you did that. Look forward your patches in community.
Thanks,
Peng.
PATCH v2 1/4 clock_imx8mq: Delete not used init_usb_clk()
In reply to Peng FanQuoted 16 lines · Peng Fan
Quoted 16 lines
Subject: Re: [PATCH v2 1/4]
clock_imx8mq: Delete not usedinit_usb_clk()Hi Anatolij,
Quoted 11 lines · Anatolij Gustschin
Quoted 6 lines · On Thu, 23 Jan 2020 10:20:14 -0300 Pedro Jardim jardim.c.pedro at gmail.com…
Function
init_usb_clk()is not used anywhere, so it can simply be deleted. This was detected by the following sparse warning:
arch/arm/mach-imx/imx8m/clock_imx8mq.c:377:6: warning: no previous prototype for ‘init_usb_clk’ [-Wmissing-prototypes] voidinit_usb_clk(void)
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Cc'ing Peng. Maybe this was in preparation for adding USB support ?
Unfortunately i.MX8M USB support has been pending for a long time.
I prefer if we could get rid of this unused code and then bring this back when USB support comes in.
Not sure whether TI guys have done the cadence USB support.
I guess you are talking about Cadence USB3 driver. Marek already merged the support. Please find the corresponding commits below:
f69257baa8 usb: composite: add BOS descriptor support to composite framework d80effb184 usb: gadget: Add gadget_is_cdns3() macroa9ca4193bd usb: cdns3: Add TI wrapper driver for CDNS USB3 controller 927c22b0da usb: cdns3: gadget: Implement udc_set_speed() callback 7e91f6ccdc usb: Add Cadence USB3 host and gadget driver 8d94e184ff usb: udc: Introduce ->udc_set_speed() method 77dcbdf3c1 usb: gadget: Add match_ep() op to usb_gadget_ops c93e305af7 bitmaps: import for_each_set_bit() macroc37f594280 list: import list_first_entry_or_null()
Thanks and regards,
Lokesh
Quoted 10 lines
Previously Sherry did some usb work, but TI guys take over that.
After the usb IP support ready, I or someone could start support usb for i.MX8MQ.
For now, the function could be dropped.
Thanks,
Peng.
PATCH v2 1/4 clock_imx8mq: Delete not used init_usb_clk()
Quoted 37 lines
Subject: Re: [PATCH v2 1/4]
clock_imx8mq: Delete not usedinit_usb_clk()Quoted 6 lines · Peng Fan
Quoted 6 lines
Subject: Re: [PATCH v2 1/4]
clock_imx8mq: Delete not usedinit_usb_clk()Hi Anatolij,
On Thu, Jan 23, 2020 at 11:43 AM Anatolij Gustschin <[email protected]>
Quoted 5 lines · wrote:
Quoted 5 lines
Quoted 5 lines
Quoted 1 line · On Thu, 23 Jan 2020 10:20:14 -0300 Pedro Jardim jardim.c.pedro at gmail.com…
Function
init_usb_clk()is not used anywhere, so it can simply bedeleted.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
This was detected by the following sparse warning:
arch/arm/mach-imx/imx8m/clock_imx8mq.c:377:6: warning: noprevious
Quoted 11 lines
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
prototype for ‘init_usb_clk’ [-Wmissing-prototypes] void
init_usb_clk(void)Cc'ing Peng. Maybe this was in preparation for adding USB support ?
Unfortunately i.MX8M USB support has been pending for a long time.
I prefer if we could get rid of this unused code and then bring this back when USB support comes in.
Not sure whether TI guys have done the cadence USB support.
I guess you are talking about Cadence USB3 driver. Marek already merged the support. Please find the corresponding commits below:
Quoted 10 lines
f69257baa8usb: composite: add BOS descriptor support to composite frameworkd80effb184usb: gadget: Addgadget_is_cdns3()macroa9ca4193bdusb:
cdns3: Add TI wrapper driver for CDNS USB3 controller927c22b0dausb:
cdns3: gadget: Implementudc_set_speed()callback7e91f6ccdcusb: Add Cadence USB3 host and gadget driver8d94e184ffusb: udc: Introduce ->udc_set_speed() method77dcbdf3c1usb: gadget: Addmatch_ep()op tousb_gadget_opsc93e305af7bitmaps: importfor_each_set_bit()macroc37f594280list: importlist_first_entry_or_null()
Great.
Then I think better keep the function.
Thanks,
Peng.
Quoted 15 lines
Thanks and regards,
LokeshQuoted 4 lines
Previously Sherry did some usb work, but TI guys take over that.
After the usb IP support ready, I or someone could start support usb for
i.MX8MQ.
Quoted 6 lines
For now, the function could be dropped.
Thanks,
Peng.