net: atm: use %*ph to print small buffer
Subsystems (3)
PATCH 1/1 net: atm: use %*ph to print small buffer
Use %*ph format to print small buffer as hex string.
Signed-off-by Andy Shevchenko <[email protected]>
--- net/atm/atm_sysfs.c | 22 +++++-------- net/atm/lec.c | 76 ++++++++++++--------------------------------- 2 files changed, 28 insertions(+), 70 deletions(-)
net/atm/atm_sysfs.c +8 -14
@@ -33,23 +33,17 @@ static ssize_t show_atmaddress(struct device *cdev,unsigned long flags;struct atm_dev *adev =to_atm_dev (cdev);struct atm_dev_addr *aaddr; -int bin[] = {1 ,2 ,10 ,6 ,1 }, *fmt = bin; -int i, j, count =0 ; +int count =0 ;spin_lock_irqsave (&adev->lock, flags);list_for_each_entry (aaddr, &adev->local, entry) { -for (i =0 , j =0 ; i <ATM_ESA_LEN ; ++i, ++j) { -if (j == *fmt) { - count +=scnprintf (buf + count, -PAGE_SIZE - count,"." ); - ++fmt; - j =0 ; - } - count +=scnprintf (buf + count, -PAGE_SIZE - count,"%02x" , - aaddr->addr.sas_addr.prv[i]); - } - count +=scnprintf (buf + count,PAGE_SIZE - count,"\n" ); + count +=scnprintf (buf + count,PAGE_SIZE - count, +"%1phN.%2phN.%10phN.%6phN.%1phN\n" , + &aaddr->addr.sas_addr.prv[0 ], + &aaddr->addr.sas_addr.prv[1 ], + &aaddr->addr.sas_addr.prv[3 ], + &aaddr->addr.sas_addr.prv[13 ], + &aaddr->addr.sas_addr.prv[19 ]); }spin_unlock_irqrestore (&adev->lock, flags);
net/atm/lec.c +20 -56
125 lines not on this page · raw message
Signature · 1 line
2.24.1
From: Andy Shevchenko <[email protected]>
Date: Thu, 23 Jan 2020 16:20:02 +0200
Quoted 3 lines
Use %*ph format to print small buffer as hex string.
Signed-off-by Andy Shevchenko <[email protected]>
Applied, thanks.