Skip to contentSkip to conversation

packagegroup-base: only pull in dosfstools if licensing allows

PATCH In review Ross Burton 2 participants 2 messages Jan 24, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 packagegroup-base: only pull in dosfstools if licensing allows

packagegroup-base-vfat RRECOMMENDS on dosfstools, but this is GPLv3 so may be blacklisted. Respect INCOMPATIBLE_LICENSE and don't recommend if GPL-3.0 has been blacklisted.

(From OE-Core rev: de780ebf76893db43e1a55c54b0c5fbb7537880c)

---
 meta/recipes-core/packagegroups/packagegroup-base.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/packagegroups/packagegroup-base.bb +1 -1
index 1f802da09b7..3910500325d 100644
@@ -168,7 +168,7 @@ RRECOMMENDS_packagegroup-base-vfat = "\
     kernel-module-vfat \
     kernel-module-nls-iso8859-1 \
     kernel-module-nls-cp437 \
-    dosfstools"
+    ${@incompatible_license_contains("GPL-3.0", "", "dosfstools", d)}"
 
 SUMMARY_packagegroup-base-alsa = "ALSA sound support"
 RDEPENDS_packagegroup-base-alsa = "\
Signature · 1 line
2.20.1
#1 lore raw
Quoted 27 lines · Ross Burton

packagegroup-base-vfat RRECOMMENDS on dosfstools, but this is GPLv3 so
may be blacklisted. Respect INCOMPATIBLE_LICENSE and don't recommend if
GPL-3.0 has been blacklisted.

(From OE-Core rev: de780ebf76893db43e1a55c54b0c5fbb7537880c)

---
 meta/recipes-core/packagegroups/packagegroup-base.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/packagegroups/packagegroup-base.bb +1 -1
index 1f802da09b7..3910500325d 100644
@@ -168,7 +168,7 @@ RRECOMMENDS_packagegroup-base-vfat = "\
     kernel-module-vfat \
     kernel-module-nls-iso8859-1 \
     kernel-module-nls-cp437 \
-    dosfstools"
+    ${@incompatible_license_contains("GPL-3.0", "", "dosfstools",

d)}"

Quoted 2 lines

SUMMARY_packagegroup-base-alsa = "ALSA sound support" RDEPENDS_packagegroup-base-alsa = "\

Not sure quite what happened but:

https://autobuilder.yoctoproject.org/typhoon/#/builders/39/builds/1494/steps/8/logs/step4d

Cheers,

Richard