Skip to contentSkip to conversation

Btrfs: send, fix emission of invalid clone operations within the same file

PATCH Superseded [email protected] 4 participants 10 messages Jan 24, 2020 – Feb 12, 2020 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Btrfs: send, fix emission of invalid clone operations within the same file

From: Filipe Manana <[email protected]>

When doing an incremental send and a file has extents shared with itself at different file offsets, it's possible for send to emit clone operations that will fail at the destination because the source range goes beyond the file's current size. This happens when the file size has increased in the send snapshot, there is a hole between the shared extents and both shared extents are at file offsets which are greater the file's size in the parent snapshot.

Example:

  $ mkfs.btrfs -f /dev/sdb
  $ mount /dev/sdb /mnt/sdb
  $ xfs_io -f -c "pwrite -S 0xf1 0 64K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/base
  $ btrfs send -f /tmp/1.snap /mnt/sdb/base

# Create a 320K extent at file offset 512K.

  $ xfs_io -c "pwrite -S 0xab 512K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xcd 576K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xef 640K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x64 704K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x73 768K 64K" /mnt/sdb/foobar

# Clone part of that 320K extent into a lower file offset (192K). # This file offset is greater than the file's size in the parent

  # snapshot (64K). Also the clone range is a bit behind the offset of
  # the 320K extent so that we leave a hole between the shared extents.
  $ xfs_io -c "reflink /mnt/sdb/foobar 448K 192K 192K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/incr
  $ btrfs send -p /mnt/sdb/base -f /tmp/2.snap /mnt/sdb/incr
  $ mkfs.btrfs -f /dev/sdc
  $ mount /dev/sdc /mnt/sdc
  $ btrfs receive -f /tmp/1.snap /mnt/sdc
  $ btrfs receive -f /tmp/2.snap /mnt/sdc
  ERROR: failed to clone extents to foobar: Invalid argument

The problem is that after processing the extent at file offset 192K, send does not issue a write operation full of zeroes for the hole between that extent and the extent starting at file offset 520K (hole range from 384K to 512K), this is because the hole is at an offset larger the size of the file in the parent snapshot (384K > 64K). As a consequence the field 'cur_inode_next_write_offset' of the send context remains with a value of 384K when we start to process the extent at file offset 512K, which is the value set after processing the extent at offset 192K.

This screws up the lookup of possible extents to clone because due to an incorrect value of 'cur_inode_next_write_offset' we can now consider extents for cloning, in the same inode, that lie beyond the current size of the file in the receiver of the send stream. Also, when checking if an extent in the same file can be used for cloning, we must also check that not only its start offset doesn't start at or beyond the current eof of the file in the receiver but that the source range doesn't go beyond current eof, that is we must check offset + length does not cross the current eof, as that makes clone operations fail with -EINVAL.

So fix this by updating 'cur_inode_next_write_offset' whenever we start processing an extent and checking an extent's offset and length when considering it for cloning operations.

A test case for fstests follows soon.

Fixes 11f2069c113e02 ("Btrfs: send, allow clone operations within the same file")
---
 fs/btrfs/send.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
fs/btrfs/send.c +14 -1
index 091e5bc8c7ea..0b42dac8a35f 100644
@@ -1269,7 +1269,8 @@ static int __iterate_backrefs(u64 ino, u64 offset, u64 root, void *ctx_)
 		 * destination of the stream.
 		 */
 		if (ino == bctx->cur_objectid &&
-		    offset >= bctx->sctx->cur_inode_next_write_offset)
+		    offset + bctx->extent_len >
+		    bctx->sctx->cur_inode_next_write_offset)
 			return 0;
 	}
 
@@ -5804,6 +5805,18 @@ static int process_extent(struct send_ctx *sctx,
 		}
 	}
 
+	/*
+	 * There might be a hole between the end of the last processed extent
+	 * and this extent, and we may have not sent a write operation for that
+	 * hole because it was not needed (range is beyond eof in the parent
+	 * snapshot). So adjust the next write offset to the offset of this
+	 * extent, as we want to make sure we don't do mistakes when checking if
+	 * we can clone this extent from some other offset in this inode or when
+	 * detecting if we need to issue a truncate operation when finishing the
+	 * processing this inode.
+	 */
+	sctx->cur_inode_next_write_offset = key->offset;
+
 	ret = find_extent_clone(sctx, path, key->objectid, key->offset,
 			sctx->cur_inode_size, &found_clone);
 	if (ret != -ENOENT && ret < 0)
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 61 lines · On 1/24/20 6:52 AM, [email protected] wrote:

From: Filipe Manana <[email protected]>

When doing an incremental send and a file has extents shared with itself at different file offsets, it's possible for send to emit clone operations that will fail at the destination because the source range goes beyond the file's current size. This happens when the file size has increased in the send snapshot, there is a hole between the shared extents and both shared extents are at file offsets which are greater the file's size in the parent snapshot.

Example:

   $ mkfs.btrfs -f /dev/sdb
   $ mount /dev/sdb /mnt/sdb
   $ xfs_io -f -c "pwrite -S 0xf1 0 64K" /mnt/sdb/foobar
   $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/base
   $ btrfs send -f /tmp/1.snap /mnt/sdb/base

# Create a 320K extent at file offset 512K.

   $ xfs_io -c "pwrite -S 0xab 512K 64K" /mnt/sdb/foobar
   $ xfs_io -c "pwrite -S 0xcd 576K 64K" /mnt/sdb/foobar
   $ xfs_io -c "pwrite -S 0xef 640K 64K" /mnt/sdb/foobar
   $ xfs_io -c "pwrite -S 0x64 704K 64K" /mnt/sdb/foobar
   $ xfs_io -c "pwrite -S 0x73 768K 64K" /mnt/sdb/foobar

# Clone part of that 320K extent into a lower file offset (192K). # This file offset is greater than the file's size in the parent

   # snapshot (64K). Also the clone range is a bit behind the offset of
   # the 320K extent so that we leave a hole between the shared extents.
   $ xfs_io -c "reflink /mnt/sdb/foobar 448K 192K 192K" /mnt/sdb/foobar
   $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/incr
   $ btrfs send -p /mnt/sdb/base -f /tmp/2.snap /mnt/sdb/incr
   $ mkfs.btrfs -f /dev/sdc
   $ mount /dev/sdc /mnt/sdc
   $ btrfs receive -f /tmp/1.snap /mnt/sdc
   $ btrfs receive -f /tmp/2.snap /mnt/sdc
   ERROR: failed to clone extents to foobar: Invalid argument

The problem is that after processing the extent at file offset 192K, send does not issue a write operation full of zeroes for the hole between that extent and the extent starting at file offset 520K (hole range from 384K to 512K), this is because the hole is at an offset larger the size of the file in the parent snapshot (384K > 64K). As a consequence the field 'cur_inode_next_write_offset' of the send context remains with a value of 384K when we start to process the extent at file offset 512K, which is the value set after processing the extent at offset 192K.

This screws up the lookup of possible extents to clone because due to an incorrect value of 'cur_inode_next_write_offset' we can now consider extents for cloning, in the same inode, that lie beyond the current size of the file in the receiver of the send stream. Also, when checking if an extent in the same file can be used for cloning, we must also check that not only its start offset doesn't start at or beyond the current eof of the file in the receiver but that the source range doesn't go beyond current eof, that is we must check offset + length does not cross the current eof, as that makes clone operations fail with -EINVAL.

Quoted 8 lines

So fix this by updating 'cur_inode_next_write_offset' whenever we start processing an extent and checking an extent's offset and length when considering it for cloning operations.

A test case for fstests follows soon.

Fixes 11f2069c113e02 ("Btrfs: send, allow clone operations within the same file")

Thanks,

Josef

author Tested-by Craig Andrews on v1 1/1
#2 lore raw
In reply to [email protected]
Quoted 62 lines · On Fri, Jan 24, 2020 at 11:54 AM <[email protected]> wrote:

From: Filipe Manana <[email protected]>

When doing an incremental send and a file has extents shared with itself at different file offsets, it's possible for send to emit clone operations that will fail at the destination because the source range goes beyond the file's current size. This happens when the file size has increased in the send snapshot, there is a hole between the shared extents and both shared extents are at file offsets which are greater the file's size in the parent snapshot.

Example:

  $ mkfs.btrfs -f /dev/sdb
  $ mount /dev/sdb /mnt/sdb
  $ xfs_io -f -c "pwrite -S 0xf1 0 64K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/base
  $ btrfs send -f /tmp/1.snap /mnt/sdb/base

# Create a 320K extent at file offset 512K.

  $ xfs_io -c "pwrite -S 0xab 512K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xcd 576K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xef 640K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x64 704K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x73 768K 64K" /mnt/sdb/foobar

# Clone part of that 320K extent into a lower file offset (192K). # This file offset is greater than the file's size in the parent

  # snapshot (64K). Also the clone range is a bit behind the offset of
  # the 320K extent so that we leave a hole between the shared extents.
  $ xfs_io -c "reflink /mnt/sdb/foobar 448K 192K 192K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/incr
  $ btrfs send -p /mnt/sdb/base -f /tmp/2.snap /mnt/sdb/incr
  $ mkfs.btrfs -f /dev/sdc
  $ mount /dev/sdc /mnt/sdc
  $ btrfs receive -f /tmp/1.snap /mnt/sdc
  $ btrfs receive -f /tmp/2.snap /mnt/sdc
  ERROR: failed to clone extents to foobar: Invalid argument

The problem is that after processing the extent at file offset 192K, send does not issue a write operation full of zeroes for the hole between that extent and the extent starting at file offset 520K (hole range from 384K to 512K), this is because the hole is at an offset larger the size of the file in the parent snapshot (384K > 64K). As a consequence the field 'cur_inode_next_write_offset' of the send context remains with a value of 384K when we start to process the extent at file offset 512K, which is the value set after processing the extent at offset 192K.

This screws up the lookup of possible extents to clone because due to an incorrect value of 'cur_inode_next_write_offset' we can now consider extents for cloning, in the same inode, that lie beyond the current size of the file in the receiver of the send stream. Also, when checking if an extent in the same file can be used for cloning, we must also check that not only its start offset doesn't start at or beyond the current eof of the file in the receiver but that the source range doesn't go beyond current eof, that is we must check offset + length does not cross the current eof, as that makes clone operations fail with -EINVAL.

Quoted 8 lines

So fix this by updating 'cur_inode_next_write_offset' whenever we start processing an extent and checking an extent's offset and length when considering it for cloning operations.

A test case for fstests follows soon.

Fixes 11f2069c113e02 ("Btrfs: send, allow clone operations within the same file")

(on behalf of Craig, see
https://lore.kernel.org/linux-btrfs/[email protected]/)

Quoted 40 lines
---
 fs/btrfs/send.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
fs/btrfs/send.c +14 -2
index 091e5bc8c7ea..0b42dac8a35f 100644
@@ -1269,7 +1269,8 @@ static int __iterate_backrefs(u64 ino, u64 offset, u64 root, void *ctx_)
                 * destination of the stream.
                 */
                if (ino == bctx->cur_objectid &&
-                   offset >= bctx->sctx->cur_inode_next_write_offset)
+                   offset + bctx->extent_len >
+                   bctx->sctx->cur_inode_next_write_offset)
                        return 0;
        }
 
@@ -5804,6 +5805,18 @@ static int process_extent(struct send_ctx *sctx,
                }
        }
 
+       /*
+        * There might be a hole between the end of the last processed extent
+        * and this extent, and we may have not sent a write operation for that
+        * hole because it was not needed (range is beyond eof in the parent
+        * snapshot). So adjust the next write offset to the offset of this
+        * extent, as we want to make sure we don't do mistakes when checking if
+        * we can clone this extent from some other offset in this inode or when
+        * detecting if we need to issue a truncate operation when finishing the
+        * processing this inode.
+        */
+       sctx->cur_inode_next_write_offset = key->offset;
+
        ret = find_extent_clone(sctx, path, key->objectid, key->offset,
                        sctx->cur_inode_size, &found_clone);
        if (ret != -ENOENT && ret < 0)
--

2.11.0

#3 lore raw
In reply to [email protected]
Quoted 61 lines · On Fri, Jan 24, 2020 at 11:52:04AM +0000, [email protected] wrote:

From: Filipe Manana <[email protected]>

When doing an incremental send and a file has extents shared with itself at different file offsets, it's possible for send to emit clone operations that will fail at the destination because the source range goes beyond the file's current size. This happens when the file size has increased in the send snapshot, there is a hole between the shared extents and both shared extents are at file offsets which are greater the file's size in the parent snapshot.

Example:

  $ mkfs.btrfs -f /dev/sdb
  $ mount /dev/sdb /mnt/sdb
  $ xfs_io -f -c "pwrite -S 0xf1 0 64K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/base
  $ btrfs send -f /tmp/1.snap /mnt/sdb/base

# Create a 320K extent at file offset 512K.

  $ xfs_io -c "pwrite -S 0xab 512K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xcd 576K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xef 640K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x64 704K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x73 768K 64K" /mnt/sdb/foobar

# Clone part of that 320K extent into a lower file offset (192K). # This file offset is greater than the file's size in the parent

  # snapshot (64K). Also the clone range is a bit behind the offset of
  # the 320K extent so that we leave a hole between the shared extents.
  $ xfs_io -c "reflink /mnt/sdb/foobar 448K 192K 192K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/incr
  $ btrfs send -p /mnt/sdb/base -f /tmp/2.snap /mnt/sdb/incr
  $ mkfs.btrfs -f /dev/sdc
  $ mount /dev/sdc /mnt/sdc
  $ btrfs receive -f /tmp/1.snap /mnt/sdc
  $ btrfs receive -f /tmp/2.snap /mnt/sdc
  ERROR: failed to clone extents to foobar: Invalid argument

The problem is that after processing the extent at file offset 192K, send does not issue a write operation full of zeroes for the hole between that extent and the extent starting at file offset 520K (hole range from 384K to 512K), this is because the hole is at an offset larger the size of the file in the parent snapshot (384K > 64K). As a consequence the field 'cur_inode_next_write_offset' of the send context remains with a value of 384K when we start to process the extent at file offset 512K, which is the value set after processing the extent at offset 192K.

This screws up the lookup of possible extents to clone because due to an incorrect value of 'cur_inode_next_write_offset' we can now consider extents for cloning, in the same inode, that lie beyond the current size of the file in the receiver of the send stream. Also, when checking if an extent in the same file can be used for cloning, we must also check that not only its start offset doesn't start at or beyond the current eof of the file in the receiver but that the source range doesn't go beyond current eof, that is we must check offset + length does not cross the current eof, as that makes clone operations fail with -EINVAL.

Quoted 8 lines

So fix this by updating 'cur_inode_next_write_offset' whenever we start processing an extent and checking an extent's offset and length when considering it for cloning operations.

A test case for fstests follows soon.

Fixes 11f2069c113e02 ("Btrfs: send, allow clone operations within the same file")

Added to misc-next, with the tested-by tag, thanks.

#4 lore raw
Quoted 67 lines · David Sterba
Quoted 65 lines · On Fri, Jan 24, 2020 at 11:52:04AM +0000, [email protected] wrote:

From: Filipe Manana <[email protected]>

When doing an incremental send and a file has extents shared with itself at different file offsets, it's possible for send to emit clone operations that will fail at the destination because the source range goes beyond the file's current size. This happens when the file size has increased in the send snapshot, there is a hole between the shared extents and both shared extents are at file offsets which are greater the file's size in the parent snapshot.

Example:

  $ mkfs.btrfs -f /dev/sdb
  $ mount /dev/sdb /mnt/sdb
  $ xfs_io -f -c "pwrite -S 0xf1 0 64K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/base
  $ btrfs send -f /tmp/1.snap /mnt/sdb/base

# Create a 320K extent at file offset 512K.

  $ xfs_io -c "pwrite -S 0xab 512K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xcd 576K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xef 640K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x64 704K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x73 768K 64K" /mnt/sdb/foobar

# Clone part of that 320K extent into a lower file offset (192K). # This file offset is greater than the file's size in the parent

  # snapshot (64K). Also the clone range is a bit behind the offset of
  # the 320K extent so that we leave a hole between the shared extents.
  $ xfs_io -c "reflink /mnt/sdb/foobar 448K 192K 192K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/incr
  $ btrfs send -p /mnt/sdb/base -f /tmp/2.snap /mnt/sdb/incr
  $ mkfs.btrfs -f /dev/sdc
  $ mount /dev/sdc /mnt/sdc
  $ btrfs receive -f /tmp/1.snap /mnt/sdc
  $ btrfs receive -f /tmp/2.snap /mnt/sdc
  ERROR: failed to clone extents to foobar: Invalid argument

The problem is that after processing the extent at file offset 192K, send does not issue a write operation full of zeroes for the hole between that extent and the extent starting at file offset 520K (hole range from 384K to 512K), this is because the hole is at an offset larger the size of the file in the parent snapshot (384K > 64K). As a consequence the field 'cur_inode_next_write_offset' of the send context remains with a value of 384K when we start to process the extent at file offset 512K, which is the value set after processing the extent at offset 192K.

This screws up the lookup of possible extents to clone because due to an incorrect value of 'cur_inode_next_write_offset' we can now consider extents for cloning, in the same inode, that lie beyond the current size of the file in the receiver of the send stream. Also, when checking if an extent in the same file can be used for cloning, we must also check that not only its start offset doesn't start at or beyond the current eof of the file in the receiver but that the source range doesn't go beyond current eof, that is we must check offset + length does not cross the current eof, as that makes clone operations fail with -EINVAL.

So fix this by updating 'cur_inode_next_write_offset' whenever we start processing an extent and checking an extent's offset and length when considering it for cloning operations.

Quoted 6 lines
Quoted 4 lines

A test case for fstests follows soon.

Fixes 11f2069c113e02 ("Btrfs: send, allow clone operations within the same file")

Added to misc-next, with the tested-by tag, thanks.

Hold on a bit, one hunk of the patch besides not being necessary, it causes problems with fallocated extents beyond i_size and trailing holes.
I'll run some more tests to confirm the hunk is not needed and see if Craig can test it too in the meanwhile.

Thanks.

#5 lore raw

PATCH v2 1/1 Btrfs: send, fix emission of invalid clone operations within the same file

In reply to [email protected]

From: Filipe Manana <[email protected]>

When doing an incremental send and a file has extents shared with itself at different file offsets, it's possible for send to emit clone operations that will fail at the destination because the source range goes beyond the file's current size. This happens when the file size has increased in the send snapshot, there is a hole between the shared extents and both shared extents are at file offsets which are greater the file's size in the parent snapshot.

Example:

  $ mkfs.btrfs -f /dev/sdb
  $ mount /dev/sdb /mnt/sdb
  $ xfs_io -f -c "pwrite -S 0xf1 0 64K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/base
  $ btrfs send -f /tmp/1.snap /mnt/sdb/base

# Create a 320K extent at file offset 512K.

  $ xfs_io -c "pwrite -S 0xab 512K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xcd 576K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0xef 640K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x64 704K 64K" /mnt/sdb/foobar
  $ xfs_io -c "pwrite -S 0x73 768K 64K" /mnt/sdb/foobar

# Clone part of that 320K extent into a lower file offset (192K). # This file offset is greater than the file's size in the parent

  # snapshot (64K). Also the clone range is a bit behind the offset of
  # the 320K extent so that we leave a hole between the shared extents.
  $ xfs_io -c "reflink /mnt/sdb/foobar 448K 192K 192K" /mnt/sdb/foobar
  $ btrfs subvolume snapshot -r /mnt/sdb /mnt/sdb/incr
  $ btrfs send -p /mnt/sdb/base -f /tmp/2.snap /mnt/sdb/incr
  $ mkfs.btrfs -f /dev/sdc
  $ mount /dev/sdc /mnt/sdc
  $ btrfs receive -f /tmp/1.snap /mnt/sdc
  $ btrfs receive -f /tmp/2.snap /mnt/sdc
  ERROR: failed to clone extents to foobar: Invalid argument

The problem is that after processing the extent at file offset 256K, which refers to the first 128K of the 320K extent created by the buffered write operations, we have 'cur_inode_next_write_offset' set to 384K, which corresponds to the end offset of the partially shared extent (256K + 128K) and to the current file size in the receiver. Then when we process the extent at offset 512K, we do extent backreference iteration to figure out if we can clone the extent from some other inode or from the same inode, and we consider the extent at offset 256K of the same inode as a valid source for a clone operation, which is not correct because at that point the current file size in the receiver is 384K, which corresponds to the end of last processed extent (at file offset 256K), so using a clone source range from 256K to 256K + 320K is invalid because that goes past the current size of the file (384K) - this makes the receiver get an -EINVAL error when attempting the clone operation.

So fix this by excluding clone sources that have a range that goes beyond the current file size in the receiver when iterating extent backreferences.

A test case for fstests follows soon.

Fixes 11f2069c113e02 ("Btrfs: send, allow clone operations within the same file")

---

v2: Removed unncessary hunk, which sey sctx->cur_inode_next_write_offset, not
because it's not necessary to fix this issue, but also caused problems for files that got a prealloc extents beyond their size in the send snapshot, got their size increased and have a trailing hole (ending at the new file size).

 fs/btrfs/send.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/btrfs/send.c +2 -1
index 091e5bc8c7ea..a055b657cb85 100644
@@ -1269,7 +1269,8 @@ static int __iterate_backrefs(u64 ino, u64 offset, u64 root, void *ctx_)
 		 * destination of the stream.
 		 */
 		if (ino == bctx->cur_objectid &&
-		    offset >= bctx->sctx->cur_inode_next_write_offset)
+		    offset + bctx->extent_len >
+		    bctx->sctx->cur_inode_next_write_offset)
 			return 0;
 	}
 
Signature · 1 line
2.11.0
#9 lore raw
Quoted 1 line · Filipe Manana

It's a bug fix, so yes. In fact you can check that yourself:

Thanks... actually I did check it directly in linux-stable.git ... but it must have been merged shortly afterwards ^^

Cheers,
Chris.