package/liboping: remove -Werror build flag
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/2 package/liboping: remove -Werror build flag
Dear Nathaniel,
Le ven. 24 janv. 2020 ? 15:36, Nathaniel Roach <[email protected]> a ?crit :
Quoted 3 lines
Same as https://bugs.gentoo.org/675344 - when building, GCC will fail the build due to a truncation warning.
Can you be more specific on the build failure? For example, by providing a link on autobuilder?
Otherwise, I would prefer an upstreamable solution such as adding a --disable-werror option or adding a patch that fixes the issue. There is a pending PR on a truncation error on upstream github:
https://github.com/octo/liboping/pull/50.
Is it related to your build failure? In this case, I would suggest to retrieve this commit.
Quoted 44 lines
Remove -Wall and -Werror from Makefile.am and run automake to apply the change
Signed-off-by Nathaniel Roach <[email protected]>--- package/liboping/0002-no-werror.patch | 14 ++++++++++++++ package/liboping/liboping.mk | 1 + 2 files changed, 15 insertions(+) create mode 100644 package/liboping/0002-no-werror.patchpackage/liboping/0002-no-werror.patch new file +14
-0@@ -0,0 +1,14 @@ +--- a/src/Makefile.am ++++ b/src/Makefile.am +@@ -2,10 +2,6 @@ AUTOMAKE_OPTIONS = foreign no-dependencies + + SUBDIRS = mans + +-if COMPILER_IS_GCC +-AM_CFLAGS = -Wall -Werror +-endif +- + include_HEADERS = oping.h + lib_LTLIBRARIES = liboping.la + +package/liboping/liboping.mk +1
-1@@ -11,6 +11,7 @@ LIBOPING_INSTALL_STAGING = YES LIBOPING_CONF_OPTS = --without-perl-bindings LIBOPING_LICENSE = LGPL-2.1+, GPL-2.0 LIBOPING_LICENSE_FILES = COPYING +LIBOPING_AUTORECONF = YES ifeq ($(BR2_PACKAGE_NCURSES),y) LIBOPING_DEPENDENCIES += ncurses --
Quoted 2 lines
2.20.1
Best Regards,
Fabrice
PATCH 1/2 package/liboping: remove -Werror build flag
Hi Fabrice,
Quoted 5 lines · Fabrice Fontaine
Dear Nathaniel,
Le ven. 24 janv. 2020 ? 15:36, Nathaniel Roach <[email protected]> a ?crit :
Quoted 2 lines
Same as https://bugs.gentoo.org/675344 - when building, GCC will fail the build due to a truncation warning.
Quoted 8 lines
Can you be more specific on the build failure? For example, by providing a link on autobuilder?
Otherwise, I would prefer an upstreamable solution such as adding a --disable-werror option or adding a patch that fixes the issue. There is a pending PR on a truncation error on upstream github:
https://github.com/octo/liboping/pull/50.
Is it related to your build failure? In this case, I would suggest to retrieve this commit.
The error is detailed in the Gentoo bug linked above, and this was their fix for it. There is one single build failure on the autobuilders, and it's got the same error:
http://autobuild.buildroot.org/?reason=liboping-1.10.0
In my case the error is more prevalent, probably due to the parallel build:
Quoted 1 line
Quoted 1 line
Quoted 1 line
liboping 1.10.0 Building
PATH="/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin:/home/nroach44/media/code/buildroot/buildroot-git/output/host/sbin:/home/nroach44/apps/native/wine/latest/usr/local/bin/:/home/nroach44/apps/bin:/usr/sbin:/sbin:/home/nroach44/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games" /usr/bin/make -j5? -C/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/
make[1]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0'
Making all in src
make[2]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'/usr/bin/make? all-recursive
make[3]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
Making all in mans
make[4]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'/bin/bash ../libtool? --tag=CC?? --mode=compile/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
-DHAVE_CONFIG_H -I.?? -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64? -O3?? -c -o
liboping_la-liboping.lo test -f 'liboping.c' || echo './'liboping.c/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
-DHAVE_CONFIG_H -I.?? -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64? -O3?? -c -o oping.o oping.c/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
-DHAVE_CONFIG_H -I.?? -DUSE_NCURSES=1? -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Werror
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3??
-c -o noping-oping.o test -f 'oping.c' || echo './'oping.c
libtool: compile:/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
-DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c liboping.c -fPIC
-DPIC -o .libs/liboping_la-liboping.oliboping.c: In function 'ping_set_ttl':
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:829:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:842:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~liboping.c: In function 'ping_set_qos':
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:869:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:885:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [Makefile:582: liboping_la-liboping.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[3]: *** [Makefile:645: all-recursive] Error 1
make[3]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[2]: *** [Makefile:419: all] Error 2
make[2]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[1]: *** [Makefile:382: all-recursive] Error 1
make[1]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0'
make: *** [package/pkg-generic.mk:260:/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/.stamp_built]
Error 2
I hadn't come across the patch you linked, as the exact error isn't posted within it.
I don't mind patching it either way.
Quoted 48 lines
Quoted 43 lines
Remove -Wall and -Werror from Makefile.am and run automake to apply the change
Signed-off-by Nathaniel Roach <[email protected]>--- package/liboping/0002-no-werror.patch | 14 ++++++++++++++ package/liboping/liboping.mk | 1 + 2 files changed, 15 insertions(+)create mode 100644
package/liboping/0002-no-werror.patchpackage/liboping/0002-no-werror.patch new file +14
-0@@ -0,0 +1,14 @@ +--- a/src/Makefile.am ++++ b/src/Makefile.am +@@ -2,10 +2,6 @@ AUTOMAKE_OPTIONS = foreign no-dependencies + + SUBDIRS = mans + +-if COMPILER_IS_GCC +-AM_CFLAGS = -Wall -Werror +-endif +- + include_HEADERS = oping.h + lib_LTLIBRARIES = liboping.la + +package/liboping/liboping.mk +1
-1@@ -11,6 +11,7 @@ LIBOPING_INSTALL_STAGING = YES LIBOPING_CONF_OPTS = --without-perl-bindings LIBOPING_LICENSE = LGPL-2.1+, GPL-2.0 LIBOPING_LICENSE_FILES = COPYING +LIBOPING_AUTORECONF = YES ifeq ($(BR2_PACKAGE_NCURSES),y) LIBOPING_DEPENDENCIES += ncurses --Quoted 2 lines
2.20.1
Best Regards,
Fabrice
PATCH 1/2 package/liboping: remove -Werror build flag
Hi Nathaniel,
Le dim. 26 janv. 2020 ? 01:16, Nathaniel Roach
<[email protected]> a ?crit :
Quoted 18 lines
Hi Fabrice,
Quoted 5 lines · Fabrice Fontaine
Dear Nathaniel,
Le ven. 24 janv. 2020 ? 15:36, Nathaniel Roach <[email protected]> a ?crit :
Quoted 2 lines
Same as https://bugs.gentoo.org/675344 - when building, GCC will fail the build due to a truncation warning.
Quoted 8 lines
Can you be more specific on the build failure? For example, by providing a link on autobuilder?
Otherwise, I would prefer an upstreamable solution such as adding a --disable-werror option or adding a patch that fixes the issue. There is a pending PR on a truncation error on upstream github:
https://github.com/octo/liboping/pull/50.
Is it related to your build failure? In this case, I would suggest to retrieve this commit.
Quoted 4 lines
The error is detailed in the Gentoo bug linked above, and this was their fix for it. There is one single build failure on the autobuilders, and it's got the same error:
http://autobuild.buildroot.org/?reason=liboping-1.10.0
This error was raised in December 5th 2018 and has been fixed by retrieving an upstream commit instead of disabling -Werror (see
https://patchwork.ozlabs.org/patch/1009066).
There was no more autobuilder failures after this patch was applied. So this is strange that you still get a failure on your local machine. Are you using the master branch or one of the official release (fix was committed to 2018.08.x and 2018.11.x releases)?
Quoted 117 lines
In my case the error is more prevalent, probably due to the parallel build:
Quoted 1 line
Quoted 1 line
Quoted 1 line
liboping 1.10.0 Building
PATH="/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin:/home/nroach44/media/code/buildroot/buildroot-git/output/host/sbin:/home/nroach44/apps/native/wine/latest/usr/local/bin/:/home/nroach44/apps/bin:/usr/sbin:/sbin:/home/nroach44/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games"
/usr/bin/make-j5 -C/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/
make[1]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0'
Making all in src
make[2]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'/usr/bin/makeall-recursive
make[3]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
Making all in mans
make[4]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'/bin/bash../libtool --tag=CC --mode=compile/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc(quoted diff) +0
-3-DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c -oliboping_la-liboping.lo
test -f 'liboping.c' || echo './'liboping.c/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc(quoted diff) +0
-3-DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c -o oping.o oping.c
/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc(quoted diff) +0
-4-DHAVE_CONFIG_H -I. -DUSE_NCURSES=1 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c -o noping-oping.o `test -f 'oping.c' || echo './'`oping.clibtool: compile:
/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc(quoted diff) +0
-4-DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c liboping.c -fPIC -DPIC -o .libs/liboping_la-liboping.o
liboping.c: In function 'ping_set_ttl':
liboping.c:207:9: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 242 [-Werror=format-truncation=]"%s: %s", function, message); ^~ liboping.c:829:6: sstrerror (ret, errbuf, sizeof (errbuf))); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into a destination of size 256
snprintf (obj->errmsg, sizeof (obj->errmsg), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"%s: %s", function, message); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ liboping.c:207:9: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 242 [-Werror=format-truncation=] "%s: %s", function, message); ^~ liboping.c:842:6: sstrerror (ret, errbuf, sizeof (errbuf))); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into a destination of size 256
snprintf (obj->errmsg, sizeof (obj->errmsg), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"%s: %s", function, message); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ liboping.c: In function 'ping_set_qos': liboping.c:207:9: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 242 [-Werror=format-truncation=] "%s: %s", function, message); ^~ liboping.c:869:6: sstrerror (ret, errbuf, sizeof (errbuf))); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into a destination of size 256
snprintf (obj->errmsg, sizeof (obj->errmsg), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"%s: %s", function, message); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ liboping.c:207:9: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 242 [-Werror=format-truncation=] "%s: %s", function, message); ^~ liboping.c:885:6: sstrerror (ret, errbuf, sizeof (errbuf))); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into a destination of size 256
snprintf (obj->errmsg, sizeof (obj->errmsg), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"%s: %s", function, message); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~cc1: all warnings being treated as errors
make[4]: *** [Makefile:582: liboping_la-liboping.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src' make[3]: *** [Makefile:645: all-recursive] Error 1
make[3]: Leaving directory '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src' make[2]: *** [Makefile:419: all] Error 2
make[2]: Leaving directory '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src' make[1]: *** [Makefile:382: all-recursive] Error 1
make[1]: Leaving directory '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0'
make: *** [package/pkg-generic.mk:260:/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/.stamp_built] Error 2
Quoted 54 lines
I hadn't come across the patch you linked, as the exact error isn't posted within it.
I don't mind patching it either way.
Quoted 48 lines
Quoted 43 lines
Remove -Wall and -Werror from Makefile.am and run automake to apply the change
Signed-off-by Nathaniel Roach <[email protected]>--- package/liboping/0002-no-werror.patch | 14 ++++++++++++++ package/liboping/liboping.mk | 1 + 2 files changed, 15 insertions(+)create mode 100644
package/liboping/0002-no-werror.patchpackage/liboping/0002-no-werror.patch new file +14
-0@@ -0,0 +1,14 @@ +--- a/src/Makefile.am ++++ b/src/Makefile.am +@@ -2,10 +2,6 @@ AUTOMAKE_OPTIONS = foreign no-dependencies + + SUBDIRS = mans + +-if COMPILER_IS_GCC +-AM_CFLAGS = -Wall -Werror +-endif +- + include_HEADERS = oping.h + lib_LTLIBRARIES = liboping.la + +package/liboping/liboping.mk +1
-1@@ -11,6 +11,7 @@ LIBOPING_INSTALL_STAGING = YES LIBOPING_CONF_OPTS = --without-perl-bindings LIBOPING_LICENSE = LGPL-2.1+, GPL-2.0 LIBOPING_LICENSE_FILES = COPYING +LIBOPING_AUTORECONF = YES ifeq ($(BR2_PACKAGE_NCURSES),y) LIBOPING_DEPENDENCIES += ncurses --Quoted 2 lines
2.20.1
Best Regards,
Fabrice
Best Regards,
Fabrice
PATCH 1/2 package/liboping: remove -Werror build flag
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
Hi,
Quoted 13 lines
Quoted 9 lines
Quoted 8 lines
Can you be more specific on the build failure? For example, by providing a link on autobuilder?
Otherwise, I would prefer an upstreamable solution such as adding a --disable-werror option or adding a patch that fixes the issue. There is a pending PR on a truncation error on upstream github:
https://github.com/octo/liboping/pull/50.
Is it related to your build failure? In this case, I would suggest to retrieve this commit.Quoted 4 lines
The error is detailed in the Gentoo bug linked above, and this was their fix for it. There is one single build failure on the autobuilders, and it's got the same error:
http://autobuild.buildroot.org/?reason=liboping-1.10.0
Quoted 7 lines
This error was raised in December 5th 2018 and has been fixed by retrieving an upstream commit instead of disabling -Werror (see
https://patchwork.ozlabs.org/patch/1009066).
There was no more autobuilder failures after this patch was applied. So this is strange that you still get a failure on your local machine. Are you using the master branch or one of the official release (fix was committed to 2018.08.x and 2018.11.x releases)?
Any comments on that? In the mean time I have marked the patch as not applicable in patchwork.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/2 package/liboping: remove -Werror build flag
HI Peter, Fabrice,
Quoted 24 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
Hi,
Quoted 13 lines
Quoted 9 lines
Quoted 8 lines
Can you be more specific on the build failure? For example, by providing a link on autobuilder?
Otherwise, I would prefer an upstreamable solution such as adding a --disable-werror option or adding a patch that fixes the issue. There is a pending PR on a truncation error on upstream github:
https://github.com/octo/liboping/pull/50.
Is it related to your build failure? In this case, I would suggest to retrieve this commit.Quoted 4 lines
The error is detailed in the Gentoo bug linked above, and this was their fix for it. There is one single build failure on the autobuilders, and it's got the same error:
http://autobuild.buildroot.org/?reason=liboping-1.10.0Quoted 7 lines
This error was raised in December 5th 2018 and has been fixed by retrieving an upstream commit instead of disabling -Werror (see
https://patchwork.ozlabs.org/patch/1009066).
There was no more autobuilder failures after this patch was applied. So this is strange that you still get a failure on your local machine. Are you using the master branch or one of the official release (fix was committed to 2018.08.x and 2018.11.x releases)?
Quoted 2 lines
Any comments on that? In the mean time I have marked the patch as not applicable in patchwork.
Apologies for the delays, I'm going to have to test with the BR toolchain instead of my ct-ng one.
PATCH 1/2 package/liboping: remove -Werror build flag
In reply to Peter KorsgaardHI Peter, Fabrice,
Quoted 24 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
Hi,
Quoted 13 lines
Quoted 9 lines
Quoted 8 lines
Can you be more specific on the build failure? For example, by providing a link on autobuilder?
Otherwise, I would prefer an upstreamable solution such as adding a --disable-werror option or adding a patch that fixes the issue. There is a pending PR on a truncation error on upstream github:
https://github.com/octo/liboping/pull/50.
Is it related to your build failure? In this case, I would suggest to retrieve this commit.Quoted 4 lines
The error is detailed in the Gentoo bug linked above, and this was their fix for it. There is one single build failure on the autobuilders, and it's got the same error:
http://autobuild.buildroot.org/?reason=liboping-1.10.0Quoted 7 lines
This error was raised in December 5th 2018 and has been fixed by retrieving an upstream commit instead of disabling -Werror (see
https://patchwork.ozlabs.org/patch/1009066).
There was no more autobuilder failures after this patch was applied. So this is strange that you still get a failure on your local machine. Are you using the master branch or one of the official release (fix was committed to 2018.08.x and 2018.11.x releases)?
Quoted 3 lines
Any comments on that? In the mean time I have marked the patch as not applicable in patchwork.
I'm working off origin/master. When using the following defconfig:
BR2_x86_64=y
BR2_x86_core2=y
BR2_DL_DIR="<snip>"
BR2_OPTIMIZE_3=y
BR2_PIC_PIE=y
BR2_SSP_REGULAR=y BR2_TOOLCHAIN_BUILDROOT_GLIBC=y BR2_PACKAGE_GLIBC_UTILS=y BR2_BINUTILS_VERSION_2_33_X=y BR2_TOOLCHAIN_BUILDROOT_CXX=y BR2_TOOLCHAIN_BUILDROOT_FORTRAN=y BR2_GCC_ENABLE_LTO=y BR2_GCC_ENABLE_GRAPHITE=y BR2_TARGET_GENERIC_PASSWD_SHA512=y BR2_INIT_SYSTEMD=y BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES=y BR2_SYSTEM_BIN_SH_BASH=y BR2_TARGET_GENERIC_GETTY_PORT="tty1" BR2_ENABLE_LOCALE_WHITELIST="C en_US en_AU" BR2_GENERATE_LOCALE="C en_AU" BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="<snip>" BR2_LINUX_KERNEL_INSTALL_TARGET=y BR2_PACKAGE_LIBOPING=y
The build will fail with:
Quoted 1 line
Quoted 1 line
Quoted 1 line
liboping 1.10.0 Building
PATH="/srv/data/build/buildroot/buildroot-git/output/host/bin:/srv/data/build/buildroot/buildroot-git/output/host/sbin:/usr/lib/ccache:/home/nroach44/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games" /usr/bin/make -j13? -C/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/
make[1]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0'
Making all in src
make[2]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'/usr/bin/make? all-recursive
make[3]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
Making all in mans
make[4]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'/bin/bash ../libtool? --tag=CC?? --mode=compile/srv/data/build/buildroot/buildroot-git/output/host/bin/x86_64-buildroot-linux-gnu-gcc
-DHAVE_CONFIG_H -I.?? -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64? -O3?? -c -o
liboping_la-liboping.lo test -f 'liboping.c' || echo './'liboping.c
libtool: compile:/srv/data/build/buildroot/buildroot-git/output/host/bin/x86_64-buildroot-linux-gnu-gcc
-DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c liboping.c -fPIC
-DPIC -o .libs/liboping_la-liboping.oliboping.c: In function 'ping_set_ttl':
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:829:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:842:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~liboping.c: In function 'ping_set_qos':
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:869:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:885:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [Makefile:582: liboping_la-liboping.lo] Error 1
make[4]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[3]: *** [Makefile:645: all-recursive] Error 1
make[3]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[2]: *** [Makefile:419: all] Error 2
make[2]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[1]: *** [Makefile:382: all-recursive] Error 1
make[1]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0'
make: *** [package/pkg-generic.mk:260:/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/.stamp_built]
Error 2
I'm building on Debian 10. When I turn SSP to none, it will build fine.