Skip to contentSkip to conversation

drm/panel: Fix boe,tv101wum-n53 htotal timing

PATCH In review Nicolas Boichat 2 participants 2 messages Jan 25, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel: Fix boe,tv101wum-n53 htotal timing

The datasheet suggests 60 for tHFP, so let's adjust the number accordingly.

This also makes the framerate be 60Hz as intended:
159916.0 * 1000 / ((1200 + 80 + 24 + 60)*(1920 + 20 + 4 + 10)) => 60.00 Hz

---

This also matches the values that we use in our chromeos-4.19 vendor kernel.

Applies on top or drm-misc/drm-misc-next.

 drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c +1 -1
index 01faf8597700005..48a164257d18c35 100644
@@ -645,7 +645,7 @@ static const struct drm_display_mode boe_tv101wum_n53_default_mode = {
 	.hdisplay = 1200,
 	.hsync_start = 1200 + 80,
 	.hsync_end = 1200 + 80 + 24,
-	.htotal = 1200 + 80 + 24 + 40,
+	.htotal = 1200 + 80 + 24 + 60,
 	.vdisplay = 1920,
 	.vsync_start = 1920 + 20,
 	.vsync_end = 1920 + 20 + 4,
Signature · 6 lines
2.25.0.341.g760bfbb309-goog

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Hi Nicolas.

Quoted 8 lines · Nicolas Boichat

The datasheet suggests 60 for tHFP, so let's adjust the number accordingly.

This also makes the framerate be 60Hz as intended:
159916.0 * 1000 / ((1200 + 80 + 24 + 60)*(1920 + 20 + 4 + 10)) => 60.00 Hz

Thanks. Added Fixes: tag and applied to drm-misc-next.

Sam

Quoted 26 lines

---

This also matches the values that we use in our chromeos-4.19 vendor kernel.

Applies on top or drm-misc/drm-misc-next.

 drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c +1 -1
index 01faf8597700005..48a164257d18c35 100644
@@ -645,7 +645,7 @@ static const struct drm_display_mode boe_tv101wum_n53_default_mode = {
 	.hdisplay = 1200,
 	.hsync_start = 1200 + 80,
 	.hsync_end = 1200 + 80 + 24,
-	.htotal = 1200 + 80 + 24 + 40,
+	.htotal = 1200 + 80 + 24 + 60,
 	.vdisplay = 1920,
 	.vsync_start = 1920 + 20,
 	.vsync_end = 1920 + 20 + 4,
Signature · 1 line
2.25.0.341.g760bfbb309-goog

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel