Skip to contentSkip to conversation

video: mxsfb: call remove() when booting OS

PATCH New Anatolij Gustschin 3 participants 5 messages Jan 25, 2020 – Jan 26, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: mxsfb: call remove() when booting OS

Add DM_FLAG_OS_PREPARE flag to ensure that the driver's remove() callback is invoked before booting the kernel. This is required to stop the LCDIF controller. This was the behaviour with old driver without DM_VIDEO support. Without stopping the LCDIF we sometimes observe incorrect Linux logo position.

Fixes ae0760584b38 ("imx: mx6ul_14x14_evk: convert to DM_VIDEO")
---
 drivers/video/mxsfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/mxsfb.c +1 -1
index c52981053e..c097682d00 100644
@@ -429,6 +429,6 @@ U_BOOT_DRIVER(mxs_video) = {
 	.bind	= mxs_video_bind,
 	.probe	= mxs_video_probe,
 	.remove = mxs_video_remove,
-	.flags	= DM_FLAG_PRE_RELOC,
+	.flags	= DM_FLAG_PRE_RELOC | DM_FLAG_OS_PREPARE,
 };
 #endif /* ifndef CONFIG_DM_VIDEO */
Signature · 1 line
2.17.1
reviewer
#1 lore raw

PATCH 1/1 video: mxsfb: call remove() when booting OS

Hi Anatolij,

Quoted 20 lines · Anatolij Gustschin

Add DM_FLAG_OS_PREPARE flag to ensure that the driver's remove() callback is invoked before booting the kernel. This is required to stop the LCDIF controller. This was the behaviour with old driver without DM_VIDEO support. Without stopping the LCDIF we sometimes observe incorrect Linux logo position.

Fixes ae0760584b38 ("imx: mx6ul_14x14_evk: convert to DM_VIDEO")
---
 drivers/video/mxsfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/mxsfb.c +0 -0
index c52981053e..c097682d00 100644

drivers/video/mxsfb.c U_BOOT_DRIVER(mxs_video) = { · line 432

Quoted 5 lines
drivers/video/mxsfb.c +1 -1
@@ -429,6 +429,6 @@ U_BOOT_DRIVER(mxs_video) = {
        .bind   = mxs_video_bind,
        .probe  = mxs_video_probe,
        .remove = mxs_video_remove,
-       .flags  = DM_FLAG_PRE_RELOC,
+       .flags  = DM_FLAG_PRE_RELOC | DM_FLAG_OS_PREPARE,

Thanks! This fixes the Linux logo shift issue:

One thing I noticed is that after this patch we get a white screen during U-Boot handoff until the kernel logo is shown.

This was not observed with the non DM driver.

Is there a way we could keep the screen black instead of white during the transition?

Thanks

#2 lore raw

PATCH 1/1 video: mxsfb: call remove() when booting OS

Hi Fabio,

On Sat, 25 Jan 2020 19:59:47 -0300
Fabio Estevam festevam at gmail.com wrote:
...

Quoted 4 lines

drivers/video/mxsfb.c U_BOOT_DRIVER(mxs_video) = { · line 432

Quoted 2 lines
drivers/video/mxsfb.c +1 -1
-       .flags  = DM_FLAG_PRE_RELOC,
+       .flags  = DM_FLAG_PRE_RELOC | DM_FLAG_OS_PREPARE,  

Thanks! This fixes the Linux logo shift issue:

Thanks for testing!

...

Quoted 4 lines

One thing I noticed is that after this patch we get a white screen during U-Boot handoff until the kernel logo is shown.

This was not observed with the non DM driver.

I'm not sure where it comes from.

Quoted 2 lines

Is there a way we could keep the screen black instead of white during the transition?

Maybe turning off the backlight could help to keep it black? I've sent a patch, could you please test it? Thanks!

--
Anatolij

reviewer
#3 lore raw

PATCH 1/1 video: mxsfb: call remove() when booting OS

Hi Anatolij,

Quoted 2 lines · Anatolij Gustschin

Maybe turning off the backlight could help to keep it black? I've sent a patch, could you please test it? Thanks!

Yes, your patch worked! Thanks!

#4 lore raw

PATCH 1/1 video: mxsfb: call remove() when booting OS

HI

Quoted 9 lines · Fabio Estevam

Hi Anatolij,

Quoted 2 lines · Anatolij Gustschin

Maybe turning off the backlight could help to keep it black? I've sent a patch, could you please test it? Thanks!

Yes, your patch worked! Thanks!

This is not a general use case. We want sometime to preserve the graphics framebuffer in order
to linux to show persistent one.

Michael

Signature · 4 lines
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |